Skip to content

Commit cf6f86a

Browse files
committed
Merge remote-tracking branch 'upstream/master' into kbn-76473-fix-legacy-log-userAgent
2 parents d1e53b2 + 19bf9ed commit cf6f86a

File tree

334 files changed

+11921
-2940
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

334 files changed

+11921
-2940
lines changed

.github/CODEOWNERS

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,13 @@
6363
/src/plugins/apm_oss/ @elastic/apm-ui
6464
/src/apm.js @watson @vigneshshanmugam
6565

66+
# Client Side Monitoring (lives in APM directories but owned by Uptime)
67+
/x-pack/plugins/apm/e2e/cypress/support/step_definitions/rum @elastic/uptime
68+
/x-pack/plugins/apm/public/application/csmApp.tsx @elastic/uptime
69+
/x-pack/plugins/apm/public/components/app/RumDashboard @elastic/uptime
70+
/x-pack/plugins/apm/server/lib/rum_client @elastic/uptime
71+
/x-pack/plugins/apm/server/routes/rum_client.ts @elastic/uptime
72+
6673
# Beats
6774
/x-pack/legacy/plugins/beats_management/ @elastic/beats
6875

docs/management/advanced-options.asciidoc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,12 @@ working on big documents.
150150
==== Machine learning
151151

152152
[horizontal]
153+
`ml:anomalyDetection:results:enableTimeDefaults`:: Use the default time filter
154+
in the *Single Metric Viewer* and *Anomaly Explorer*. If this setting is
155+
disabled, the results for the full time range are shown.
156+
`ml:anomalyDetection:results:timeDefaults`:: Sets the default time filter for
157+
viewing {anomaly-job} results. This setting must contain `from` and `to` values (see {ref}/common-options.html#date-math[accepted formats]). It is ignored
158+
unless `ml:anomalyDetection:results:enableTimeDefaults` is enabled.
153159
`ml:fileDataVisualizerMaxFileSize`:: Sets the file size limit when importing
154160
data in the {data-viz}. The default value is `100MB`. The highest supported
155161
value for this setting is `1GB`.

docs/settings/alert-action-settings.asciidoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ You can configure the following settings in the `kibana.yml` file.
3737
[cols="2*<"]
3838
|===
3939

40-
| `xpack.actions.whitelistedHosts` {ess-icon}
41-
| A list of hostnames that {kib} is allowed to connect to when built-in actions are triggered. It defaults to `[*]`, allowing any host, but keep in mind the potential for SSRF attacks when hosts are not explicitly whitelisted. An empty list `[]` can be used to block built-in actions from making any external connections. +
40+
| `xpack.actions.allowedHosts` {ess-icon}
41+
| A list of hostnames that {kib} is allowed to connect to when built-in actions are triggered. It defaults to `[*]`, allowing any host, but keep in mind the potential for SSRF attacks when hosts are not explicitly added to the allowed hosts. An empty list `[]` can be used to block built-in actions from making any external connections. +
4242
+
43-
Note that hosts associated with built-in actions, such as Slack and PagerDuty, are not automatically whitelisted. If you are not using the default `[*]` setting, you must ensure that the corresponding endpoints are whitelisted as well.
43+
Note that hosts associated with built-in actions, such as Slack and PagerDuty, are not automatically added to allowed hosts. If you are not using the default `[*]` setting, you must ensure that the corresponding endpoints are added to the allowed hosts as well.
4444

4545
| `xpack.actions.enabledActionTypes` {ess-icon}
4646
| A list of action types that are enabled. It defaults to `[*]`, enabling all types. The names for built-in {kib} action types are prefixed with a `.` and include: `.server-log`, `.slack`, `.email`, `.index`, `.pagerduty`, and `.webhook`. An empty list `[]` will disable all action types. +

docs/user/alerting/action-types/email.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Email connectors have the following configuration properties:
1212

1313
Name:: The name of the connector. The name is used to identify a connector in the management UI connector listing, or in the connector list when configuring an action.
1414
Sender:: The from address for all emails sent with this connector, specified in `user@host-name` format.
15-
Host:: Host name of the service provider. If you are using the <<action-settings, `xpack.actions.whitelistedHosts`>> setting, make sure this hostname is whitelisted.
15+
Host:: Host name of the service provider. If you are using the <<action-settings, `xpack.actions.allowedHosts`>> setting, make sure this hostname is added to the allowed hosts.
1616
Port:: The port to connect to on the service provider.
1717
Secure:: If true the connection will use TLS when connecting to the service provider. See https://nodemailer.com/smtp/#tls-options[nodemailer TLS documentation] for more information.
1818
Username:: username for 'login' type authentication.

docs/user/alerting/action-types/pagerduty.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ This is an irreversible action and impacts all alerts that use this connector.
132132
PagerDuty connectors have the following configuration properties:
133133

134134
Name:: The name of the connector. The name is used to identify a connector in the management UI connector listing, or in the connector list when configuring an action.
135-
API URL:: An optional PagerDuty event URL. Defaults to `https://events.pagerduty.com/v2/enqueue`. If you are using the <<action-settings, `xpack.actions.whitelistedHosts`>> setting, make sure the hostname is whitelisted.
135+
API URL:: An optional PagerDuty event URL. Defaults to `https://events.pagerduty.com/v2/enqueue`. If you are using the <<action-settings, `xpack.actions.allowedHosts`>> setting, make sure the hostname is added to the allowed hosts.
136136
Integration Key:: A 32 character PagerDuty Integration Key for an integration on a service, also referred to as the routing key.
137137

138138
[float]

docs/user/alerting/action-types/slack.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ The Slack action type uses https://api.slack.com/incoming-webhooks[Slack Incomin
1111
Slack connectors have the following configuration properties:
1212

1313
Name:: The name of the connector. The name is used to identify a connector in the management UI connector listing, or in the connector list when configuring an action.
14-
Webhook URL:: The URL of the incoming webhook. See https://api.slack.com/messaging/webhooks#getting_started[Slack Incoming Webhooks] for instructions on generating this URL. If you are using the <<action-settings, `xpack.actions.whitelistedHosts`>> setting, make sure the hostname is whitelisted.
14+
Webhook URL:: The URL of the incoming webhook. See https://api.slack.com/messaging/webhooks#getting_started[Slack Incoming Webhooks] for instructions on generating this URL. If you are using the <<action-settings, `xpack.actions.allowedHosts`>> setting, make sure the hostname is added to the allowed hosts.
1515

1616
[float]
1717
[[Preconfigured-slack-configuration]]

docs/user/alerting/action-types/webhook.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ The Webhook action type uses https://github.com/axios/axios[axios] to send a POS
1111
Webhook connectors have the following configuration properties:
1212

1313
Name:: The name of the connector. The name is used to identify a connector in the management UI connector listing, or in the connector list when configuring an action.
14-
URL:: The request URL. If you are using the <<action-settings, `xpack.actions.whitelistedHosts`>> setting, make sure the hostname is whitelisted.
14+
URL:: The request URL. If you are using the <<action-settings, `xpack.actions.allowedHosts`>> setting, make sure the hostname is added to the allowed hosts.
1515
Method:: HTTP request method, either `post`(default) or `put`.
1616
Headers:: A set of key-value pairs sent as headers with the request
1717
User:: An optional username. If set, HTTP basic authentication is used. Currently only basic authentication is supported.
-166 KB
Loading

examples/embeddable_examples/public/book/book_embeddable.tsx

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,7 @@ export class BookEmbeddable
7171

7272
constructor(
7373
initialInput: BookEmbeddableInput,
74-
private attributeService: AttributeService<
75-
BookSavedObjectAttributes,
76-
BookByValueInput,
77-
BookByReferenceInput
78-
>,
74+
private attributeService: AttributeService<BookSavedObjectAttributes>,
7975
{
8076
parent,
8177
}: {
@@ -99,18 +95,21 @@ export class BookEmbeddable
9995
});
10096
}
10197

102-
inputIsRefType = (input: BookEmbeddableInput): input is BookByReferenceInput => {
98+
readonly inputIsRefType = (input: BookEmbeddableInput): input is BookByReferenceInput => {
10399
return this.attributeService.inputIsRefType(input);
104100
};
105101

106-
getInputAsValueType = async (): Promise<BookByValueInput> => {
102+
readonly getInputAsValueType = async (): Promise<BookByValueInput> => {
107103
const input = this.attributeService.getExplicitInputFromEmbeddable(this);
108104
return this.attributeService.getInputAsValueType(input);
109105
};
110106

111-
getInputAsRefType = async (): Promise<BookByReferenceInput> => {
107+
readonly getInputAsRefType = async (): Promise<BookByReferenceInput> => {
112108
const input = this.attributeService.getExplicitInputFromEmbeddable(this);
113-
return this.attributeService.getInputAsRefType(input, { showSaveModal: true });
109+
return this.attributeService.getInputAsRefType(input, {
110+
showSaveModal: true,
111+
saveModalTitle: this.getTitle(),
112+
});
114113
};
115114

116115
public render(node: HTMLElement) {

examples/embeddable_examples/public/book/book_embeddable_factory.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ import {
3131
BOOK_EMBEDDABLE,
3232
BookEmbeddableInput,
3333
BookEmbeddableOutput,
34-
BookByValueInput,
35-
BookByReferenceInput,
3634
} from './book_embeddable';
3735
import { CreateEditBookComponent } from './create_edit_book_component';
3836
import { OverlayStart } from '../../../../src/core/public';
@@ -66,11 +64,7 @@ export class BookEmbeddableFactoryDefinition
6664
getIconForSavedObject: () => 'pencil',
6765
};
6866

69-
private attributeService?: AttributeService<
70-
BookSavedObjectAttributes,
71-
BookByValueInput,
72-
BookByReferenceInput
73-
>;
67+
private attributeService?: AttributeService<BookSavedObjectAttributes>;
7468

7569
constructor(private getStartServices: () => Promise<StartServices>) {}
7670

@@ -126,9 +120,7 @@ export class BookEmbeddableFactoryDefinition
126120
private async getAttributeService() {
127121
if (!this.attributeService) {
128122
this.attributeService = await (await this.getStartServices()).getAttributeService<
129-
BookSavedObjectAttributes,
130-
BookByValueInput,
131-
BookByReferenceInput
123+
BookSavedObjectAttributes
132124
>(this.type);
133125
}
134126
return this.attributeService!;

0 commit comments

Comments
 (0)