Skip to content

Commit cc60c17

Browse files
committed
Migrate vis_type_table to kibana/new platform (#63105)
* Move vis_type_table to Kibana Platform * Adapt mocha tests * Adapt CODEOWNERS * Adapt SCSS
1 parent 41ff32a commit cc60c17

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+353
-323
lines changed

.i18nrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"visDefaultEditor": "src/plugins/vis_default_editor",
4949
"visTypeMarkdown": "src/plugins/vis_type_markdown",
5050
"visTypeMetric": "src/plugins/vis_type_metric",
51-
"visTypeTable": "src/legacy/core_plugins/vis_type_table",
51+
"visTypeTable": "src/plugins/vis_type_table",
5252
"visTypeTagCloud": "src/legacy/core_plugins/vis_type_tagcloud",
5353
"visTypeTimeseries": ["src/legacy/core_plugins/vis_type_timeseries", "src/plugins/vis_type_timeseries"],
5454
"visTypeVega": "src/legacy/core_plugins/vis_type_vega",

src/legacy/core_plugins/vis_type_table/public/agg_table/__tests__/agg_table.js renamed to src/legacy/core_plugins/kibana/public/__tests__/vis_type_table/agg_table.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,27 @@ import moment from 'moment';
2222
import ngMock from 'ng_mock';
2323
import expect from '@kbn/expect';
2424
import sinon from 'sinon';
25-
import { npStart } from '../../legacy_imports';
25+
import './legacy';
26+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
27+
import { npStart } from 'ui/new_platform';
2628
import { round } from 'lodash';
27-
import { getAngularModule } from '../../get_inner_angular';
28-
import { initTableVisLegacyModule } from '../../table_vis_legacy_module';
29+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
30+
import { getInnerAngular } from '../../../../../../plugins/vis_type_table/public/get_inner_angular';
31+
32+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
33+
import { initTableVisLegacyModule } from '../../../../../../plugins/vis_type_table/public/table_vis_legacy_module';
2934
import { tabifiedData } from './tabified_data';
35+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
36+
import { configureAppAngularModule } from '../../../../../../plugins/kibana_legacy/public/angular';
3037

3138
describe('Table Vis - AggTable Directive', function() {
3239
let $rootScope;
3340
let $compile;
3441
let settings;
3542

3643
const initLocalAngular = () => {
37-
const tableVisModule = getAngularModule('kibana/table_vis', npStart.core);
44+
const tableVisModule = getInnerAngular('kibana/table_vis', npStart.core);
45+
configureAppAngularModule(tableVisModule, npStart.core, true);
3846
initTableVisLegacyModule(tableVisModule);
3947
};
4048

src/legacy/core_plugins/vis_type_table/public/agg_table/__tests__/agg_table_group.js renamed to src/legacy/core_plugins/kibana/public/__tests__/vis_type_table/agg_table_group.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,24 @@
2020
import $ from 'jquery';
2121
import ngMock from 'ng_mock';
2222
import expect from '@kbn/expect';
23-
import { npStart } from '../../legacy_imports';
24-
import { getAngularModule } from '../../get_inner_angular';
25-
import { initTableVisLegacyModule } from '../../table_vis_legacy_module';
23+
import './legacy';
24+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
25+
import { getInnerAngular } from '../../../../../../plugins/vis_type_table/public/get_inner_angular';
26+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
27+
import { initTableVisLegacyModule } from '../../../../../../plugins/vis_type_table/public/table_vis_legacy_module';
2628
import { tabifiedData } from './tabified_data';
29+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
30+
import { npStart } from 'ui/new_platform';
31+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
32+
import { configureAppAngularModule } from '../../../../../../plugins/kibana_legacy/public/angular';
2733

2834
describe('Table Vis - AggTableGroup Directive', function() {
2935
let $rootScope;
3036
let $compile;
3137

3238
const initLocalAngular = () => {
33-
const tableVisModule = getAngularModule('kibana/table_vis', npStart.core);
39+
const tableVisModule = getInnerAngular('kibana/table_vis', npStart.core);
40+
configureAppAngularModule(tableVisModule, npStart.core, true);
3441
initTableVisLegacyModule(tableVisModule);
3542
};
3643

src/legacy/core_plugins/vis_type_table/public/legacy.ts renamed to src/legacy/core_plugins/kibana/public/__tests__/vis_type_table/legacy.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,23 @@
1616
* specific language governing permissions and limitations
1717
* under the License.
1818
*/
19-
2019
import { PluginInitializerContext } from 'kibana/public';
21-
import { npSetup, npStart } from './legacy_imports';
22-
import { plugin } from '.';
23-
24-
import { TablePluginSetupDependencies } from './plugin';
20+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
21+
import { npStart, npSetup } from 'ui/new_platform';
22+
import {
23+
TableVisPlugin,
24+
TablePluginSetupDependencies,
25+
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
26+
} from '../../../../../../plugins/vis_type_table/public/plugin';
2527

2628
const plugins: Readonly<TablePluginSetupDependencies> = {
2729
expressions: npSetup.plugins.expressions,
2830
visualizations: npSetup.plugins.visualizations,
2931
};
3032

31-
const pluginInstance = plugin({} as PluginInitializerContext);
33+
const pluginInstance = new TableVisPlugin({} as PluginInitializerContext);
3234

3335
export const setup = pluginInstance.setup(npSetup.core, plugins);
34-
export const start = pluginInstance.start(npStart.core, { data: npStart.plugins.data });
36+
export const start = pluginInstance.start(npStart.core, {
37+
data: npStart.plugins.data,
38+
});

src/legacy/core_plugins/vis_type_table/index.ts

Lines changed: 0 additions & 44 deletions
This file was deleted.

src/legacy/core_plugins/vis_type_table/package.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/legacy/core_plugins/vis_type_table/public/agg_table/_index.scss

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/legacy/core_plugins/vis_type_table/public/paginated_table/_index.scss

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/legacy/core_plugins/vis_type_table/public/table_vis_type.ts

Lines changed: 0 additions & 98 deletions
This file was deleted.

0 commit comments

Comments
 (0)