[ML] Consolidate button icons.

walterra · walterra · commit c9fc1b2542b0 · 2020-08-18T12:11:45.000+02:00
diff --git a/x-pack/plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js b/x-pack/plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js
@@ -506,7 +506,7 @@ export class AnnotationsTable extends Component {
               <EuiButtonIcon
                 onClick={() => this.openSingleMetricView(annotation)}
                 disabled={!isDrillDownAvailable}
-                iconType="stats"
+                iconType="visLine"
                 aria-label={openInSingleMetricViewerAriaLabelText}
               />
             </EuiToolTip>
diff --git a/x-pack/plugins/ml/public/application/components/anomaly_results_view_selector/anomaly_results_view_selector.tsx b/x-pack/plugins/ml/public/application/components/anomaly_results_view_selector/anomaly_results_view_selector.tsx
@@ -36,7 +36,7 @@ export const AnomalyResultsViewSelector: FC<Props> = ({ viewId }) => {
         label: i18n.translate('xpack.ml.anomalyResultsViewSelector.anomalyExplorerLabel', {
           defaultMessage: 'View results in the Anomaly Explorer',
         }),
-        iconType: 'tableOfContents',
+        iconType: 'visTable',
         value: 'explorer',
         'data-test-subj': 'mlAnomalyResultsViewSelectorExplorer',
       },
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/view_results_panel/view_results_panel.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/view_results_panel/view_results_panel.tsx
@@ -28,7 +28,7 @@ export const ViewResultsPanel: FC<Props> = ({ jobId, analysisType }) => {
     <Fragment>
       <EuiCard
         className="dfAnalyticsCreationWizard__card"
-        icon={<EuiIcon size="xxl" type="tableDensityNormal" />}
+        icon={<EuiIcon size="xxl" type="visTable" />}
         title={i18n.translate('xpack.ml.dataframe.analytics.create.viewResultsCardTitle', {
           defaultMessage: 'View Results',
         })}
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_start/use_start_action.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_start/use_start_action.tsx
@@ -56,7 +56,9 @@ export const useStartAction = (canStartStopDataFrameAnalytics: boolean) => {
           canStartStopDataFrameAnalytics={canStartStopDataFrameAnalytics}
         />
       ),
-      available: (i: DataFrameAnalyticsListRow) => !isDataFrameAnalyticsRunning(i.stats.state),
+      available: (i: DataFrameAnalyticsListRow) =>
+        !isDataFrameAnalyticsRunning(item.stats.state) &&
+        !isDataFrameAnalyticsFailed(item.stats.state),
       enabled: startButtonEnabled,
       description: startActionNameText,
       icon: 'play',
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_stop/use_stop_action.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_stop/use_stop_action.tsx
@@ -51,7 +51,8 @@ export const useStopAction = (canStartStopDataFrameAnalytics: boolean) => {
   const action: DataFrameAnalyticsListAction = useMemo(
     () => ({
       name: () => <StopActionName isDisabled={!canStartStopDataFrameAnalytics} />,
-      available: (i: DataFrameAnalyticsListRow) => isDataFrameAnalyticsRunning(i.stats.state),
+      available: (i: DataFrameAnalyticsListRow) =>
+        isDataFrameAnalyticsRunning(i.stats.state) || isDataFrameAnalyticsFailed(i.stats.state),
       enabled: () => canStartStopDataFrameAnalytics,
       description: stopActionNameText,
       icon: 'stop',
diff --git a/x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container.js b/x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container.js
@@ -104,7 +104,7 @@ function ExplorerChartContainer({ series, severity, tooManyBuckets, wrapLabel })
             <EuiToolTip position="top" content={textViewButton}>
               <EuiButtonEmpty
                 iconSide="right"
-                iconType="stats"
+                iconType="visLine"
                 size="xs"
                 onClick={() => window.open(getExploreSeriesLink(series), '_blank')}
               >
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_actions/results.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_actions/results.js
@@ -51,7 +51,7 @@ export function ResultLinks({ jobs }) {
         <EuiToolTip position="bottom" content={openJobsInSingleMetricViewerText}>
           <EuiButtonIcon
             href={getLink('timeseriesexplorer', jobs)}
-            iconType="stats"
+            iconType="visLine"
             aria-label={openJobsInSingleMetricViewerText}
             className="results-button"
             isDisabled={singleMetricEnabled === false || jobActionsDisabled === true}
@@ -62,7 +62,7 @@ export function ResultLinks({ jobs }) {
       <EuiToolTip position="bottom" content={openJobsInAnomalyExplorerText}>
         <EuiButtonIcon
           href={getLink('explorer', jobs)}
-          iconType="tableOfContents"
+          iconType="visTable"
           aria-label={openJobsInAnomalyExplorerText}
           className="results-button"
           isDisabled={jobActionsDisabled === true}
diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/forecasts_table/forecasts_table.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/forecasts_table/forecasts_table.js
@@ -301,7 +301,7 @@ export class ForecastsTable extends Component {
             <EuiButtonIcon
               onClick={() => this.openSingleMetricView(forecast)}
               isDisabled={forecast.forecast_status !== FORECAST_REQUEST_STATE.FINISHED}
-              iconType="stats"
+              iconType="visLine"
               aria-label={viewForecastAriaLabel}
             />
           );
diff --git a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/actions.tsx b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/actions.tsx
@@ -40,7 +40,7 @@ export const ViewLink: FC<Props> = ({ item }) => {
         color="text"
         size="xs"
         onClick={clickHandler}
-        iconType="tableOfContents"
+        iconType="visTable"
         aria-label={openJobsInAnomalyExplorerText}
         className="results-button"
         data-test-subj="mlAnalyticsJobViewButton"
diff --git a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/actions.tsx b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/actions.tsx
@@ -30,13 +30,13 @@ export const ExplorerLink: FC<Props> = ({ jobsList }) => {
         color="text"
         size="xs"
         href={getLink('explorer', jobsList)}
-        iconType="tableOfContents"
+        iconType="visTable"
         aria-label={openJobsInAnomalyExplorerText}
         className="results-button"
         data-test-subj={`openOverviewJobsInAnomalyExplorer`}
       >
-        {i18n.translate('xpack.ml.overview.anomalyDetection.exploreActionName', {
-          defaultMessage: 'Explore',
+        {i18n.translate('xpack.ml.overview.anomalyDetection.viewActionName', {
+          defaultMessage: 'View',
         })}
       </EuiButtonEmpty>
     </EuiToolTip>
diff --git a/x-pack/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/forecasts_list.js b/x-pack/plugins/ml/public/application/timeseriesexplorer/components/forecasting_modal/forecasts_list.js
@@ -65,7 +65,7 @@ function getColumns(viewForecast) {
         return (
           <EuiButtonIcon
             onClick={() => viewForecast(forecast.forecast_id)}
-            iconType="stats"
+            iconType="visLine"
             aria-label={viewForecastAriaLabel}
           />
         );
diff --git a/x-pack/plugins/ml/public/ui_actions/open_in_anomaly_explorer_action.tsx b/x-pack/plugins/ml/public/ui_actions/open_in_anomaly_explorer_action.tsx
@@ -17,7 +17,7 @@ export function createOpenInExplorerAction(getStartServices: MlCoreSetup['getSta
     id: 'open-in-anomaly-explorer',
     type: OPEN_IN_ANOMALY_EXPLORER_ACTION,
     getIconType(context: ActionContextMapping[typeof OPEN_IN_ANOMALY_EXPLORER_ACTION]): string {
-      return 'tableOfContents';
+      return 'visTable';
     },
     getDisplayName() {
       return i18n.translate('xpack.ml.actions.openInAnomalyExplorerTitle', {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ function ExplorerChartContainer({ series, severity, tooManyBuckets, wrapLabel })`
`104`	`104`	`<EuiToolTip position="top" content={textViewButton}>`
`105`	`105`	`<EuiButtonEmpty`
`106`	`106`	`iconSide="right"`
`107`		`- iconType="stats"`
	`107`	`+ iconType="visLine"`
`108`	`108`	`size="xs"`
`109`	`109`	`onClick={() => window.open(getExploreSeriesLink(series), '_blank')}`
`110`	`110`	`>`