Fix graph migrations

Author: kertal

x-pack/plugins/graph/server/saved_objects/graph_workspace.ts

@@ -4,14 +4,13 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { SavedObjectsType } from 'kibana/server';
-// @ts-ignore
-import { migrations } from './migrations';
+import { graphMigrations } from './migrations';
 
 export const graphWorkspace: SavedObjectsType = {
   name: 'graph-workspace',
   namespaceType: 'single',
   hidden: false,
-  migrations,
+  migrations: graphMigrations,
   mappings: {
     properties: {
       description: {

x-pack/plugins/graph/server/saved_objects/migrations.js

@@ -4,14 +4,15 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import migrations from './migrations';
+import { graphMigrations } from './migrations';
+import { SavedObjectUnsanitizedDoc } from 'kibana/server';
 
 describe('graph-workspace', () => {
   describe('7.0.0', () => {
-    const migration = migrations['graph-workspace']['7.0.0'];
+    const migration = graphMigrations['7.0.0'];
 
     test('returns doc on empty object', () => {
-      expect(migration({})).toMatchInlineSnapshot(`
+      expect(migration({} as SavedObjectUnsanitizedDoc)).toMatchInlineSnapshot(`
 Object {
   "references": Array [],
 }
@@ -21,6 +22,7 @@ Object {
     test('returns doc when wsState is not a string', () => {
       const doc = {
         id: '1',
+        type: 'graph-workspace',
         attributes: {
           wsState: true,
         },
@@ -39,6 +41,7 @@ Object {
     test('returns doc when wsState is not valid JSON', () => {
       const doc = {
         id: '1',
+        type: 'graph-workspace',
         attributes: {
           wsState: '123abc',
         },
@@ -57,6 +60,7 @@ Object {
     test('returns doc when "indexPattern" is missing from wsState', () => {
       const doc = {
         id: '1',
+        type: 'graph-workspace',
         attributes: {
           wsState: JSON.stringify(JSON.stringify({ foo: true })),
         },
@@ -75,6 +79,7 @@ Object {
     test('extract "indexPattern" attribute from doc', () => {
       const doc = {
         id: '1',
+        type: 'graph-workspace',
         attributes: {
           wsState: JSON.stringify(JSON.stringify({ foo: true, indexPattern: 'pattern*' })),
           bar: true,

x-pack/plugins/graph/server/saved_objects/migrations.test.js renamed to x-pack/plugins/graph/server/saved_objects/migrations.test.ts

@@ -0,0 +1,40 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { get } from 'lodash';
+import { SavedObjectUnsanitizedDoc } from 'kibana/server';
+
+export const graphMigrations = {
+  '7.0.0': (doc: SavedObjectUnsanitizedDoc) => {
+    // Set new "references" attribute
+    doc.references = doc.references || [];
+    // Migrate index pattern
+    const wsState = get(doc, 'attributes.wsState');
+    if (typeof wsState !== 'string') {
+      return doc;
+    }
+    let state;
+    try {
+      state = JSON.parse(JSON.parse(wsState));
+    } catch (e) {
+      // Let it go, the data is invalid and we'll leave it as is
+      return doc;
+    }
+    const { indexPattern } = state;
+    if (!indexPattern) {
+      return doc;
+    }
+    state.indexPatternRefName = 'indexPattern_0';
+    delete state.indexPattern;
+    doc.attributes.wsState = JSON.stringify(JSON.stringify(state));
+    doc.references.push({
+      name: 'indexPattern_0',
+      type: 'index-pattern',
+      id: indexPattern,
+    });
+    return doc;
+  },
+};