Skip to content

Commit c6481cf

Browse files
ppisljarstreamich
andcommitted
Apply suggestions from code review
Co-authored-by: Vadim Dalecky <streamich@gmail.com>
1 parent 9c7190d commit c6481cf

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/plugins/data/common/search/search_source/search_source.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
*/
6060

6161
import { setWith } from '@elastic/safer-lodash-set';
62-
import { uniqueId, keyBy, pick, difference, omit, isFunction, isEqual } from 'lodash';
62+
import { uniqueId, keyBy, pick, difference, isFunction, isEqual } from 'lodash';
6363
import { map, switchMap, tap } from 'rxjs/operators';
6464
import { defer, from } from 'rxjs';
6565
import { isObject } from 'rxjs/internal-compatibility';
@@ -114,12 +114,12 @@ export class SearchSource {
114114
private readonly dependencies: SearchSourceDependencies;
115115

116116
constructor(fields: SearchSourceFields = {}, dependencies: SearchSourceDependencies) {
117-
this.fields = fields;
117+
const { parent, ...currentFields } = fields;
118+
this.fields = currentFields;
118119
this.dependencies = dependencies;
119120

120-
if (fields.parent) {
121-
this.setParent(new SearchSource(fields.parent, dependencies));
122-
delete this.fields.parent;
121+
if (parent) {
122+
this.setParent(new SearchSource(parent, dependencies));
123123
}
124124
}
125125

@@ -656,7 +656,7 @@ export class SearchSource {
656656
* serializes search source fields (which can later be passed to {@link ISearchStartSearchSource})
657657
*/
658658
public getSerializedFields(recurse = false) {
659-
const { filter: originalFilters, ...searchSourceFields } = omit(this.getFields(), ['size']);
659+
const { filter: originalFilters, size: omit, ...searchSourceFields } = this.getFields();
660660
let serializedSearchSourceFields: SearchSourceFields = {
661661
...searchSourceFields,
662662
index: (searchSourceFields.index ? searchSourceFields.index.id : undefined) as any,

0 commit comments

Comments
 (0)