[functional tests] add some missing awaits (#65566) (#65597)

Spencer · web-flow · commit c4ab55744ed4 · 2020-05-06T21:03:40.000-07:00
diff --git a/test/functional/apps/timelion/index.js b/test/functional/apps/timelion/index.js
@@ -28,7 +28,7 @@ export default function({ getService, loadTestFile }) {
 
     before(async function() {
       log.debug('Starting timelion before method');
-      browser.setWindowSize(1280, 800);
+      await browser.setWindowSize(1280, 800);
       await esArchiver.loadIfNeeded('logstash_functional');
       await kibanaServer.uiSettings.replace({ defaultIndex: 'logstash-*' });
     });
diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -33,7 +33,7 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
 
   class SettingsPage {
     async clickNavigation() {
-      find.clickDisplayedByCssSelector('.app-link:nth-child(5) a');
+      await find.clickDisplayedByCssSelector('.app-link:nth-child(5) a');
     }
 
     async clickLinkText(text: string) {
@@ -110,7 +110,7 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
     }
 
     async toggleAdvancedSettingCheckbox(propertyName: string) {
-      testSubjects.click(`advancedSetting-editField-${propertyName}`);
+      await testSubjects.click(`advancedSetting-editField-${propertyName}`);
       await PageObjects.header.waitUntilLoadingHasFinished();
       await testSubjects.click(`advancedSetting-saveButton`);
       await PageObjects.header.waitUntilLoadingHasFinished();
diff --git a/test/functional/services/find.ts b/test/functional/services/find.ts
@@ -476,7 +476,7 @@ export async function FindProvider({ getService }: FtrProviderContext) {
       value: string
     ): Promise<void> {
       log.debug(`Find.waitForAttributeToChange('${selector}', '${attribute}', '${value}')`);
-      retry.waitFor(`${attribute} to equal "${value}"`, async () => {
+      await retry.waitFor(`${attribute} to equal "${value}"`, async () => {
         const el = await this.byCssSelector(selector);
         return value === (await el.getAttribute(attribute));
       });
diff --git a/test/plugin_functional/test_suites/core_plugins/rendering.ts b/test/plugin_functional/test_suites/core_plugins/rendering.ts
@@ -40,8 +40,8 @@ export default function({ getService, getPageObjects }: PluginFunctionalProvider
   const find = getService('find');
   const testSubjects = getService('testSubjects');
 
-  const navigateTo = (path: string) =>
-    browser.navigateTo(`${PageObjects.common.getHostPort()}${path}`);
+  const navigateTo = async (path: string) =>
+    await browser.navigateTo(`${PageObjects.common.getHostPort()}${path}`);
   const navigateToApp = async (title: string) => {
     await appsMenu.clickLink(title);
     return browser.execute(() => {
diff --git a/x-pack/test/functional/apps/index_management/home_page.ts b/x-pack/test/functional/apps/index_management/home_page.ts
@@ -34,7 +34,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
     describe('Index templates', () => {
       it('renders the index templates tab', async () => {
         // Navigate to the index templates tab
-        pageObjects.indexManagement.changeTabs('templatesTab');
+        await pageObjects.indexManagement.changeTabs('templatesTab');
 
         await pageObjects.header.waitUntilLoadingHasFinished();
 
diff --git a/x-pack/test/functional/apps/lens/index.ts b/x-pack/test/functional/apps/lens/index.ts
@@ -15,7 +15,7 @@ export default function({ getService, loadTestFile }: FtrProviderContext) {
   describe('lens app', () => {
     before(async () => {
       log.debug('Starting lens before method');
-      browser.setWindowSize(1280, 800);
+      await browser.setWindowSize(1280, 800);
       await esArchiver.loadIfNeeded('logstash_functional');
       await esArchiver.loadIfNeeded('lens/basic');
     });
diff --git a/x-pack/test/functional/page_objects/index_management_page.ts b/x-pack/test/functional/page_objects/index_management_page.ts
@@ -57,7 +57,7 @@ export function IndexManagementPageProvider({ getService }: FtrProviderContext)
         });
     },
     async changeTabs(tab: 'indicesTab' | 'templatesTab') {
-      return await testSubjects.click(tab);
+      await testSubjects.click(tab);
     },
   };
 }
diff --git a/x-pack/test/functional/page_objects/lens_page.ts b/x-pack/test/functional/page_objects/lens_page.ts
@@ -150,7 +150,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
       }
 
       await testSubjects.click('confirmSaveSavedObjectButton');
-      retry.waitForWithTimeout('Save modal to disappear', 1000, () =>
+      await retry.waitForWithTimeout('Save modal to disappear', 1000, () =>
         testSubjects
           .missingOrFail('confirmSaveSavedObjectButton')
           .then(() => true)
diff --git a/x-pack/test/functional/page_objects/security_page.js b/x-pack/test/functional/page_objects/security_page.js
@@ -394,9 +394,9 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
                 });
             }
           }) //clicking save button
-          .then(function() {
+          .then(async () => {
             log.debug('click save button');
-            testSubjects.click('roleFormSaveButton');
+            await testSubjects.click('roleFormSaveButton');
           })
           .then(function() {
             return PageObjects.common.sleep(5000);
diff --git a/x-pack/test/functional/services/logs_ui/log_entry_categories.ts b/x-pack/test/functional/services/logs_ui/log_entry_categories.ts
@@ -13,7 +13,7 @@ export function LogEntryCategoriesPageProvider({ getPageObjects, getService }: F
 
   return {
     async navigateTo() {
-      pageObjects.infraLogs.navigateToTab('log-categories');
+      await pageObjects.infraLogs.navigateToTab('log-categories');
     },
 
     async getSetupScreen(): Promise<WebElementWrapper> {
diff --git a/x-pack/test/functional/services/logs_ui/log_entry_rate.ts b/x-pack/test/functional/services/logs_ui/log_entry_rate.ts
@@ -13,7 +13,7 @@ export function LogEntryRatePageProvider({ getPageObjects, getService }: FtrProv
 
   return {
     async navigateTo() {
-      pageObjects.infraLogs.navigateToTab('log-rate');
+      await pageObjects.infraLogs.navigateToTab('log-rate');
     },
 
     async getSetupScreen(): Promise<WebElementWrapper> {
diff --git a/x-pack/test/functional/services/logs_ui/log_stream.ts b/x-pack/test/functional/services/logs_ui/log_stream.ts
@@ -15,7 +15,7 @@ export function LogStreamPageProvider({ getPageObjects, getService }: FtrProvide
 
   return {
     async navigateTo(params?: TabsParams['stream']) {
-      pageObjects.infraLogs.navigateToTab('stream', params);
+      await pageObjects.infraLogs.navigateToTab('stream', params);
     },
 
     async getColumnHeaderLabels(): Promise<string[]> {
diff --git a/x-pack/test/functional/services/uptime/monitor.ts b/x-pack/test/functional/services/uptime/monitor.ts
@@ -38,8 +38,9 @@ export function UptimeMonitorProvider({ getService }: FtrProviderContext) {
     async checkForPingListTimestamps(timestamps: string[]): Promise<void> {
       return retry.tryForTime(10000, async () => {
         await Promise.all(
-          timestamps.map(timestamp =>
-            testSubjects.existOrFail(`xpack.uptime.pingList.ping-${timestamp}`)
+          timestamps.map(
+            async timestamp =>
+              await testSubjects.existOrFail(`xpack.uptime.pingList.ping-${timestamp}`)
           )
         );
       });
diff --git a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page.ts
@@ -29,7 +29,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
     describe('Connectors tab', () => {
       it('renders the connectors tab', async () => {
         // Navigate to the connectors tab
-        pageObjects.triggersActionsUI.changeTabs('connectorsTab');
+        await pageObjects.triggersActionsUI.changeTabs('connectorsTab');
 
         await pageObjects.header.waitUntilLoadingHasFinished();
 
@@ -45,7 +45,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
     describe('Alerts tab', () => {
       it('renders the alerts tab', async () => {
         // Navigate to the alerts tab
-        pageObjects.triggersActionsUI.changeTabs('alertsTab');
+        await pageObjects.triggersActionsUI.changeTabs('alertsTab');
 
         await pageObjects.header.waitUntilLoadingHasFinished();
 
diff --git a/x-pack/test/functional_with_es_ssl/page_objects/triggers_actions_ui_page.ts b/x-pack/test/functional_with_es_ssl/page_objects/triggers_actions_ui_page.ts
@@ -120,7 +120,7 @@ export function TriggersActionsPageProvider({ getService }: FtrProviderContext)
       await find.clickDisplayedByCssSelector(`[data-test-subj="alertsList"] [title="${name}"]`);
     },
     async changeTabs(tab: 'alertsTab' | 'connectorsTab') {
-      return await testSubjects.click(tab);
+      await testSubjects.click(tab);
     },
     async toggleSwitch(testSubject: string) {
       const switchBtn = await testSubjects.find(testSubject);

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider`
`33`	`33`
`34`	`34`	`class SettingsPage {`
`35`	`35`	`async clickNavigation() {`
`36`		`- find.clickDisplayedByCssSelector('.app-link:nth-child(5) a');`
	`36`	`+ await find.clickDisplayedByCssSelector('.app-link:nth-child(5) a');`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`async clickLinkText(text: string) {`
`@@ -110,7 +110,7 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`async toggleAdvancedSettingCheckbox(propertyName: string) {`
`113`		- testSubjects.click(`advancedSetting-editField-${propertyName}`);
	`113`	+ await testSubjects.click(`advancedSetting-editField-${propertyName}`);
`114`	`114`	`await PageObjects.header.waitUntilLoadingHasFinished();`
`115`	`115`	await testSubjects.click(`advancedSetting-saveButton`);
`116`	`116`	`await PageObjects.header.waitUntilLoadingHasFinished();`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export function IndexManagementPageProvider({ getService }: FtrProviderContext)`
`57`	`57`	`});`
`58`	`58`	`},`
`59`	`59`	`async changeTabs(tab: 'indicesTab' \| 'templatesTab') {`
`60`		`- return await testSubjects.click(tab);`
	`60`	`+ await testSubjects.click(tab);`
`61`	`61`	`},`
`62`	`62`	`};`
`63`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`await testSubjects.click('confirmSaveSavedObjectButton');`
`153`		`- retry.waitForWithTimeout('Save modal to disappear', 1000, () =>`
	`153`	`+ await retry.waitForWithTimeout('Save modal to disappear', 1000, () =>`
`154`	`154`	`testSubjects`
`155`	`155`	`.missingOrFail('confirmSaveSavedObjectButton')`
`156`	`156`	`.then(() => true)`