[FieldFormats] Remove SerializedFieldFormat copy from expressions plugin (#114245)

Author: Dosant

src/plugins/data/common/search/aggs/agg_config.ts

@@ -13,11 +13,8 @@ import type { SerializableRecord } from '@kbn/utility-types';
 import { Assign, Ensure } from '@kbn/utility-types';
 
 import { ISearchOptions, ISearchSource } from 'src/plugins/data/public';
-import {
-  ExpressionAstExpression,
-  ExpressionAstArgument,
-  SerializedFieldFormat,
-} from 'src/plugins/expressions/common';
+import { ExpressionAstExpression, ExpressionAstArgument } from 'src/plugins/expressions/common';
+import type { SerializedFieldFormat } from 'src/plugins/field_formats/common';
 
 import { IAggType } from './agg_type';
 import { writeParams } from './agg_params';

src/plugins/data/common/search/aggs/agg_type.ts

@@ -10,8 +10,9 @@ import { constant, noop, identity } from 'lodash';
 import { i18n } from '@kbn/i18n';
 
 import { ISearchSource } from 'src/plugins/data/public';
-import { DatatableColumnType, SerializedFieldFormat } from 'src/plugins/expressions/common';
+import { DatatableColumnType } from 'src/plugins/expressions/common';
 import type { RequestAdapter } from 'src/plugins/inspector/common';
+import type { SerializedFieldFormat } from 'src/plugins/field_formats/common';
 
 import { estypes } from '@elastic/elasticsearch';
 import { initParams } from './agg_params';

src/plugins/data/common/search/aggs/utils/get_aggs_formats.ts

@@ -9,12 +9,12 @@
 /* eslint-disable max-classes-per-file */
 import { i18n } from '@kbn/i18n';
 
-import { SerializedFieldFormat } from 'src/plugins/expressions/common/types';
 import {
   FieldFormat,
   FieldFormatInstanceType,
   FieldFormatsContentType,
   IFieldFormat,
+  SerializedFieldFormat,
 } from '../../../../../field_formats/common';
 import { DateRange } from '../../expressions';
 import { convertDateRangeToString } from '../buckets/lib/date_range';

src/plugins/data_views/common/data_views/data_view.ts

@@ -19,9 +19,12 @@ import { IIndexPattern, IFieldType } from '../../common';
 import { DataViewField, IIndexPatternFieldList, fieldList } from '../fields';
 import { formatHitProvider } from './format_hit';
 import { flattenHitWrapper } from './flatten_hit';
-import { FieldFormatsStartCommon, FieldFormat } from '../../../field_formats/common';
+import {
+  FieldFormatsStartCommon,
+  FieldFormat,
+  SerializedFieldFormat,
+} from '../../../field_formats/common';
 import { DataViewSpec, TypeMeta, SourceFilter, DataViewFieldMap } from '../types';
-import { SerializedFieldFormat } from '../../../expressions/common';
 
 interface DataViewDeps {
   spec?: DataViewSpec;

src/plugins/data_views/common/types.ts

@@ -13,9 +13,8 @@ import type { SavedObject } from 'src/core/server';
 import { KBN_FIELD_TYPES } from '@kbn/field-types';
 import { IFieldType } from './fields';
 import { RUNTIME_FIELD_TYPES } from './constants';
-import { SerializedFieldFormat } from '../../expressions/common';
 import { DataViewField } from './fields';
-import { FieldFormat } from '../../field_formats/common';
+import { FieldFormat, SerializedFieldFormat } from '../../field_formats/common';
 
 export type FieldFormatMap = Record<string, SerializedFieldFormat>;
 

src/plugins/discover/public/application/apps/main/components/chart/point_series.ts

@@ -9,7 +9,7 @@
 import { uniq } from 'lodash';
 import { Duration, Moment } from 'moment';
 import { Unit } from '@elastic/datemath';
-import { SerializedFieldFormat } from '../../../../../../../expressions/common';
+import type { SerializedFieldFormat } from '../../../../../../../field_formats/common';
 
 export interface Column {
   id: string;

src/plugins/expressions/common/expression_types/specs/datatable.ts

@@ -8,11 +8,11 @@
 
 import type { SerializableRecord } from '@kbn/utility-types';
 import { map, pick, zipObject } from 'lodash';
+import type { SerializedFieldFormat } from 'src/plugins/field_formats/common';
 
 import { ExpressionTypeDefinition, ExpressionValueBoxed } from '../types';
 import { PointSeries, PointSeriesColumn } from './pointseries';
 import { ExpressionValueRender } from './render';
-import { SerializedFieldFormat } from '../../types';
 
 const name = 'datatable';
 

src/plugins/expressions/common/types/common.ts

@@ -46,14 +46,3 @@ export type TypeString<T> = KnownTypeToString<
  * `date` is typed as a number or string, and represents a date
  */
 export type UnmappedTypeStrings = 'date' | 'filter';
-
-/**
- * JSON representation of a field formatter configuration.
- * Is used to carry information about how to format data in
- * a data table as part of the column definition.
- */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export interface SerializedFieldFormat<TParams = Record<string, any>> {
-  id?: string;
-  params?: TParams;
-}

src/plugins/expressions/common/types/index.ts

@@ -6,13 +6,7 @@
  * Side Public License, v 1.
  */
 
-export {
-  TypeToString,
-  KnownTypeToString,
-  TypeString,
-  UnmappedTypeStrings,
-  SerializedFieldFormat,
-} from './common';
+export { TypeToString, KnownTypeToString, TypeString, UnmappedTypeStrings } from './common';
 
 export * from './style';
 export * from './registry';

src/plugins/expressions/public/index.ts

@@ -97,7 +97,6 @@ export {
   PointSeriesRow,
   Range,
   SerializedDatatable,
-  SerializedFieldFormat,
   Style,
   TextAlignment,
   TextDecoration,