Skip to content

Commit c2f2730

Browse files
committed
address comments
1 parent f109ec8 commit c2f2730

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

test/functional/apps/saved_objects_management/edit_saved_object.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,24 +129,22 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
129129
await PageObjects.settings.navigateTo();
130130
await PageObjects.settings.clickKibanaSavedObjects();
131131

132-
let objects = await PageObjects.settings.getSavedObjectsInTable();
132+
const objects = await PageObjects.settings.getSavedObjectsInTable();
133133
expect(objects.includes('A Pie')).to.be(true);
134134

135135
await PageObjects.common.navigateToActualUrl('kibana', testVisualizationUrl);
136136

137137
await testSubjects.existOrFail('savedObjectEditSave');
138138

139-
expect(await getFieldValue('title')).to.eql('A Pie');
140-
141139
let referencesValue = await getAceEditorFieldValue('references');
142140

143141
await focusAndClickButton('savedObjectEditSave');
144142

145-
objects = await PageObjects.settings.getSavedObjectsInTable();
146-
expect(objects.includes('A Pie')).to.be(true);
143+
await PageObjects.settings.getSavedObjectsInTable();
147144

148145
await PageObjects.common.navigateToActualUrl('kibana', testVisualizationUrl);
149146

147+
// Parsing to avoid random keys ordering issues in raw string comparison
150148
expect(JSON.parse(await getAceEditorFieldValue('references'))).to.eql(
151149
JSON.parse(referencesValue)
152150
);
@@ -155,8 +153,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
155153

156154
await focusAndClickButton('savedObjectEditSave');
157155

158-
objects = await PageObjects.settings.getSavedObjectsInTable();
159-
expect(objects.includes('A Pie')).to.be(true);
156+
await PageObjects.settings.getSavedObjectsInTable();
160157

161158
await PageObjects.common.navigateToActualUrl('kibana', testVisualizationUrl);
162159

0 commit comments

Comments
 (0)