Addressing code review comments

David Roberts · David Roberts · commit c1af6e2ce0ee · 2020-09-09T13:39:38.000+01:00
diff --git a/x-pack/plugins/ml/common/types/file_datavisualizer.ts b/x-pack/plugins/ml/common/types/file_datavisualizer.ts
@@ -84,6 +84,9 @@ export interface Settings {
 }
 
 export interface Mappings {
+  _meta?: {
+    created_by: string;
+  };
   properties: {
     [key: string]: any;
   };
diff --git a/x-pack/plugins/ml/server/models/file_data_visualizer/import_data.ts b/x-pack/plugins/ml/server/models/file_data_visualizer/import_data.ts
@@ -89,7 +89,7 @@ export function importDataProvider({ asCurrentUser }: IScopedClusterClient) {
   }
 
   async function createIndex(index: string, settings: Settings, mappings: Mappings) {
-    const body: { mappings: Mappings } = {
+    const body: { mappings: Mappings; settings?: Settings } = {
       mappings: {
         _meta: {
           created_by: INDEX_META_DATA_CREATED_BY,

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ export function importDataProvider({ asCurrentUser }: IScopedClusterClient) {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`async function createIndex(index: string, settings: Settings, mappings: Mappings) {`
`92`		`- const body: { mappings: Mappings } = {`
	`92`	`+ const body: { mappings: Mappings; settings?: Settings } = {`
`93`	`93`	`mappings: {`
`94`	`94`	`_meta: {`
`95`	`95`	`created_by: INDEX_META_DATA_CREATED_BY,`