Skip to content

Commit be0a06c

Browse files
committed
Revert to old functionality on rule creation dropdown
For now, we don't want to filter our dropdown to just installed jobs; that's a broader product decision that we'll circle back to.
1 parent f7aa1fd commit be0a06c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

x-pack/plugins/security_solution/public/detections/components/rules/ml_job_select/index.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ import React from 'react';
88
import { shallow } from 'enzyme';
99

1010
import { MlJobSelect } from './index';
11-
import { useInstalledSecurityJobs } from '../../../../common/components/ml/hooks/use_installed_security_jobs';
11+
import { useSecurityJobs } from '../../../../common/components/ml_popover/hooks/use_security_jobs';
1212
import { useFormFieldMock } from '../../../../common/mock';
13-
jest.mock('../../../../common/components/ml/hooks/use_installed_security_jobs');
13+
jest.mock('../../../../common/components/ml_popover/hooks/use_security_jobs');
1414
jest.mock('../../../../common/lib/kibana');
1515

1616
describe('MlJobSelect', () => {
1717
beforeAll(() => {
18-
(useInstalledSecurityJobs as jest.Mock).mockReturnValue({ loading: false, jobs: [] });
18+
(useSecurityJobs as jest.Mock).mockReturnValue({ loading: false, jobs: [] });
1919
});
2020

2121
it('renders correctly', () => {

x-pack/plugins/security_solution/public/detections/components/rules/ml_job_select/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
import styled from 'styled-components';
2020
import { isJobStarted } from '../../../../../common/machine_learning/helpers';
2121
import { FieldHook, getFieldValidityAndErrorMessage } from '../../../../shared_imports';
22-
import { useInstalledSecurityJobs } from '../../../../common/components/ml/hooks/use_installed_security_jobs';
22+
import { useSecurityJobs } from '../../../../common/components/ml_popover/hooks/use_security_jobs';
2323
import { useKibana } from '../../../../common/lib/kibana';
2424
import {
2525
ML_JOB_SELECT_PLACEHOLDER_TEXT,
@@ -81,7 +81,7 @@ interface MlJobSelectProps {
8181
export const MlJobSelect: React.FC<MlJobSelectProps> = ({ describedByIds = [], field }) => {
8282
const jobId = field.value as string;
8383
const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
84-
const { loading, jobs } = useInstalledSecurityJobs();
84+
const { loading, jobs } = useSecurityJobs(false);
8585
const mlUrl = useKibana().services.application.getUrlForApp('ml');
8686
const handleJobChange = useCallback(
8787
(machineLearningJobId: string) => {

0 commit comments

Comments
 (0)