Skip to content

Commit b8e49e7

Browse files
[Core UI] Home Page Solution Cards Fix (#75670)
1 parent 80109c8 commit b8e49e7

File tree

11 files changed

+69
-34
lines changed

11 files changed

+69
-34
lines changed

src/plugins/home/public/application/components/__snapshots__/home.test.js.snap

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
/*
2+
* Licensed to Elasticsearch B.V. under one or more contributor
3+
* license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright
5+
* ownership. Elasticsearch B.V. licenses this file to you under
6+
* the Apache License, Version 2.0 (the "License"); you may
7+
* not use this file except in compliance with the License.
8+
* You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
.homDataAdd__content .euiIcon__fillSecondary {
21+
fill: $euiColorDarkestShade;
22+
}

src/plugins/home/public/application/components/_index.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
// homChart__legend-isLoading
77

88
@import 'home';
9+
@import 'add_data';
910
@import 'manage_data';
1011
@import 'sample_data_set_cards';
1112
@import 'solutions_section';

src/plugins/home/public/application/components/_solutions_section.scss

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,21 +38,29 @@
3838
}
3939

4040
.homSolutionPanel {
41-
align-items: stretch; // Necessary because element is a button
42-
display: flex !important;
43-
flex-direction: column;
44-
overflow: hidden;
41+
border-radius: $euiBorderRadius;
42+
color: inherit;
43+
flex: 1;
44+
transition: all $euiAnimSpeedFast $euiAnimSlightResistance;
45+
46+
&:hover,
47+
&:focus {
48+
@include euiSlightShadowHover;
49+
transform: translateY(-2px);
4550

46-
&:focus,
47-
&:hover {
4851
.euiTitle {
4952
text-decoration: underline;
5053
}
5154
}
5255

53-
&:focus {
54-
@include euiFocusRing('large');
55-
@include euiSlightShadowHover;
56+
&,
57+
.euiPanel {
58+
display: flex;
59+
flex-direction: column;
60+
}
61+
62+
.euiPanel {
63+
overflow: hidden;
5664
}
5765
}
5866

src/plugins/home/public/application/components/add_data/__snapshots__/add_data.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/home/public/application/components/add_data/add_data.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const mockFeatures = [
6767
category: 'admin',
6868
description: 'Add and manage your fleet of Elastic Agents and integrations.',
6969
homePageSection: 'add_data',
70-
icon: 'logstashInput',
70+
icon: 'indexManagementApp',
7171
id: 'ingestManager',
7272
order: 510,
7373
path: '/app/ingestManager',
@@ -77,7 +77,7 @@ const mockFeatures = [
7777
category: 'data',
7878
description: 'Import your own CSV, NDJSON, or log file',
7979
homePageSection: 'add_data',
80-
icon: 'importAction',
80+
icon: 'document',
8181
id: 'ml_file_data_visualizer',
8282
order: 520,
8383
path: '/app/ml#/filedatavisualizer',

src/plugins/home/public/application/components/home.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export class Home extends Component {
155155
<EuiFlexItem grow={false}>
156156
<EuiFlexGroup className="homHeader__actions">
157157
<EuiFlexItem className="homHeader__actionItem">
158-
<EuiButtonEmpty href="#/tutorial_directory" iconType="plusInCircle">
158+
<EuiButtonEmpty href="#/tutorial_directory" iconType="indexOpen">
159159
{i18n.translate('home.pageHeader.addDataButtonLabel', {
160160
defaultMessage: 'Add data',
161161
})}

src/plugins/home/public/application/components/solutions_section/__snapshots__/solution_panel.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/home/public/application/components/solutions_section/solution_panel.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,12 @@ export const SolutionPanel: FC<Props> = ({ addBasePath, solution }) => (
5858
} homSolutions__item`}
5959
grow={1}
6060
>
61-
<a href={addBasePath(solution.path)} onClick={createAppNavigationHandler(solution.path)}>
62-
<EuiPanel paddingSize="none" className={`homSolutionPanel homSolutionPanel--${solution.id}`}>
61+
<a
62+
className={`homSolutionPanel homSolutionPanel--${solution.id}`}
63+
href={addBasePath(solution.path)}
64+
onClick={createAppNavigationHandler(solution.path)}
65+
>
66+
<EuiPanel paddingSize="none">
6367
<EuiFlexGroup gutterSize="none">
6468
<EuiFlexItem grow={1} className={`homSolutionPanel__header`}>
6569
<SolutionTitle

x-pack/plugins/ingest_manager/public/plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export class IngestManagerPlugin
108108
description: i18n.translate('xpack.ingestManager.featureCatalogueDescription', {
109109
defaultMessage: 'Add and manage your fleet of Elastic Agents and integrations.',
110110
}),
111-
icon: 'logstashInput',
111+
icon: 'indexManagementApp',
112112
showOnHomePage: true,
113113
path: BASE_PATH,
114114
category: FeatureCatalogueCategory.DATA,

0 commit comments

Comments
 (0)