Skip to content

Commit b70535f

Browse files
committed
Allow chromeless applications to render via non-/app routes
1 parent b220404 commit b70535f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+2615
-649
lines changed
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [App](./kibana-plugin-public.app.md) &gt; [appBasePath](./kibana-plugin-public.app.appbasepath.md)
4+
5+
## App.appBasePath property
6+
7+
Override the application's base routing path from `/app/${id}`<!-- -->. Must be unique across registered applications.
8+
9+
<b>Signature:</b>
10+
11+
```typescript
12+
appBasePath?: string;
13+
```

docs/development/core/public/kibana-plugin-public.app.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export interface App extends AppBase
1616
1717
| Property | Type | Description |
1818
| --- | --- | --- |
19+
| [appBasePath](./kibana-plugin-public.app.appbasepath.md) | <code>string</code> | Override the application's base routing path from <code>/app/${id}</code>. Must be unique across registered applications. |
1920
| [chromeless](./kibana-plugin-public.app.chromeless.md) | <code>boolean</code> | Hide the UI chrome when the application is mounted. Defaults to <code>false</code>. Takes precedence over chrome service visibility settings. |
2021
| [mount](./kibana-plugin-public.app.mount.md) | <code>(context: AppMountContext, params: AppMountParameters) =&gt; AppUnmount &#124; Promise&lt;AppUnmount&gt;</code> | A mount function called when the user navigates to this app's route. |
2122

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@
327327
"@types/pngjs": "^3.3.2",
328328
"@types/podium": "^1.0.0",
329329
"@types/prop-types": "^15.5.3",
330+
"@types/pug": "^2.0.4",
330331
"@types/reach__router": "^1.2.6",
331332
"@types/react": "^16.8.0",
332333
"@types/react-dom": "^16.8.0",

src/core/public/application/application_service.mock.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,13 @@
2020
import { Subject } from 'rxjs';
2121

2222
import { capabilitiesServiceMock } from './capabilities/capabilities_service.mock';
23-
import { ApplicationService } from './application_service';
2423
import {
2524
ApplicationSetup,
2625
InternalApplicationStart,
2726
ApplicationStart,
2827
InternalApplicationSetup,
2928
} from './types';
30-
31-
type ApplicationServiceContract = PublicMethodsOf<ApplicationService>;
29+
import { ApplicationServiceContract } from './test_types';
3230

3331
const createSetupContractMock = (): jest.Mocked<ApplicationSetup> => ({
3432
register: jest.fn(),
@@ -69,7 +67,6 @@ export const applicationServiceMock = {
6967
create: createMock,
7068
createSetupContract: createSetupContractMock,
7169
createStartContract: createStartContractMock,
72-
7370
createInternalSetupContract: createInternalSetupContractMock,
7471
createInternalStartContract: createInternalStartContractMock,
7572
};

0 commit comments

Comments
 (0)