[ML] Add better error handling/transparency

Author: qn895

x-pack/plugins/ml/common/util/runtime_field_utils.ts

@@ -6,9 +6,11 @@
  */
 
 import { isPopulatedObject } from './object_utils';
-import { RUNTIME_FIELD_TYPES } from '../../../../../src/plugins/data/common/index_patterns';
+import {
+  RUNTIME_FIELD_TYPES,
+  RuntimeType,
+} from '../../../../../src/plugins/data/common/index_patterns';
 import type { RuntimeField, RuntimeMappings } from '../types/fields';
-import type { RuntimeType } from '../../../runtime_fields/target/types/public';
 
 export function isRuntimeField(arg: unknown): arg is RuntimeField {
   return (

x-pack/plugins/ml/public/application/datavisualizer/index_based/data_loader/data_loader.ts

@@ -19,6 +19,10 @@ import { DEFAULT_SAMPLER_SHARD_SIZE } from '../../../../../common/constants/fiel
 import { ml } from '../../../services/ml_api_service';
 import { FieldHistogramRequestConfig, FieldRequestConfig } from '../common';
 import { RuntimeMappings } from '../../../../../common/types/fields';
+import {
+  ToastNotificationService,
+  toastNotificationServiceProvider,
+} from '../../../services/toast_notification_service';
 
 // Maximum number of examples to obtain for text type fields.
 const MAX_EXAMPLES_DEFAULT: number = 10;
@@ -28,16 +32,16 @@ export class DataLoader {
   private _runtimeMappings: RuntimeMappings;
   private _indexPatternTitle: IndexPatternTitle = '';
   private _maxExamples: number = MAX_EXAMPLES_DEFAULT;
-  private _toastNotifications: CoreSetup['notifications']['toasts'];
+  private _toastNotificationsService: ToastNotificationService;
 
   constructor(
     indexPattern: IndexPattern,
     toastNotifications: CoreSetup['notifications']['toasts']
   ) {
     this._indexPattern = indexPattern;
-    this._runtimeMappings = this._indexPattern.getComputedFields().runtimeFields;
+    this._runtimeMappings = this._indexPattern.getComputedFields().runtimeFields as RuntimeMappings;
     this._indexPatternTitle = indexPattern.title;
-    this._toastNotifications = toastNotifications;
+    this._toastNotificationsService = toastNotificationServiceProvider(toastNotifications);
   }
 
   async loadOverallData(
@@ -121,7 +125,8 @@ export class DataLoader {
 
   displayError(err: any) {
     if (err.statusCode === 500) {
-      this._toastNotifications.addDanger(
+      this._toastNotificationsService.displayErrorToast(
+        err,
         i18n.translate('xpack.ml.datavisualizer.dataLoader.internalServerErrorMessage', {
           defaultMessage:
             'Error loading data in index {index}. {message}. ' +
@@ -133,7 +138,8 @@ export class DataLoader {
         })
       );
     } else {
-      this._toastNotifications.addDanger(
+      this._toastNotificationsService.displayErrorToast(
+        err,
         i18n.translate('xpack.ml.datavisualizer.page.errorLoadingDataMessage', {
           defaultMessage: 'Error loading data in index {index}. {message}',
           values: {

x-pack/plugins/ml/public/application/datavisualizer/index_based/page.tsx

@@ -38,10 +38,9 @@ import { FullTimeRangeSelector } from '../../components/full_time_range_selector
 import { mlTimefilterRefresh$ } from '../../services/timefilter_refresh_service';
 import { useMlContext } from '../../contexts/ml';
 import { kbnTypeToMLJobType } from '../../util/field_types_utils';
-import { useTimefilter } from '../../contexts/kibana';
+import { useNotifications, useTimefilter } from '../../contexts/kibana';
 import { timeBasedIndexCheck, getQueryFromSavedSearch } from '../../util/index_utils';
 import { getTimeBucketsFromCache } from '../../util/time_buckets';
-import { getToastNotifications } from '../../util/dependency_cache';
 import { usePageUrlState, useUrlState } from '../../util/url_state';
 import { ActionsPanel } from './components/actions_panel';
 import { SearchPanel } from './components/search_panel';
@@ -132,7 +131,8 @@ export const Page: FC = () => {
     autoRefreshSelector: true,
   });
 
-  const dataLoader = useMemo(() => new DataLoader(currentIndexPattern, getToastNotifications()), [
+  const { toasts } = useNotifications();
+  const dataLoader = useMemo(() => new DataLoader(currentIndexPattern, toasts), [
     currentIndexPattern,
   ]);
 

x-pack/plugins/ml/server/models/data_visualizer/data_visualizer.ts

@@ -630,7 +630,7 @@ export class DataVisualizer {
     // Combine runtime mappings from the index pattern as well as the datafeed
     const combinedRuntimeMappings: RuntimeMappings = {
       ...(isPopulatedObject(runtimeMappings) ? runtimeMappings : {}),
-      ...(datafeedConfig !== undefined && isPopulatedObject(datafeedConfig.runtime_mappings)
+      ...(isPopulatedObject(datafeedConfig) && isPopulatedObject(datafeedConfig.runtime_mappings)
         ? datafeedConfig.runtime_mappings
         : {}),
     };

x-pack/plugins/ml/server/routes/schemas/data_visualizer_schema.ts

@@ -20,7 +20,7 @@ const runtimeMappingsSchema = schema.maybe(
       unknowns: 'allow',
       validate: (v: object) => {
         if (Object.values(v).some((o) => !isRuntimeField(o))) {
-          return 'Your error message about invalid runtime definition';
+          return 'Invalid runtime field';
         }
       },
     }