Merge branch 'master' of github.com:elastic/kibana into implement/kbn-optimizer

Author: spalger

.eslintrc.js

@@ -355,13 +355,7 @@ module.exports = {
       settings: {
         // instructs import/no-extraneous-dependencies to treat certain modules
         // as core modules, even if they aren't listed in package.json
-        'import/core-modules': [
-          'plugins',
-          'legacy/ui',
-          'uiExports',
-          // TODO: Remove once https://github.com/benmosher/eslint-plugin-import/issues/1374 is fixed
-          'querystring',
-        ],
+        'import/core-modules': ['plugins', 'legacy/ui', 'uiExports'],
 
         'import/resolver': {
           '@kbn/eslint-import-resolver-kibana': {

NOTICE.txt

@@ -218,28 +218,3 @@ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
 NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
----
-This product includes code that was extracted from angular@1.3.
-Original license:
-The MIT License
-
-Copyright (c) 2010-2014 Google, Inc. http://angularjs.org
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
-

docs/limitations.asciidoc

@@ -1,22 +1,38 @@
+[chapter]
 [[limitations]]
 = Limitations
 
-[partintro]
---
-{kib} currently has the following limitations.
+Following are the known limitations in {kib}.
 
-* <<nested-objects>>
-* <<export-data>>
-* <<graph-limitations,Graph analytics>>
+[float]
+=== Exporting data
 
-These {stack} features also have limitations that affect {kib}:
+Exporting a data table or saved search from a dashboard or visualization report
+has known limitations. The PDF report only includes the data visible on the screen.
 
-* {ref}/watcher-limitations.html[Alerting]
-* {ml-docs}/ml-limitations.html[Machine learning]
-* {ref}/security-limitations.html[Security]
+[float]
+=== Nested objects
+
+Kibana cannot perform aggregations across fields that contain nested objects.
+It also cannot search on nested objects when Lucene Query Syntax is used in
+the query bar.
+
+[IMPORTANT]
+==============================================
+Using `include_in_parent` or `copy_to` as a workaround is not supported and may stop functioning in future releases.
+==============================================
 
---
+[float]
+=== Graph
 
-include::limitations/nested-objects.asciidoc[]
+Graph has limited support for multiple indices.
+Go to <<graph-limitations, Graph limitations>> for details.
 
-include::limitations/export-data.asciidoc[]
+[float]
+=== Other limitations
+
+These {stack} features have limitations that affect {kib}:
+
+* {ref}/watcher-limitations.html[Alerting]
+* {ml-docs}/ml-limitations.html[Machine learning]
+* {ref}/security-limitations.html[Security]

docs/limitations/export-data.asciidoc

@@ -225,7 +225,7 @@
     "prop-types": "15.6.0",
     "proxy-from-env": "1.0.0",
     "pug": "^2.0.4",
-    "querystring-browser": "1.0.4",
+    "query-string": "6.10.1",
     "raw-loader": "3.1.0",
     "react": "^16.12.0",
     "react-color": "^2.13.8",

docs/limitations/nested-objects.asciidoc

@@ -29,7 +29,6 @@ exports.getWebpackConfig = function(kibanaPath, projectRoot, config) {
     // Kibana defaults https://github.com/elastic/kibana/blob/6998f074542e8c7b32955db159d15661aca253d7/src/legacy/ui/ui_bundler_env.js#L30-L36
     ui: fromKibana('src/legacy/ui/public'),
     test_harness: fromKibana('src/test_harness/public'),
-    querystring: 'querystring-browser',
 
     // Dev defaults for test bundle https://github.com/elastic/kibana/blob/6998f074542e8c7b32955db159d15661aca253d7/src/core_plugins/tests_bundle/index.js#L73-L78
     ng_mock$: fromKibana('src/test_utils/public/ng_mock'),

package.json

@@ -199,7 +199,6 @@ export function getWebpackConfig(bundle: Bundle, worker: WorkerConfig) {
       extensions: ['.js', '.ts', '.tsx', '.json'],
       alias: {
         tinymath: require.resolve('tinymath/lib/tinymath.es5.js'),
-        querystring: require.resolve('querystring-browser'),
       },
     },
 

packages/kbn-eslint-import-resolver-kibana/lib/get_webpack_config.js

@@ -19,8 +19,7 @@
 import { Request } from 'hapi';
 import { merge } from 'lodash';
 import { Socket } from 'net';
-
-import querystring from 'querystring';
+import { stringify } from 'query-string';
 
 import { schema } from '@kbn/config-schema';
 
@@ -55,7 +54,8 @@ function createKibanaRequestMock({
   socket = new Socket(),
   routeTags,
 }: RequestFixtureOptions = {}) {
-  const queryString = querystring.stringify(query);
+  const queryString = stringify(query, { sort: false });
+
   return KibanaRequest.from(
     createRawRequestMock({
       headers,

packages/kbn-optimizer/src/worker/webpack.config.ts

@@ -16,8 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-
-import { ParsedUrlQuery } from 'querystring';
+import { ParsedQuery } from 'query-string';
 import { format as formatUrl, parse as parseUrl, UrlObject } from 'url';
 
 /**
@@ -33,7 +32,7 @@ export interface URLMeaningfulParts {
   protocol?: string | null;
   slashes?: boolean | null;
   port?: string | null;
-  query: ParsedUrlQuery;
+  query: ParsedQuery;
 }
 
 /**