Make the success:undefined check more explicit

brianseeders · brianseeders · commit af7b217482ba · 2020-04-16T17:15:17.000-04:00
diff --git a/packages/kbn-test/src/functional_test_runner/lib/suite_tracker.ts b/packages/kbn-test/src/functional_test_runner/lib/suite_tracker.ts
@@ -56,7 +56,7 @@ export class SuiteTracker {
 
   getTracked(suite: object): SuiteInProgress {
     if (!this.inProgressSuites.has(suite)) {
-      this.inProgressSuites.set(suite, {} as SuiteInProgress);
+      this.inProgressSuites.set(suite, { success: undefined } as SuiteInProgress);
     }
     return this.inProgressSuites.get(suite)!;
   }
@@ -97,7 +97,7 @@ export class SuiteTracker {
       tracked.endTime = new Date();
 
       // The suite ended without any children failing, so we can mark it as successful
-      if (!('success' in tracked)) {
+      if (typeof tracked.success === 'undefined') {
         tracked.success = true;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ export class SuiteTracker {`
`56`	`56`
`57`	`57`	`getTracked(suite: object): SuiteInProgress {`
`58`	`58`	`if (!this.inProgressSuites.has(suite)) {`
`59`		`- this.inProgressSuites.set(suite, {} as SuiteInProgress);`
	`59`	`+ this.inProgressSuites.set(suite, { success: undefined } as SuiteInProgress);`
`60`	`60`	`}`
`61`	`61`	`return this.inProgressSuites.get(suite)!;`
`62`	`62`	`}`
`@@ -97,7 +97,7 @@ export class SuiteTracker {`
`97`	`97`	`tracked.endTime = new Date();`
`98`	`98`
`99`	`99`	`// The suite ended without any children failing, so we can mark it as successful`
`100`		`- if (!('success' in tracked)) {`
	`100`	`+ if (typeof tracked.success === 'undefined') {`
`101`	`101`	`tracked.success = true;`
`102`	`102`	`}`
`103`	`103`