Skip to content

Commit aea10e6

Browse files
committed
add divider when action menu is displayed
1 parent cc5bcc7 commit aea10e6

File tree

2 files changed

+38
-28
lines changed

2 files changed

+38
-28
lines changed

x-pack/plugins/saved_objects_tagging/public/management/components/_action_bar.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
display: none;
33
}
44

5+
.tagMgt__actionBarDivider {
6+
height: $euiSize;
7+
border-right: $euiBorderThin;
8+
}
9+
510
.tagMgt__actionBar {
611
border-bottom: $euiBorderThin;
712
padding-bottom: $euiSizeS;

x-pack/plugins/saved_objects_tagging/public/management/components/action_bar.tsx

Lines changed: 33 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export const ActionBar: FC<ActionBarProps> = ({
7070

7171
return (
7272
<div className="tagMgt__actionBar">
73-
<EuiFlexGroup justifyContent="flexStart" alignItems="baseline" gutterSize="m">
73+
<EuiFlexGroup justifyContent="flexStart" alignItems="center" gutterSize="m">
7474
<EuiFlexItem grow={false}>
7575
<EuiText size="xs" color="subdued">
7676
<FormattedMessage
@@ -83,33 +83,38 @@ export const ActionBar: FC<ActionBarProps> = ({
8383
</EuiText>
8484
</EuiFlexItem>
8585
{selectedCount > 0 && (
86-
<EuiFlexItem grow={false}>
87-
<EuiPopover
88-
isOpen={isPopoverOpened}
89-
closePopover={closePopover}
90-
panelPaddingSize="none"
91-
button={
92-
<EuiText size="xs">
93-
<EuiLink onClick={togglePopover} data-test-subj="actionBar-contextMenuButton">
94-
<FormattedMessage
95-
id="xpack.savedObjectsTagging.management.actionBar.selectedTagsLabel"
96-
defaultMessage="{count, plural, one {1 selected tag} other {# selected tags}}"
97-
values={{
98-
count: selectedCount,
99-
}}
100-
/>
101-
<EuiIcon className="tagMgt__actionBarIcon" type="arrowDown" size="s" />
102-
</EuiLink>
103-
</EuiText>
104-
}
105-
>
106-
<EuiContextMenu
107-
initialPanelId={0}
108-
panels={contextMenuPanels}
109-
data-test-subj="actionBar-contextMenu"
110-
/>
111-
</EuiPopover>
112-
</EuiFlexItem>
86+
<>
87+
<EuiFlexItem grow={false}>
88+
<div className="tagMgt__actionBarDivider" />
89+
</EuiFlexItem>
90+
<EuiFlexItem grow={false}>
91+
<EuiPopover
92+
isOpen={isPopoverOpened}
93+
closePopover={closePopover}
94+
panelPaddingSize="none"
95+
button={
96+
<EuiText size="xs">
97+
<EuiLink onClick={togglePopover} data-test-subj="actionBar-contextMenuButton">
98+
<FormattedMessage
99+
id="xpack.savedObjectsTagging.management.actionBar.selectedTagsLabel"
100+
defaultMessage="{count, plural, one {1 selected tag} other {# selected tags}}"
101+
values={{
102+
count: selectedCount,
103+
}}
104+
/>
105+
<EuiIcon className="tagMgt__actionBarIcon" type="arrowDown" size="s" />
106+
</EuiLink>
107+
</EuiText>
108+
}
109+
>
110+
<EuiContextMenu
111+
initialPanelId={0}
112+
panels={contextMenuPanels}
113+
data-test-subj="actionBar-contextMenu"
114+
/>
115+
</EuiPopover>
116+
</EuiFlexItem>
117+
</>
113118
)}
114119
</EuiFlexGroup>
115120
</div>

0 commit comments

Comments
 (0)