[pre-req] Move .storybook to storybook; standardize files

Author: clintandrewhall

.eslintignore

@@ -33,7 +33,7 @@ target
 /x-pack/plugins/canvas/canvas_plugin
 /x-pack/plugins/canvas/canvas_plugin_src/lib/flot-charts
 /x-pack/plugins/canvas/shareable_runtime/build
-/x-pack/plugins/canvas/storybook
+/x-pack/plugins/canvas/storybook/build
 /x-pack/plugins/monitoring/public/lib/jquery_flot
 /x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/**
 /x-pack/legacy/plugins/infra/common/graphql/types.ts

.eslintrc.js

@@ -1222,6 +1222,12 @@ module.exports = {
         ],
       },
     },
+    {
+      files: ['x-pack/plugins/canvas/storybook/**'],
+      rules: {
+        'import/no-extraneous-dependencies': 0,
+      },
+    },
     {
       files: ['x-pack/plugins/canvas/canvas_plugin_src/**/*.js'],
       globals: { canvas: true, $: true },

src/dev/precommit_hook/casing_check_config.js

@@ -51,7 +51,7 @@ export const IGNORE_FILE_GLOBS = [
   '.ci/pipeline-library/**/*',
 
   // Files in this directory must match a pre-determined name in some cases.
-  'x-pack/plugins/canvas/.storybook/*',
+  'x-pack/plugins/canvas/storybook/*',
 
   // filename must match language code which requires capital letters
   '**/translations/*.json',

x-pack/plugins/canvas/.gitignore

@@ -57,4 +57,4 @@ canvas_plugin/*
 webpack_stats.json
 
 # Don't commit storybook builds
-storybook
+storybook/build

x-pack/plugins/canvas/canvas_plugin_src/renderers/advanced_filter/component/__examples__/advanced_filter.examples.tsx renamed to x-pack/plugins/canvas/canvas_plugin_src/renderers/advanced_filter/component/__examples__/advanced_filter.stories.tsx

@@ -5,7 +5,7 @@
  */
 
 import { action } from '@storybook/addon-actions';
-import { boolean, withKnobs } from '@storybook/addon-knobs';
+import { boolean } from '@storybook/addon-knobs';
 import { storiesOf } from '@storybook/react';
 import React from 'react';
 import { ColorPicker } from '../color_picker';
@@ -54,7 +54,6 @@ class Interactive extends React.Component<
 }
 
 storiesOf('components/Color/ColorPicker', module)
-  .addDecorator(withKnobs)
   .addParameters({
     info: {
       inline: true,