[SECURITY SOLUTION] bug styling (#80572) (#80716)

* remove beta

* fix i18n

* fix cypress tests

* forget to save

* x-pack test

Author: XavierM

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts

@@ -168,7 +168,7 @@ describe('Custom detection rules creation', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${newRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${newRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', newRule.severity);
@@ -328,7 +328,7 @@ describe('Custom detection rules deletion and edition', () => {
       fillAboutRule(editedRule);
       saveEditedRule();
 
-      cy.get(RULE_NAME_HEADER).should('have.text', `${editedRule.name} Beta`);
+      cy.get(RULE_NAME_HEADER).should('have.text', `${editedRule.name}`);
       cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', editedRule.description);
       cy.get(ABOUT_DETAILS).within(() => {
         getDetails(SEVERITY_DETAILS).should('have.text', editedRule.severity);

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_eql.spec.ts

@@ -131,7 +131,7 @@ describe.skip('Detection rules, EQL', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${eqlRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${eqlRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', eqlRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', eqlRule.severity);

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_ml.spec.ts

@@ -115,7 +115,7 @@ describe('Detection rules, machine learning', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${machineLearningRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${machineLearningRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', machineLearningRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', machineLearningRule.severity);

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_override.spec.ts

@@ -132,7 +132,7 @@ describe('Detection rules, override', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${newOverrideRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${newOverrideRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newOverrideRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', newOverrideRule.severity);

x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_threshold.spec.ts

@@ -129,7 +129,7 @@ describe('Detection rules, threshold', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${newThresholdRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${newThresholdRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newThresholdRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', newThresholdRule.severity);

x-pack/plugins/security_solution/cypress/integration/cases.spec.ts

@@ -60,7 +60,7 @@ describe('Cases', () => {
     createNewCaseWithTimeline(case1);
     backToCases();
 
-    cy.get(ALL_CASES_PAGE_TITLE).should('have.text', 'Cases Beta');
+    cy.get(ALL_CASES_PAGE_TITLE).should('have.text', 'Cases');
     cy.get(ALL_CASES_OPEN_CASES_STATS).should('have.text', 'Open cases1');
     cy.get(ALL_CASES_CLOSED_CASES_STATS).should('have.text', 'Closed cases0');
     cy.get(ALL_CASES_OPEN_CASES_COUNT).should('have.text', 'Open cases (1)');

x-pack/plugins/security_solution/public/cases/components/case_header_page/index.tsx

@@ -7,18 +7,9 @@
 import React from 'react';
 
 import { HeaderPage, HeaderPageProps } from '../../../common/components/header_page';
-import * as i18n from './translations';
 
 const CaseHeaderPageComponent: React.FC<HeaderPageProps> = (props) => (
   <HeaderPage hideSourcerer={true} {...props} />
 );
 
-CaseHeaderPageComponent.defaultProps = {
-  badgeOptions: {
-    beta: true,
-    text: i18n.PAGE_BADGE_LABEL,
-    tooltip: i18n.PAGE_BADGE_TOOLTIP,
-  },
-};
-
 export const CaseHeaderPage = React.memo(CaseHeaderPageComponent);

x-pack/plugins/security_solution/public/cases/components/case_header_page/translations.ts

@@ -56,7 +56,7 @@ export const initSourcererScope = {
   errorMessage: null,
   indexPattern: EMPTY_INDEX_PATTERN,
   indicesExist: true,
-  loading: true,
+  loading: false,
   selectedPatterns: [],
 };
 

x-pack/plugins/security_solution/public/common/store/sourcerer/model.ts

@@ -7,20 +7,11 @@
 import React from 'react';
 
 import { HeaderPage, HeaderPageProps } from '../../../common/components/header_page';
-import * as i18n from './translations';
 
 const DetectionEngineHeaderPageComponent: React.FC<HeaderPageProps> = (props) => (
   <HeaderPage hideSourcerer={true} {...props} />
 );
 
-DetectionEngineHeaderPageComponent.defaultProps = {
-  badgeOptions: {
-    beta: true,
-    text: i18n.PAGE_BADGE_LABEL,
-    tooltip: i18n.PAGE_BADGE_TOOLTIP,
-  },
-};
-
 export const DetectionEngineHeaderPage = React.memo(DetectionEngineHeaderPageComponent);
 
 DetectionEngineHeaderPage.displayName = 'DetectionEngineHeaderPage';