Skip to content

Commit a9cac46

Browse files
committed
[ML] fix action columns
1 parent 5307506 commit a9cac46

File tree

2 files changed

+9
-6
lines changed
  • x-pack/legacy/plugins/ml/public

2 files changed

+9
-6
lines changed

x-pack/legacy/plugins/ml/public/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,13 @@ function stringMatch(str: string | undefined, substr: string) {
6868
}
6969

7070
interface Props {
71-
allowCreate?: boolean;
71+
isManagementTable?: boolean;
7272
isMlEnabledInSpace?: boolean;
7373
blockRefresh?: boolean;
7474
createAnalyticsForm?: any;
7575
}
7676
export const DataFrameAnalyticsList: FC<Props> = ({
77-
allowCreate = true,
77+
isManagementTable = false,
7878
isMlEnabledInSpace = true,
7979
blockRefresh = false,
8080
createAnalyticsForm,
@@ -226,7 +226,7 @@ export const DataFrameAnalyticsList: FC<Props> = ({
226226
</h2>
227227
}
228228
actions={
229-
!allowCreate
229+
!isManagementTable
230230
? [
231231
<EuiButtonEmpty
232232
onClick={createAnalyticsForm.actions.openModal}
@@ -248,7 +248,7 @@ export const DataFrameAnalyticsList: FC<Props> = ({
248248
const columns = getColumns(
249249
expandedRowItemIds,
250250
setExpandedRowItemIds,
251-
allowCreate,
251+
isManagementTable,
252252
isMlEnabledInSpace
253253
);
254254

@@ -339,7 +339,7 @@ export const DataFrameAnalyticsList: FC<Props> = ({
339339
<EuiFlexItem grow={false}>
340340
<RefreshAnalyticsListButton />
341341
</EuiFlexItem>
342-
{allowCreate && (
342+
{!isManagementTable && (
343343
<EuiFlexItem grow={false}>
344344
<CreateAnalyticsButton {...createAnalyticsForm} />
345345
</EuiFlexItem>

x-pack/legacy/plugins/ml/public/management/jobs_list/components/jobs_list_page/jobs_list_page.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ function getTabs(isMlEnabledInSpace: boolean): Tab[] {
5555
content: (
5656
<Fragment>
5757
<EuiSpacer size="m" />
58-
<DataFrameAnalyticsList allowCreate={false} isMlEnabledInSpace={isMlEnabledInSpace} />
58+
<DataFrameAnalyticsList
59+
isManagementTable={true}
60+
isMlEnabledInSpace={isMlEnabledInSpace}
61+
/>
5962
</Fragment>
6063
),
6164
},

0 commit comments

Comments
 (0)