Skip to content

Commit a53c715

Browse files
committed
Redesigns home page
Adds auto scroll to advanced setting provided in the URL hash Registered plugins to feature catalogue to be displayed on home page Rearrange add data section Fix solution panel conditional rendering Removed extraneous import Remmoved environment update from observability plugin Registrered features to feature catalog for ingest manager, ml, and index lifecycle management Fixed import Added max width to Kibana solution card Fixed feature id Fixed enterprise search link Updated solutions logos Fixed beta label on ingest manager card Fixed logos Cleaned up CSS Change home route redirects user to advanced settings Conditionally renders default route advanced setting link Restored app search logo Hides graph description on home page on basic license Style home page header and other misc design tweaks (#72481) Fixed home page header links spacing Hide solutions wrapper when no solutions are available Design PR: layout tweaks, responsive styles (#72944) * layout tweaks, responsive styles * address feedback, improve bg color setup * use EUI var for header height Fixed merge conflict Fixed click handler for change home route button Updated app directory link Moved app directory link from ChangeHomeRoute component to home component Updated tests Added FeatureCatalogueRegistryStart type Home page refactor Fixed prop types Fixed nav links Removed images from solution card components card images as backgrounds, consolidate styles, BEM changes style token icons for dark mode fix page height Updated home page feature order values Added solutions registry to feature catalogue Renamed solutions_panel to solutions_section Updated copy Removed imports Chore: makes home plugin optional dependency Fixed merge conflict Added tests for new home components Reverted component rename [Core UI] Home Page Redesign Class & Style Tweaks (#74037) Co-authored-by: Catherine Liu <catherine.liu@elastic.co> Co-authored-by: Ryan Keairns <contactryank@gmail.com> Co-authored-by: Catherine Liu <catherineqliu@outlook.com> Fixed i18n errors Adde feature catalogue registry tests Rename components Switched solution descriptions to static strings Fixed registered features Fixed i18n errors Show/hide solutions based on available nav links Removed solution property from feature catalogue entry Revert text changes Updated security link Updated snapshots Fixed home plugin tests Added solutions section tests Removed mock Fixed tutorial directory a11y tests Fix ui capabilities catalogue test Turned solution title into link Added tests Fixed security solution tests Fixed ts errors Updated snapshots Revert vega snapshot changes Retrieves height of global nav when scrolling to a field in advanced settings Removed a tag from solution panel title Apply a11y feedback Updated snapshots Added proptypes Updated chrome ui header snapshots Fixed manage data tests
1 parent 245c0a3 commit a53c715

File tree

120 files changed

+3996
-2930
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+3996
-2930
lines changed

src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/core/public/chrome/ui/header/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export function Header({
125125
<>
126126
<LoadingIndicator loadingCount$={observables.loadingCount$} />
127127
<header className={className} data-test-subj="headerGlobalNav">
128-
<EuiHeader position="fixed">
128+
<EuiHeader position="fixed" id="headerGlobalNav">
129129
<EuiHeaderSection grow={false}>
130130
{navType === 'modern' ? (
131131
<EuiHeaderSectionItem border="right" className="header__toggleNavButtonSection">

src/core/public/overlays/banners/_banners_list.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
}
44

55
.kbnGlobalBannerList__item + .kbnGlobalBannerList__item {
6-
margin-top: $euiSize;
6+
margin-top: $euiSizeS;
77
}

src/core/utils/default_app_categories.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const DEFAULT_APP_CATEGORIES = Object.freeze({
4646
order: 3000,
4747
},
4848
security: {
49-
id: 'security',
49+
id: 'securitySolution',
5050
label: i18n.translate('core.ui.securityNavList.label', {
5151
defaultMessage: 'Security',
5252
}),

src/plugins/advanced_settings/kibana.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
"server": true,
55
"ui": true,
66
"requiredPlugins": ["management"],
7-
"requiredBundles": ["kibanaReact"]
7+
"optionalPlugins": ["home"],
8+
"requiredBundles": ["kibanaReact", "home"]
89
}

src/plugins/advanced_settings/public/management_app/advanced_settings.tsx

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,21 @@ export class AdvancedSettingsComponent extends Component<
114114
filteredSettings: this.mapSettings(Query.execute(query, this.settings)),
115115
});
116116
});
117+
118+
// scrolls to setting provided in the URL hash
119+
const { hash } = window.location;
120+
if (hash !== '') {
121+
setTimeout(() => {
122+
const id = hash.replace('#', '');
123+
const element = document.getElementById(id);
124+
const globalNavOffset = document.getElementById('headerGlobalNav')?.offsetHeight || 0;
125+
126+
if (element) {
127+
element.scrollIntoView();
128+
window.scrollBy(0, -globalNavOffset); // offsets scroll by height of the global nav
129+
}
130+
}, 0);
131+
}
117132
}
118133

119134
componentWillUnmount() {

0 commit comments

Comments
 (0)