Skip to content

Commit a53ae34

Browse files
afgomezAlejandro Fernández Gómez
authored andcommitted
Revert "POC: Integrate logs into APM"
This reverts commit 690130b.
1 parent fa1caf6 commit a53ae34

File tree

2 files changed

+3
-20
lines changed

2 files changed

+3
-20
lines changed

x-pack/plugins/apm/kibana.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"kibanaReact",
3434
"kibanaUtils",
3535
"observability",
36-
"home",
37-
"infra"
36+
"home"
3837
]
3938
}

x-pack/plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TransactionTabs.tsx

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { fromQuery, toQuery } from '../../../shared/Links/url_helpers';
1515
import { TransactionMetadata } from '../../../shared/MetadataTable/TransactionMetadata';
1616
import { WaterfallContainer } from './WaterfallContainer';
1717
import { IWaterfall } from './WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers';
18-
import { LogStream } from '../../../../../../infra/public';
1918

2019
const timelineTab = {
2120
key: 'timeline',
@@ -31,13 +30,6 @@ const metadataTab = {
3130
}),
3231
};
3332

34-
const logsTab = {
35-
key: 'logs',
36-
label: i18n.translate('xpack.apm.propertiesTable.tabs.logsLabel', {
37-
defaultMessage: 'Logs',
38-
}),
39-
};
40-
4133
interface Props {
4234
location: Location;
4335
transaction: Transaction;
@@ -54,9 +46,9 @@ export function TransactionTabs({
5446
exceedsMax,
5547
}: Props) {
5648
const history = useHistory();
57-
const tabs = [timelineTab, metadataTab, logsTab];
49+
const tabs = [timelineTab, metadataTab];
5850
const currentTab =
59-
tabs.find((tab) => tab.key === urlParams.detailTab) ?? timelineTab;
51+
urlParams.detailTab === metadataTab.key ? metadataTab : timelineTab;
6052

6153
return (
6254
<React.Fragment>
@@ -91,14 +83,6 @@ export function TransactionTabs({
9183
waterfall={waterfall}
9284
exceedsMax={exceedsMax}
9385
/>
94-
) : currentTab.key === logsTab.key ? (
95-
<div>
96-
<LogStream
97-
startTimestamp={Date.now() - 86400000}
98-
endTimestamp={Date.now()}
99-
query={`trace.id: "${urlParams.traceId}" OR "${urlParams.traceId}"`}
100-
/>
101-
</div>
10286
) : (
10387
<TransactionMetadata transaction={transaction} />
10488
)}

0 commit comments

Comments
 (0)