Skip to content

Commit a303775

Browse files
committed
Fixed failing tests
1 parent b749d81 commit a303775

File tree

8 files changed

+4
-40
lines changed

8 files changed

+4
-40
lines changed

x-pack/legacy/plugins/siem/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export const siem = (kibana: any) => {
4040
id: APP_ID,
4141
configPrefix: 'xpack.siem',
4242
publicDir: resolve(__dirname, 'public'),
43-
require: ['kibana', 'elasticsearch', 'alerting', 'actions', 'triggers_actions_ui'],
43+
require: ['kibana', 'elasticsearch', 'alerting', 'actions'],
4444
uiExports: {
4545
app: {
4646
description: i18n.translate('xpack.siem.securityDescription', {

x-pack/legacy/plugins/siem/public/legacy.ts

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,33 +6,10 @@
66

77
import { npSetup, npStart } from 'ui/new_platform';
88

9-
import {
10-
TriggersAndActionsUIPublicPluginSetup,
11-
TriggersAndActionsUIPublicPluginStart,
12-
} from '../../../../plugins/triggers_actions_ui/public';
139
import { PluginInitializerContext } from '../../../../../src/core/public';
1410
import { plugin } from './';
1511

1612
const pluginInstance = plugin({} as PluginInitializerContext);
1713

18-
type PluginsSetupExtended = typeof npSetup.plugins & {
19-
// adds plugins which aren't in the PluginsSetup interface, but do exist
20-
triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
21-
};
22-
23-
type PluginsStartExtended = typeof npStart.plugins & {
24-
// adds plugins which aren't in the PluginsSetup interface, but do exist
25-
triggers_actions_ui: TriggersAndActionsUIPublicPluginStart;
26-
};
27-
28-
const setupDependencies = npSetup.plugins as PluginsSetupExtended;
29-
const startDependencies = npStart.plugins as PluginsStartExtended;
30-
31-
pluginInstance.setup(npSetup.core, {
32-
...npSetup.plugins,
33-
triggers_actions_ui: setupDependencies.triggers_actions_ui,
34-
});
35-
pluginInstance.start(npStart.core, {
36-
...npStart.plugins,
37-
triggers_actions_ui: startDependencies.triggers_actions_ui,
38-
});
14+
pluginInstance.setup(npSetup.core, npSetup.plugins);
15+
pluginInstance.start(npStart.core, npStart.plugins);

x-pack/legacy/plugins/siem/public/pages/overview/overview_empty/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
import React from 'react';
8+
89
import * as i18nCommon from '../../common/translations';
910
import { EmptyPage } from '../../../components/empty_page';
1011
import { useKibana } from '../../../lib/kibana';

x-pack/legacy/plugins/siem/public/plugin.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ import { Start as NewsfeedStart } from '../../../../../src/plugins/newsfeed/publ
1818
import { Start as InspectorStart } from '../../../../../src/plugins/inspector/public';
1919
import { UiActionsStart } from '../../../../../src/plugins/ui_actions/public';
2020
import { UsageCollectionSetup } from '../../../../../src/plugins/usage_collection/public';
21-
import {
22-
TriggersAndActionsUIPublicPluginSetup,
23-
TriggersAndActionsUIPublicPluginStart,
24-
} from '../../../../plugins/triggers_actions_ui/public';
2521
import { initTelemetry } from './lib/telemetry';
2622
import { KibanaServices } from './lib/kibana';
2723

@@ -30,15 +26,13 @@ export { AppMountParameters, CoreSetup, CoreStart, PluginInitializerContext };
3026
export interface SetupPlugins {
3127
home: HomePublicPluginSetup;
3228
usageCollection: UsageCollectionSetup;
33-
triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
3429
}
3530
export interface StartPlugins {
3631
data: DataPublicPluginStart;
3732
embeddable: IEmbeddableStart;
3833
inspector: InspectorStart;
3934
newsfeed?: NewsfeedStart;
4035
uiActions: UiActionsStart;
41-
triggers_actions_ui: TriggersAndActionsUIPublicPluginStart;
4236
}
4337
export type StartServices = CoreStart & StartPlugins;
4438

x-pack/test/detection_engine_api_integration/common/config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions)
7575
`--xpack.actions.enabledActionTypes=${JSON.stringify(enabledActionTypes)}`,
7676
'--xpack.alerting.enabled=true',
7777
'--xpack.eventLog.logEntries=true',
78-
'--xpack.triggers_actions_ui.enabled=true',
79-
'--xpack.triggers_actions_ui.createAlertUiEnabled=true',
8078
...disabledPlugins.map(key => `--xpack.${key}.enabled=false`),
8179
`--plugin-path=${path.join(__dirname, 'fixtures', 'plugins', 'alerts')}`,
8280
`--plugin-path=${path.join(__dirname, 'fixtures', 'plugins', 'actions')}`,

x-pack/test/functional/config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ export default async function({ readConfigFile }) {
8888
'--telemetry.banner=false',
8989
'--timelion.ui.enabled=true',
9090
'--xpack.endpoint.enabled=true',
91-
'--xpack.triggers_actions_ui.enabled=true',
92-
'--xpack.triggers_actions_ui.createAlertUiEnabled=true',
9391
],
9492
},
9593
uiSettings: {

x-pack/test/licensing_plugin/config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ export default async function({ readConfigFile }: FtrConfigProviderContext) {
4444
serverArgs: [
4545
...functionalTestsConfig.get('kbnTestServer.serverArgs'),
4646
'--xpack.licensing.api_polling_frequency=100',
47-
'--xpack.triggers_actions_ui.enabled=true',
48-
'--xpack.triggers_actions_ui.createAlertUiEnabled=true',
4947
],
5048
},
5149

x-pack/test/plugin_api_integration/config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ export default async function({ readConfigFile }) {
3737
...integrationConfig.get('kbnTestServer'),
3838
serverArgs: [
3939
...integrationConfig.get('kbnTestServer.serverArgs'),
40-
'--xpack.triggers_actions_ui.enabled=true',
41-
'--xpack.triggers_actions_ui.createAlertUiEnabled=true',
4240
...plugins.map(
4341
pluginDir => `--plugin-path=${path.resolve(__dirname, 'plugins', pluginDir)}`
4442
),

0 commit comments

Comments
 (0)