Skip to content

Commit 9376d54

Browse files
committed
Removed loading state for endpoint
1 parent adba239 commit 9376d54

File tree

2 files changed

+30
-39
lines changed

2 files changed

+30
-39
lines changed

x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('Credentials', () => {
5252
setMockValues({ dataLoading: true });
5353
const wrapper = shallow(<Credentials />);
5454
expect(wrapper.find('[data-test-subj="CreateAPIKeyButton"]')).toHaveLength(0);
55-
expect(wrapper.find(EuiLoadingContent)).toHaveLength(2);
55+
expect(wrapper.find(EuiLoadingContent)).toHaveLength(1);
5656
});
5757

5858
it('renders the API endpoint and a button to copy it', () => {

x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials.tsx

Lines changed: 29 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -64,44 +64,35 @@ export const Credentials: React.FC = () => {
6464
</EuiPageHeader>
6565
<EuiPageContentBody>
6666
<EuiPanel className="eui-textCenter">
67-
{!!dataLoading ? (
68-
<EuiLoadingContent lines={3} />
69-
) : (
70-
<>
71-
<EuiTitle size="s">
72-
<h2>
73-
{i18n.translate('xpack.enterpriseSearch.appSearch.credentials.apiEndpoint', {
74-
defaultMessage: 'Endpoint',
75-
})}
76-
</h2>
77-
</EuiTitle>
78-
<EuiCopy
79-
textToCopy={externalUrl.enterpriseSearchUrl}
80-
afterMessage={i18n.translate(
81-
'xpack.enterpriseSearch.appSearch.credentials.copied',
82-
{
83-
defaultMessage: 'Copied',
84-
}
85-
)}
86-
>
87-
{(copy) => (
88-
<>
89-
<EuiButtonIcon
90-
onClick={copy}
91-
iconType="copyClipboard"
92-
aria-label={i18n.translate(
93-
'xpack.enterpriseSearch.appSearch.credentials.copyApiEndpoint',
94-
{
95-
defaultMessage: 'Copy API Endpoint to clipboard.',
96-
}
97-
)}
98-
/>
99-
{externalUrl.enterpriseSearchUrl}
100-
</>
101-
)}
102-
</EuiCopy>
103-
</>
104-
)}
67+
<EuiTitle size="s">
68+
<h2>
69+
{i18n.translate('xpack.enterpriseSearch.appSearch.credentials.apiEndpoint', {
70+
defaultMessage: 'Endpoint',
71+
})}
72+
</h2>
73+
</EuiTitle>
74+
<EuiCopy
75+
textToCopy={externalUrl.enterpriseSearchUrl}
76+
afterMessage={i18n.translate('xpack.enterpriseSearch.appSearch.credentials.copied', {
77+
defaultMessage: 'Copied',
78+
})}
79+
>
80+
{(copy) => (
81+
<>
82+
<EuiButtonIcon
83+
onClick={copy}
84+
iconType="copyClipboard"
85+
aria-label={i18n.translate(
86+
'xpack.enterpriseSearch.appSearch.credentials.copyApiEndpoint',
87+
{
88+
defaultMessage: 'Copy API Endpoint to clipboard.',
89+
}
90+
)}
91+
/>
92+
{externalUrl.enterpriseSearchUrl}
93+
</>
94+
)}
95+
</EuiCopy>
10596
</EuiPanel>
10697
<EuiSpacer size="xxl" />
10798
<EuiPageContentHeader responsive={false}>

0 commit comments

Comments
 (0)