Skip to content

Commit 90c6b05

Browse files
committed
Merge remote-tracking branch 'upstream/master' into config_tsvb
# Conflicts: # src/legacy/core_plugins/vis_type_timeseries/index.ts # x-pack/legacy/plugins/rollup/server/plugin.ts
2 parents 0561f2a + 99332b8 commit 90c6b05

File tree

2,453 files changed

+65606
-57631
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,453 files changed

+65606
-57631
lines changed

.eslintrc.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ module.exports = {
109109
},
110110
},
111111
{
112-
files: ['x-pack/legacy/plugins/lens/**/*.{js,ts,tsx}'],
112+
files: ['x-pack/plugins/lens/**/*.{js,ts,tsx}'],
113113
rules: {
114114
'react-hooks/exhaustive-deps': 'off',
115115
'react-hooks/rules-of-hooks': 'off',
@@ -728,7 +728,7 @@ module.exports = {
728728
* Lens overrides
729729
*/
730730
{
731-
files: ['x-pack/legacy/plugins/lens/**/*.{ts,tsx}', 'x-pack/plugins/lens/**/*.{ts,tsx}'],
731+
files: ['x-pack/plugins/lens/**/*.{ts,tsx}'],
732732
rules: {
733733
'@typescript-eslint/no-explicit-any': 'error',
734734
},

.github/CODEOWNERS

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33
# For more info, see https://help.github.com/articles/about-codeowners/
44

55
# App
6-
/x-pack/legacy/plugins/lens/ @elastic/kibana-app
7-
/x-pack/legacy/plugins/graph/ @elastic/kibana-app
6+
/x-pack/plugins/lens/ @elastic/kibana-app
7+
/x-pack/plugins/graph/ @elastic/kibana-app
88
/src/legacy/server/url_shortening/ @elastic/kibana-app
99
/src/legacy/server/sample_data/ @elastic/kibana-app
1010
/src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-app
1111
/src/legacy/core_plugins/kibana/public/discover/ @elastic/kibana-app
1212
/src/legacy/core_plugins/kibana/public/visualize/ @elastic/kibana-app
1313
/src/legacy/core_plugins/kibana/public/local_application_service/ @elastic/kibana-app
1414
/src/legacy/core_plugins/kibana/public/dev_tools/ @elastic/kibana-app
15-
/src/legacy/core_plugins/metrics/ @elastic/kibana-app
1615
/src/legacy/core_plugins/vis_type_vislib/ @elastic/kibana-app
17-
/src/legacy/core_plugins/vis_type_xy/ @elastic/kibana-app
16+
/src/plugins/vis_type_xy/ @elastic/kibana-app
1817
/src/plugins/kibana_legacy/ @elastic/kibana-app
1918
/src/plugins/timelion/ @elastic/kibana-app
2019
/src/plugins/dashboard/ @elastic/kibana-app
2120
/src/plugins/discover/ @elastic/kibana-app
21+
/src/plugins/vis_type_timeseries/ @elastic/kibana-app
2222

2323
# Core UI
2424
# Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon
@@ -95,6 +95,7 @@
9595

9696
# Maps
9797
/x-pack/legacy/plugins/maps/ @elastic/kibana-gis
98+
/x-pack/plugins/maps/ @elastic/kibana-gis
9899
/x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis
99100
/x-pack/test/functional/apps/maps/ @elastic/kibana-gis
100101
/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
@@ -180,7 +181,7 @@
180181
/src/plugins/console/ @elastic/es-ui
181182
/src/plugins/es_ui_shared/ @elastic/es-ui
182183
/x-pack/legacy/plugins/cross_cluster_replication/ @elastic/es-ui
183-
/x-pack/legacy/plugins/index_lifecycle_management/ @elastic/es-ui
184+
/x-pack/plugins/index_lifecycle_management/ @elastic/es-ui
184185
/x-pack/legacy/plugins/index_management/ @elastic/es-ui
185186
/x-pack/legacy/plugins/license_management/ @elastic/es-ui
186187
/x-pack/legacy/plugins/rollup/ @elastic/es-ui
@@ -202,7 +203,8 @@
202203
# Endpoint
203204
/x-pack/plugins/endpoint/ @elastic/endpoint-app-team
204205
/x-pack/test/api_integration/apis/endpoint/ @elastic/endpoint-app-team
205-
/x-pack/test/functional/apps/endpoint/ @elastic/endpoint-app-team
206+
/x-pack/test/functional_endpoint/ @elastic/endpoint-app-team
207+
/x-pack/test/functional_endpoint_ingest_failure/ @elastic/endpoint-app-team
206208
/x-pack/test/functional/es_archives/endpoint/ @elastic/endpoint-app-team
207209

208210
# SIEM

.i18nrc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"src/legacy/core_plugins/management",
2525
"src/plugins/management"
2626
],
27+
"maps_legacy": "src/plugins/maps_legacy",
2728
"indexPatternManagement": "src/plugins/index_pattern_management",
2829
"advancedSettings": "src/plugins/advanced_settings",
2930
"kibana_legacy": "src/plugins/kibana_legacy",

.sass-lint.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@ files:
88
- 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
99
- 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
1010
- 'x-pack/plugins/triggers_actions_ui/**/*.s+(a|c)ss'
11+
- 'x-pack/plugins/lens/**/*.s+(a|c)ss'
12+
- 'x-pack/legacy/plugins/maps/**/*.s+(a|c)ss'
13+
- 'x-pack/plugins/maps/**/*.s+(a|c)ss'
1114
ignore:
1215
- 'x-pack/legacy/plugins/canvas/shareable_runtime/**/*.s+(a|c)ss'
13-
- 'x-pack/legacy/plugins/lens/**/*.s+(a|c)ss'
14-
- 'x-pack/legacy/plugins/maps/**/*.s+(a|c)ss'
1516
rules:
1617
quotes:
1718
- 2

docs/api/saved-objects/bulk_create.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ The API returns the following:
104104
"type": "dashboard",
105105
"error": {
106106
"statusCode": 409,
107-
"message": "version conflict, document already exists"
107+
"message": "Saved object [dashboard/be3733a0-9efe-11e7-acb3-3dab96693fab] conflict"
108108
}
109109
}
110110
]

docs/apm/advanced-queries.asciidoc

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
1+
[role="xpack"]
12
[[advanced-queries]]
2-
=== Advanced queries
3+
=== Query your data
34

4-
When querying in the APM app, you're simply searching and selecting data from fields in Elasticsearch documents.
5-
Queries entered into the query bar are also added as parameters to the URL,
6-
so it's easy to share a specific query or view with others.
7-
8-
You can begin to see some of the transaction fields available for filtering:
9-
10-
[role="screenshot"]
11-
image::apm/images/apm-query-bar.png[Example of the Kibana Query bar in APM app in Kibana]
5+
Querying your APM data is a powerful tool that can make finding bottlenecks in your code even easier.
6+
Imagine you have a user that complains about a slow response time in a specific service.
7+
With the query bar, you can easily filter the APM app to only display trace data for that user,
8+
or, to only show transactions that are slower than a specified time threshold.
129

1310
[float]
1411
==== Example APM app queries
@@ -17,23 +14,32 @@ image::apm/images/apm-query-bar.png[Example of the Kibana Query bar in APM app i
1714
* Filter by response status code: `context.response.status_code >= 400`
1815
* Filter by single user ID: `context.user.id : 12`
1916

17+
When querying in the APM app, you're merely searching and selecting data from fields in Elasticsearch documents.
18+
Queries entered into the query bar are also added as parameters to the URL,
19+
so it's easy to share a specific query or view with others.
20+
21+
When you type, you can begin to see some of the transaction fields available for filtering:
22+
23+
[role="screenshot"]
24+
image::apm/images/apm-query-bar.png[Example of the Kibana Query bar in APM app in Kibana]
25+
2026
TIP: Read the {kibana-ref}/kuery-query.html[Kibana Query Language Enhancements] documentation to learn more about the capabilities of the {kib} query language.
2127

2228
[float]
2329
[[discover-advanced-queries]]
2430
=== Querying in Discover
2531

26-
It may also be helpful to view your APM data in {kibana-ref}/discover.html[*Discover*].
32+
Alternatively, you can query your APM documents in {kibana-ref}/discover.html[*Discover*].
2733
Querying documents in *Discover* works the same way as querying in the APM app,
28-
and all of the example APM app queries can also be used in *Discover*.
34+
and *Discover* supports all of the example APM app queries shown on this page.
2935

3036
[float]
3137
==== Example Discover query
3238

3339
One example where you may want to make use of *Discover*,
3440
is for viewing _all_ transactions for an endpoint, instead of just a sample.
3541

36-
TIP: Starting in v7.6, you can view 10 samples per bucket in the APM app, instead of just one.
42+
TIP: Starting in v7.6, you can view ten samples per bucket in the APM app, instead of just one.
3743

3844
Use the APM app to find a transaction name and time bucket that you're interested in learning more about.
3945
Then, switch to *Discover* and make a search:

docs/apm/agent-configuration.asciidoc

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,45 @@
11
[role="xpack"]
22
[[agent-configuration]]
3-
=== APM Agent configuration
3+
=== APM Agent central configuration
44

5-
APM Agent configuration allows you to fine-tune your agent configuration directly in Kibana.
6-
Best of all, changes are automatically propagated to your APM agents so there's no need to redeploy.
5+
++++
6+
<titleabbrev>Configure APM agents with central config</titleabbrev>
7+
++++
78

8-
To get started, simply choose the services and environments you wish to configure.
9-
The APM app will let you know when your configurations have been applied by your agents.
9+
APM Agent configuration allows you to fine-tune your agent configuration from within the APM app.
10+
Changes are automatically propagated to your APM agents, so there's no need to redeploy.
11+
12+
To get started, choose the services and environments you wish to configure.
13+
The APM app will let you know when your agents have applied your configurations.
1014

1115
[role="screenshot"]
1216
image::apm/images/apm-agent-configuration.png[APM Agent configuration in Kibana]
1317

1418
[float]
1519
==== Precedence
1620

17-
Configurations set with APM Agent configuration take precedence over configurations set locally in the Agent.
21+
Configurations set from the APM app take precedence over configurations set locally in each Agent.
1822
However, if APM Server is slow to respond, is offline, reports an error, etc.,
1923
APM agents will use local defaults until they're able to update the configuration.
20-
For this reason, it is still important to set custom default configurations locally in each of your agents.
24+
For this reason, it is still essential to set custom default configurations locally in each of your agents.
2125

2226
[float]
2327
==== APM Server setup
2428

2529
This feature requires {apm-server-ref}/setup-kibana-endpoint.html[Kibana endpoint configuration] in APM Server.
2630

27-
Why is additional configuration needed in APM Server?
28-
That's because APM Server acts as a proxy between the agents and Kibana.
31+
APM Server acts as a proxy between the agents and Kibana.
2932
Kibana communicates any changed settings to APM Server so that your agents only need to poll APM Server to determine which settings have changed.
3033

3134
[float]
3235
==== Supported configurations
3336

34-
Each Agent has its own list of supported configurations.
37+
Each Agent has a list of supported configurations.
3538
After selecting a Service name and environment in the APM app,
36-
a list of all available configuration options,
39+
a list of all supported configuration options,
3740
including descriptions and default values, will be displayed.
3841

39-
Supported configurations are also marked in each Agent's configuration documentation:
42+
Supported configurations are also tagged with the image:./images/dynamic-config.svg[] badge in each Agent's configuration reference:
4043

4144
[horizontal]
4245
Go Agent:: {apm-go-ref}/configuration.html[Configuration reference]

docs/apm/api.asciidoc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
[role="xpack"]
22
[[apm-api]]
3-
== API
3+
== APM app API
4+
5+
++++
6+
<titleabbrev>REST API</titleabbrev>
7+
++++
48

59
Some APM app features are provided via a REST API:
610

docs/apm/apm-alerts.asciidoc

Lines changed: 101 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,101 @@
1+
[role="xpack"]
2+
[[apm-alerts]]
3+
=== Alerts
4+
5+
++++
6+
<titleabbrev>Create an alert</titleabbrev>
7+
++++
8+
9+
beta::[]
10+
11+
The APM app integrates with Kibana's {kibana-ref}/alerting-getting-started.html[alerting and actions] feature.
12+
It provides a set of built-in **actions** and APM specific threshold **alerts** for you to use
13+
and enables central management of all alerts from <<management,Kibana Management>>.
14+
15+
[role="screenshot"]
16+
image::apm/images/apm-alert.png[Create an alert in the APM app]
17+
18+
There are two different types of threshold alerts: transaction duration, and error rate.
19+
Below, we'll create one of each.
20+
21+
[float]
22+
[[apm-create-transaction-alert]]
23+
=== Create a transaction duration alert
24+
25+
This guide creates an alert for the `opbeans-java` service based on the following criteria:
26+
27+
* Transaction type: `transaction.type:request`
28+
* Average request is above `1500ms` for the last 5 minutes
29+
* Check every 10 minutes, and repeat the alert every 30 minutes
30+
* Send the alert via Slack
31+
32+
From the APM app, navigate to the `opbeans-java` service and select
33+
**Alerts** > **Create threshold alert** > **Transaction duration**.
34+
35+
`Transaction duration | opbeans-java` is automatically set as the name of the alert,
36+
and `apm` and `service.name:opbeans-java` are added as tags.
37+
It's fine to change the name of the alert, but do not edit the tags.
38+
39+
Based on the alert criteria, define the following alert details:
40+
41+
* **Check every** - `10 minutes`
42+
* **Notify every** - `30 minutes`
43+
* **TYPE** - `request`
44+
* **WHEN** - `avg`
45+
* **IS ABOVE** - `1500ms`
46+
* **FOR THE LAST** - `5 minutes`
47+
48+
Select an action type.
49+
Multiple action types can be selected, but in this example, we want to post to a Slack channel.
50+
Select **Slack** > **Create a connector**.
51+
Enter a name for the connector,
52+
and paste the webhook URL.
53+
See Slack's webhook documentation if you need to create one.
54+
55+
Select **Save**. The alert has been created and is now active!
56+
57+
[float]
58+
[[apm-create-error-alert]]
59+
=== Create an error rate alert
60+
61+
This guide creates an alert for the `opbeans-python` service based on the following criteria:
62+
63+
* Error rate is above 25 for the last minute
64+
* Check every 1 minute, and repeat the alert every 10 minutes
65+
* Send the alert via email to the `opbeans-python` team
66+
67+
From the APM app, navigate to the `opbeans-python` service and select
68+
**Alerts** > **Create threshold alert** > **Error rate**.
69+
70+
`Error rate | opbeans-python` is automatically set as the name of the alert,
71+
and `apm` and `service.name:opbeans-python` are added as tags.
72+
It's fine to change the name of the alert, but do not edit the tags.
73+
74+
Based on the alert criteria, define the following alert details:
75+
76+
* **Check every** - `1 minute`
77+
* **Notify every** - `10 minutes`
78+
* **IS ABOVE** - `25 errors`
79+
* **FOR THE LAST** - `1 minute`
80+
81+
Select the **Email** action type and click **Create a connector**.
82+
Fill out the required details: sender, host, port, etc., and click **save**.
83+
84+
Select **Save**. The alert has been created and is now active!
85+
86+
[float]
87+
[[apm-alert-manage]]
88+
=== Manage alerts and actions
89+
90+
From the APM app, select **Alerts** > **View active alerts** to be taken to the Kibana alerts and actions management page.
91+
From this page, you can create, edit, disable, mute, and delete alerts, and create, edit, and disable connectors.
92+
93+
[float]
94+
[[apm-alert-more-info]]
95+
=== More information
96+
97+
See {kibana-ref}/alerting-getting-started.html[alerting and actions] for more information.
98+
99+
NOTE: If you are using an **on-premise** Elastic Stack deployment with security,
100+
communication between Elasticsearch and Kibana must have TLS configured.
101+
More information is in the alerting {kibana-ref}/alerting-getting-started.html#alerting-setup-prerequisites[prerequisites].

docs/apm/bottlenecks.asciidoc

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)