Skip to content

Commit 8f37f6e

Browse files
Spencerelasticmachine
Spencer
and
elasticmachine
authored
Unskip flaky tests (#57715)
* Revert "Skip flaky test (#57675)" This reverts commit c965a9e. * Revert "disable firefox smoke tests so we can fix flakiness out of band" This reverts commit fe38642. * Revert "skip flaky tests (#57643)" This reverts commit b220454. * Revert "skip flaky suite (#50018)" This reverts commit b058dc2. * Revert "skip settings tests (#57608)" This reverts commit 64625b2. * Revert "skip failing suite (#44631)" This reverts commit 8aa718d. * Revert "skip flaky suite (#44631)" This reverts commit 6e4efdf. * Revert "skip flaky test (#57377)" This reverts commit 59672ab. * Revert "Skip save query tests (#57589)" This reverts commit 431a1e9. * remove hard coded timeouts * Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band"" This reverts commit 271f881. * Revert "remove hard coded timeouts" This reverts commit 8b843d0. * wait for managementHome to exist, don't bail early if it's missing * Revert "skip flaky suite (#45244)" This reverts commit 0cee1a4. * extend timeouts for common existsOrFail() calls Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent 1319b65 commit 8f37f6e

File tree

15 files changed

+99
-60
lines changed

15 files changed

+99
-60
lines changed

‎test/functional/page_objects/common_page.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
114114
);
115115
await find.byCssSelector(
116116
'[data-test-subj="kibanaChrome"] nav:not(.ng-hide)',
117-
2 * defaultFindTimeout
117+
6 * defaultFindTimeout
118118
);
119119
await browser.get(appUrl);
120120
currentUrl = await browser.getCurrentUrl();

‎x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
1010
const esArchiver = getService('esArchiver');
1111
const kibanaServer = getService('kibanaServer');
1212
const security = getService('security');
13+
const config = getService('config');
1314
const PageObjects = getPageObjects(['common', 'settings', 'security', 'spaceSelector']);
1415
const appsMenu = getService('appsMenu');
1516
const testSubjects = getService('testSubjects');
@@ -178,14 +179,13 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
178179
expect(navLinks).to.eql(['Discover', 'Stack Management']);
179180
});
180181

181-
// https://github.com/elastic/kibana/issues/57377
182-
it.skip(`does not allow navigation to advanced settings; redirects to management home`, async () => {
182+
it(`does not allow navigation to advanced settings; redirects to management home`, async () => {
183183
await PageObjects.common.navigateToActualUrl('kibana', 'management/kibana/settings', {
184184
ensureCurrentUrl: false,
185185
shouldLoginIfPrompted: false,
186186
});
187187
await testSubjects.existOrFail('managementHome', {
188-
timeout: 10000,
188+
timeout: config.get('timeouts.waitFor'),
189189
});
190190
});
191191
});

‎x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_spaces.ts‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
1212
const PageObjects = getPageObjects(['common', 'settings', 'security', 'spaceSelector']);
1313
const testSubjects = getService('testSubjects');
1414
const appsMenu = getService('appsMenu');
15+
const config = getService('config');
1516

16-
// FLAKY: https://github.com/elastic/kibana/issues/57377
17-
describe.skip('spaces feature controls', () => {
17+
describe('spaces feature controls', () => {
1818
before(async () => {
1919
await esArchiver.loadIfNeeded('logstash_functional');
2020
});
@@ -58,8 +58,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
5858
});
5959
});
6060

61-
// https://github.com/elastic/kibana/issues/57413
62-
describe.skip('space with Advanced Settings disabled', () => {
61+
describe('space with Advanced Settings disabled', () => {
6362
before(async () => {
6463
// we need to load the following in every situation as deleting
6564
// a space deletes all of the associated saved objects
@@ -82,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
8281
ensureCurrentUrl: false,
8382
shouldLoginIfPrompted: false,
8483
});
85-
await testSubjects.existOrFail('managementHome');
84+
await testSubjects.existOrFail('managementHome', {
85+
timeout: config.get('timeouts.waitFor'),
86+
});
8687
});
8788
});
8889
});

‎x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts‎

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
1313
export default function({ getPageObjects, getService }: FtrProviderContext) {
1414
const esArchiver = getService('esArchiver');
1515
const security = getService('security');
16+
const config = getService('config');
1617
const PageObjects = getPageObjects(['common', 'dashboard', 'security', 'spaceSelector', 'share']);
1718
const appsMenu = getService('appsMenu');
1819
const panelActions = getService('dashboardPanelActions');
@@ -21,8 +22,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
2122
const queryBar = getService('queryBar');
2223
const savedQueryManagementComponent = getService('savedQueryManagementComponent');
2324

24-
// FLAKY: https://github.com/elastic/kibana/issues/44631
25-
describe.skip('dashboard security', () => {
25+
describe('dashboard security', () => {
2626
before(async () => {
2727
await esArchiver.load('dashboard/feature_controls/security');
2828
await esArchiver.loadIfNeeded('logstash_functional');
@@ -88,7 +88,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
8888
shouldLoginIfPrompted: false,
8989
}
9090
);
91-
await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
91+
await testSubjects.existOrFail('dashboardLandingPage', {
92+
timeout: config.get('timeouts.waitFor'),
93+
});
9294
await testSubjects.existOrFail('newItemButton');
9395
});
9496

@@ -105,15 +107,19 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
105107
shouldLoginIfPrompted: false,
106108
}
107109
);
108-
await testSubjects.existOrFail('emptyDashboardWidget', { timeout: 10000 });
110+
await testSubjects.existOrFail('emptyDashboardWidget', {
111+
timeout: config.get('timeouts.waitFor'),
112+
});
109113
});
110114

111115
it(`can view existing Dashboard`, async () => {
112116
await PageObjects.common.navigateToActualUrl('kibana', createDashboardEditUrl('i-exist'), {
113117
ensureCurrentUrl: false,
114118
shouldLoginIfPrompted: false,
115119
});
116-
await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 });
120+
await testSubjects.existOrFail('embeddablePanelHeading-APie', {
121+
timeout: config.get('timeouts.waitFor'),
122+
});
117123
});
118124

119125
it(`does not allow a visualization to be edited`, async () => {
@@ -266,7 +272,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
266272
shouldLoginIfPrompted: false,
267273
}
268274
);
269-
await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
275+
await testSubjects.existOrFail('dashboardLandingPage', {
276+
timeout: config.get('timeouts.waitFor'),
277+
});
270278
await testSubjects.missingOrFail('newItemButton');
271279
});
272280

@@ -291,7 +299,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
291299
ensureCurrentUrl: false,
292300
shouldLoginIfPrompted: false,
293301
});
294-
await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 });
302+
await testSubjects.existOrFail('embeddablePanelHeading-APie', {
303+
timeout: config.get('timeouts.waitFor'),
304+
});
295305
});
296306

297307
it(`Permalinks doesn't show create short-url button`, async () => {
@@ -377,7 +387,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
377387
shouldLoginIfPrompted: false,
378388
}
379389
);
380-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
390+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
381391
});
382392

383393
it(`create new dashboard redirects to the home page`, async () => {
@@ -401,15 +411,15 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
401411
shouldLoginIfPrompted: false,
402412
}
403413
);
404-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
414+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
405415
});
406416

407417
it(`edit dashboard for object which exists redirects to the home page`, async () => {
408418
await PageObjects.common.navigateToActualUrl('kibana', createDashboardEditUrl('i-exist'), {
409419
ensureCurrentUrl: false,
410420
shouldLoginIfPrompted: false,
411421
});
412-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
422+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
413423
});
414424
});
415425
});

‎x-pack/test/functional/apps/dashboard/feature_controls/dashboard_spaces.ts‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
1212

1313
export default function({ getPageObjects, getService }: FtrProviderContext) {
1414
const esArchiver = getService('esArchiver');
15+
const config = getService('config');
1516
const spacesService = getService('spaces');
1617
const PageObjects = getPageObjects([
1718
'common',
@@ -64,7 +65,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
6465
shouldLoginIfPrompted: false,
6566
}
6667
);
67-
await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
68+
await testSubjects.existOrFail('dashboardLandingPage', {
69+
timeout: config.get('timeouts.waitFor'),
70+
});
6871
await testSubjects.existOrFail('newItemButton');
6972
});
7073

@@ -78,7 +81,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
7881
shouldLoginIfPrompted: false,
7982
}
8083
);
81-
await testSubjects.existOrFail('emptyDashboardWidget', { timeout: 10000 });
84+
await testSubjects.existOrFail('emptyDashboardWidget', {
85+
timeout: config.get('timeouts.waitFor'),
86+
});
8287
});
8388

8489
it(`can view existing Dashboard`, async () => {
@@ -87,7 +92,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
8792
ensureCurrentUrl: false,
8893
shouldLoginIfPrompted: false,
8994
});
90-
await testSubjects.existOrFail('embeddablePanelHeading-APie', { timeout: 10000 });
95+
await testSubjects.existOrFail('embeddablePanelHeading-APie', {
96+
timeout: config.get('timeouts.waitFor'),
97+
});
9198
});
9299
});
93100

@@ -126,7 +133,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
126133
shouldLoginIfPrompted: false,
127134
}
128135
);
129-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
136+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
130137
});
131138

132139
it(`edit dashboard for object which doesn't exist redirects to the home page`, async () => {
@@ -139,7 +146,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
139146
shouldLoginIfPrompted: false,
140147
}
141148
);
142-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
149+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
143150
});
144151

145152
it(`edit dashboard for object which exists redirects to the home page`, async () => {
@@ -148,7 +155,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
148155
ensureCurrentUrl: false,
149156
shouldLoginIfPrompted: false,
150157
});
151-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
158+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
152159
});
153160
});
154161
});

‎x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_security.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
1010
const esArchiver = getService('esArchiver');
1111
const security = getService('security');
1212
const PageObjects = getPageObjects(['common', 'console', 'security']);
13+
const config = getService('config');
1314
const appsMenu = getService('appsMenu');
1415
const testSubjects = getService('testSubjects');
1516
const grokDebugger = getService('grokDebugger');
@@ -232,21 +233,21 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
232233
await PageObjects.common.navigateToUrl('console', '', {
233234
ensureCurrentUrl: false,
234235
});
235-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
236+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
236237
});
237238

238239
it(`navigating to search profiler redirect to homepage`, async () => {
239240
await PageObjects.common.navigateToUrl('searchProfiler', '', {
240241
ensureCurrentUrl: false,
241242
});
242-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
243+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
243244
});
244245

245246
it(`navigating to grok debugger redirect to homepage`, async () => {
246247
await PageObjects.common.navigateToUrl('grokDebugger', '', {
247248
ensureCurrentUrl: false,
248249
});
249-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
250+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
250251
});
251252
});
252253
});

‎x-pack/test/functional/apps/dev_tools/feature_controls/dev_tools_spaces.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
88

99
export default function({ getPageObjects, getService }: FtrProviderContext) {
1010
const esArchiver = getService('esArchiver');
11+
const config = getService('config');
1112
const spacesService = getService('spaces');
1213
const PageObjects = getPageObjects([
1314
'common',
@@ -92,21 +93,21 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
9293
await PageObjects.common.navigateToUrl('console', '', {
9394
ensureCurrentUrl: false,
9495
});
95-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
96+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
9697
});
9798

9899
it(`navigating to search profiler redirect to homepage`, async () => {
99100
await PageObjects.common.navigateToUrl('searchProfiler', '', {
100101
ensureCurrentUrl: false,
101102
});
102-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
103+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
103104
});
104105

105106
it(`navigating to grok debugger redirect to homepage`, async () => {
106107
await PageObjects.common.navigateToUrl('grokDebugger', '', {
107108
ensureCurrentUrl: false,
108109
});
109-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
110+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
110111
});
111112
});
112113
});

‎x-pack/test/functional/apps/discover/feature_controls/discover_security.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
1010
const esArchiver = getService('esArchiver');
1111
const security = getService('security');
1212
const globalNav = getService('globalNav');
13+
const config = getService('config');
1314
const PageObjects = getPageObjects([
1415
'common',
1516
'discover',
@@ -27,8 +28,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
2728
await PageObjects.timePicker.setDefaultAbsoluteRange();
2829
}
2930

30-
// FLAKY: https://github.com/elastic/kibana/issues/45348
31-
describe.skip('security', () => {
31+
describe('security', () => {
3232
before(async () => {
3333
await esArchiver.load('discover/feature_controls/security');
3434
await esArchiver.loadIfNeeded('logstash_functional');
@@ -305,7 +305,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
305305
await PageObjects.common.navigateToUrl('discover', '', {
306306
ensureCurrentUrl: false,
307307
});
308-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
308+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
309309
});
310310
});
311311
});

‎x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
88

99
export default function({ getPageObjects, getService }: FtrProviderContext) {
1010
const esArchiver = getService('esArchiver');
11+
const config = getService('config');
1112
const spacesService = getService('spaces');
1213
const PageObjects = getPageObjects([
1314
'common',
@@ -59,7 +60,9 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
5960
await PageObjects.common.navigateToApp('discover', {
6061
basePath: '/s/custom_space',
6162
});
62-
await testSubjects.existOrFail('discoverSaveButton', { timeout: 10000 });
63+
await testSubjects.existOrFail('discoverSaveButton', {
64+
timeout: config.get('timeouts.waitFor'),
65+
});
6366
});
6467

6568
it('shows "visualize" field button', async () => {
@@ -156,7 +159,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
156159
basePath: '/s/custom_space',
157160
ensureCurrentUrl: false,
158161
});
159-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
162+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
160163
});
161164
});
162165
});

‎x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_security.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
1010
const esArchiver = getService('esArchiver');
1111
const kibanaServer = getService('kibanaServer');
1212
const security = getService('security');
13+
const config = getService('config');
1314
const PageObjects = getPageObjects(['common', 'settings', 'security']);
1415
const appsMenu = getService('appsMenu');
1516
const testSubjects = getService('testSubjects');
@@ -190,7 +191,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) {
190191
ensureCurrentUrl: false,
191192
shouldLoginIfPrompted: false,
192193
});
193-
await testSubjects.existOrFail('homeApp', { timeout: 10000 });
194+
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
194195
});
195196
});
196197
});

0 commit comments

Comments
 (0)