@stacey-gammon review

Author: Dosant

x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx

@@ -71,7 +71,7 @@ export class FlyoutCreateDrilldownAction implements ActionByType<typeof OPEN_FLY
       ),
       {
         ownFocus: true,
-        'data-test-subj': 'dashboardCreateDrilldownFlyout',
+        'data-test-subj': 'createDrilldownFlyout',
       }
     );
   }

x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx

@@ -69,7 +69,7 @@ export class FlyoutEditDrilldownAction implements ActionByType<typeof OPEN_FLYOU
       ),
       {
         ownFocus: true,
-        'data-test-subj': 'dashboardEditDrilldownFlyout',
+        'data-test-subj': 'editDrilldownFlyout',
       }
     );
   }

x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/components/collect_config_container.tsx

@@ -49,7 +49,7 @@ interface CollectConfigContainerState {
   searchString?: string;
   isLoading: boolean;
   selectedDashboard?: EuiComboBoxOptionOption<string>;
-  error: string | null;
+  error?: string;
 }
 
 export class CollectConfigContainer extends React.Component<
@@ -62,7 +62,7 @@ export class CollectConfigContainer extends React.Component<
     isLoading: false,
     searchString: undefined,
     selectedDashboard: undefined,
-    error: null,
+    error: undefined,
   };
 
   constructor(props: CollectConfigProps) {
@@ -94,7 +94,7 @@ export class CollectConfigContainer extends React.Component<
         onDashboardSelect={dashboardId => {
           onConfig({ ...config, dashboardId });
           if (this.state.error) {
-            this.setState({ error: null });
+            this.setState({ error: undefined });
           }
         }}
         onSearchChange={this.debouncedLoadDashboards}

x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/components/dashboard_drilldown_config/dashboard_drilldown_config.tsx

@@ -22,7 +22,7 @@ export interface DashboardDrilldownConfigProps {
   onKeepRangeToggle?: () => void;
   onSearchChange: (searchString: string) => void;
   isLoading: boolean;
-  error?: string | null;
+  error?: string;
 }
 
 export const DashboardDrilldownConfig: React.FC<DashboardDrilldownConfigProps> = ({

x-pack/plugins/dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx

@@ -164,7 +164,7 @@ describe('.execute() & getHref', () => {
     expect(href).toEqual(expect.stringContaining(`dashboard/${testDashboardId}`));
   });
 
-  test('query is removed with query if filters are disabled', async () => {
+  test('query is removed if filters are disabled', async () => {
     const queryString = 'querystring';
     const queryLanguage = 'kuery';
     const { href } = await setupTestBed(

x-pack/test/functional/services/dashboard/drilldowns_manage.ts

@@ -6,8 +6,8 @@
 
 import { FtrProviderContext } from '../../ftr_provider_context';
 
-const CREATE_DRILLDOWN_FLYOUT_DATA_TEST_SUBJ = 'dashboardCreateDrilldownFlyout';
-const MANAGE_DRILLDOWNS_FLYOUT_DATA_TEST_SUBJ = 'dashboardEditDrilldownFlyout';
+const CREATE_DRILLDOWN_FLYOUT_DATA_TEST_SUBJ = 'createDrilldownFlyout';
+const MANAGE_DRILLDOWNS_FLYOUT_DATA_TEST_SUBJ = 'editDrilldownFlyout';
 const DASHBOARD_TO_DASHBOARD_ACTION_LIST_ITEM =
   'actionFactoryItem-DASHBOARD_TO_DASHBOARD_DRILLDOWN';
 const DASHBOARD_TO_DASHBOARD_ACTION_WIZARD =