Skip to content

Commit 8abd858

Browse files
XavierMpatrykkopycinskiMadameSheemaelasticmachinejonathan-buttner
committed
[SECURITY] Introduce kibana nav (#68862)
* Change the bootstrap of the app * rename SiemPageName to SecurityPageName * modify alerts routes * modify cases routes * modify hosts routes * modify network routes * modify overview routes * modify timelines routes * wip change management route * change route for common * some fixing from the first commit * modify route for management * update url format hook to use history * bug when you click on external alerts from host or network * improvement from josh feedback * redirect siem to security solution * a little clean up * Fix types * fix breadcrumbs * fix unit test * Update index.tsx * Fix cypress * bug remove timeline when you are in case configure * Fix functionel test for management * Fix redirect siem + ml * fixes some cypress tests * adds 'URL compatibility' test * bring ml back to alerts * review I * Fix memory leak in timelines page * fix storage bug for timeline search bar * fix endpoint merge + functional test * avoid timeline flyout toggle * Fix link to ml score * Fix breadcrumb * Fix management url * fix unit test * fixes typecheck issue * fixes remaining url cypress tests * fixes timeline scenario * fix link to details rule from timeline * review remove absolute path for consistency * Fixing resolver alert generation (#69587) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Security_Solution][Endpoint] Resolver leverage ancestry array for queries (#69264) * Adding alerts route * Adding related alerts generator changes, tests, and script updates * Fixing missed parameter * Aligning the AlertEvent and ResolverEvent definition * Fixing type errors * Fixing import error * Adding ancestry functionality in generator * Creating some tests for ancestry field * Making progress on the ancestry * Fixing the ancestry verification * Fixing existing tests * Removing unused code and fixing test * Adding more comments * Fixing endgame queries Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * fix cypress test * skip failing suite (#69595) * [Endpoint] Fix flaky endpoints list unit test (#69591) * Fix flaky endpoints list unit test * un-skip test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * remove flaky test Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
1 parent 49ebf03 commit 8abd858

File tree

239 files changed

+2889
-2329
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

239 files changed

+2889
-2329
lines changed

‎x-pack/plugins/security_solution/common/constants.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,14 @@ export const DEFAULT_INTERVAL_VALUE = 300000; // ms
3434
export const DEFAULT_TIMEPICKER_QUICK_RANGES = 'timepicker:quickRanges';
3535
export const NO_ALERT_INDEX = 'no-alert-index-049FC71A-4C2C-446F-9901-37XMC5024C51';
3636

37+
export const APP_OVERVIEW_PATH = `${APP_PATH}/overview`;
38+
export const APP_ALERTS_PATH = `${APP_PATH}/alerts`;
39+
export const APP_HOSTS_PATH = `${APP_PATH}/hosts`;
40+
export const APP_NETWORK_PATH = `${APP_PATH}/network`;
41+
export const APP_TIMELINES_PATH = `${APP_PATH}/timelines`;
42+
export const APP_CASES_PATH = `${APP_PATH}/cases`;
43+
export const APP_MANAGEMENT_PATH = `${APP_PATH}/management`;
44+
3745
/** The comma-delimited list of Elasticsearch indices from which the SIEM app collects events */
3846
export const DEFAULT_INDEX_PATTERN = [
3947
'apm-*-transaction*',

‎x-pack/plugins/security_solution/cypress/integration/detections.spec.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ import {
2828
import { esArchiverLoad } from '../tasks/es_archiver';
2929
import { loginAndWaitForPage } from '../tasks/login';
3030

31-
import { DETECTIONS } from '../urls/navigation';
31+
import { ALERTS_URL } from '../urls/navigation';
3232

3333
describe('Detections', () => {
3434
context('Closing alerts', () => {
3535
beforeEach(() => {
3636
esArchiverLoad('alerts');
37-
loginAndWaitForPage(DETECTIONS);
37+
loginAndWaitForPage(ALERTS_URL);
3838
});
3939

4040
it('Closes and opens alerts', () => {
@@ -161,7 +161,7 @@ describe('Detections', () => {
161161
context('Opening alerts', () => {
162162
beforeEach(() => {
163163
esArchiverLoad('closed_alerts');
164-
loginAndWaitForPage(DETECTIONS);
164+
loginAndWaitForPage(ALERTS_URL);
165165
});
166166

167167
it('Open one alert when more than one closed alerts are selected', () => {
@@ -207,7 +207,7 @@ describe('Detections', () => {
207207
context('Marking alerts as in-progress', () => {
208208
beforeEach(() => {
209209
esArchiverLoad('alerts');
210-
loginAndWaitForPage(DETECTIONS);
210+
loginAndWaitForPage(ALERTS_URL);
211211
});
212212

213213
it('Mark one alert in progress when more than one open alerts are selected', () => {

‎x-pack/plugins/security_solution/cypress/integration/detections_timeline.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ import {
1515
import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
1616
import { loginAndWaitForPage } from '../tasks/login';
1717

18-
import { DETECTIONS } from '../urls/navigation';
18+
import { ALERTS_URL } from '../urls/navigation';
1919

2020
describe('Detections timeline', () => {
2121
beforeEach(() => {
2222
esArchiverLoad('timeline_alerts');
23-
loginAndWaitForPage(DETECTIONS);
23+
loginAndWaitForPage(ALERTS_URL);
2424
});
2525

2626
afterEach(() => {

‎x-pack/plugins/security_solution/cypress/integration/ml_conditional_links.spec.ts‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -101,103 +101,103 @@ describe('ml conditional links', () => {
101101
loginAndWaitForPageWithoutDateRange(mlNetworkSingleIpNullKqlQuery);
102102
cy.url().should(
103103
'include',
104-
'/app/security#/network/ip/127.0.0.1/source?timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
104+
'/app/security/network/ip/127.0.0.1/source?timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
105105
);
106106
});
107107

108108
it('redirects from a single IP with a value for the query', () => {
109109
loginAndWaitForPageWithoutDateRange(mlNetworkSingleIpKqlQuery);
110110
cy.url().should(
111111
'include',
112-
"/app/security#/network/ip/127.0.0.1/source?query=(language:kuery,query:'(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)')&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))"
112+
'/app/security/network/ip/127.0.0.1/source?query=(language:kuery,query:%27(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
113113
);
114114
});
115115

116116
it('redirects from a multiple IPs with a null for the query', () => {
117117
loginAndWaitForPageWithoutDateRange(mlNetworkMultipleIpNullKqlQuery);
118118
cy.url().should(
119119
'include',
120-
"app/security#/network/flows?query=(language:kuery,query:'((source.ip:%20%22127.0.0.1%22%20or%20destination.ip:%20%22127.0.0.1%22)%20or%20(source.ip:%20%22127.0.0.2%22%20or%20destination.ip:%20%22127.0.0.2%22))')&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999))"
120+
'app/security/network/flows?query=(language:kuery,query:%27((source.ip:%20%22127.0.0.1%22%20or%20destination.ip:%20%22127.0.0.1%22)%20or%20(source.ip:%20%22127.0.0.2%22%20or%20destination.ip:%20%22127.0.0.2%22))%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999))'
121121
);
122122
});
123123

124124
it('redirects from a multiple IPs with a value for the query', () => {
125125
loginAndWaitForPageWithoutDateRange(mlNetworkMultipleIpKqlQuery);
126126
cy.url().should(
127127
'include',
128-
"/app/security#/network/flows?query=(language:kuery,query:'((source.ip:%20%22127.0.0.1%22%20or%20destination.ip:%20%22127.0.0.1%22)%20or%20(source.ip:%20%22127.0.0.2%22%20or%20destination.ip:%20%22127.0.0.2%22))%20and%20((process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22))')&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))"
128+
'/app/security/network/flows?query=(language:kuery,query:%27((source.ip:%20%22127.0.0.1%22%20or%20destination.ip:%20%22127.0.0.1%22)%20or%20(source.ip:%20%22127.0.0.2%22%20or%20destination.ip:%20%22127.0.0.2%22))%20and%20((process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22))%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
129129
);
130130
});
131131

132132
it('redirects from a $ip$ with a null query', () => {
133133
loginAndWaitForPageWithoutDateRange(mlNetworkNullKqlQuery);
134134
cy.url().should(
135135
'include',
136-
'/app/security#/network/flows?timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
136+
'/app/security/network/flows?timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
137137
);
138138
});
139139

140140
it('redirects from a $ip$ with a value for the query', () => {
141141
loginAndWaitForPageWithoutDateRange(mlNetworkKqlQuery);
142142
cy.url().should(
143143
'include',
144-
"/app/security#/network/flows?query=(language:kuery,query:'(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)')&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))"
144+
'/app/security/network/flows?query=(language:kuery,query:%27(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1566990000000,kind:absolute,to:1567000799999)),timeline:(linkTo:!(global),timerange:(from:1566990000000,kind:absolute,to:1567000799999)))'
145145
);
146146
});
147147

148148
it('redirects from a single host name with a null for the query', () => {
149149
loginAndWaitForPageWithoutDateRange(mlHostSingleHostNullKqlQuery);
150150
cy.url().should(
151151
'include',
152-
'/app/security#/hosts/siem-windows/anomalies?timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
152+
'/app/security/hosts/siem-windows/anomalies?timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
153153
);
154154
});
155155

156156
it('redirects from a host name with a variable in the query', () => {
157157
loginAndWaitForPageWithoutDateRange(mlHostSingleHostKqlQueryVariable);
158158
cy.url().should(
159159
'include',
160-
'/app/security#/hosts/siem-windows/anomalies?timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
160+
'/app/security/hosts/siem-windows/anomalies?timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
161161
);
162162
});
163163

164164
it('redirects from a single host name with a value for query', () => {
165165
loginAndWaitForPageWithoutDateRange(mlHostSingleHostKqlQuery);
166166
cy.url().should(
167167
'include',
168-
"/app/security#/hosts/siem-windows/anomalies?query=(language:kuery,query:'(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)')&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))"
168+
'/app/security/hosts/siem-windows/anomalies?query=(language:kuery,query:%27(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
169169
);
170170
});
171171

172172
it('redirects from a multiple host names with null for query', () => {
173173
loginAndWaitForPageWithoutDateRange(mlHostMultiHostNullKqlQuery);
174174
cy.url().should(
175175
'include',
176-
"/app/security#/hosts/anomalies?query=(language:kuery,query:'(host.name:%20%22siem-windows%22%20or%20host.name:%20%22siem-suricata%22)')&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))"
176+
'/app/security/hosts/anomalies?query=(language:kuery,query:%27(host.name:%20%22siem-windows%22%20or%20host.name:%20%22siem-suricata%22)%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
177177
);
178178
});
179179

180180
it('redirects from a multiple host names with a value for query', () => {
181181
loginAndWaitForPageWithoutDateRange(mlHostMultiHostKqlQuery);
182182
cy.url().should(
183183
'include',
184-
"/app/security#/hosts/anomalies?query=(language:kuery,query:'(host.name:%20%22siem-windows%22%20or%20host.name:%20%22siem-suricata%22)%20and%20((process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22))')&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))"
184+
'/app/security/hosts/anomalies?query=(language:kuery,query:%27(host.name:%20%22siem-windows%22%20or%20host.name:%20%22siem-suricata%22)%20and%20((process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22))%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
185185
);
186186
});
187187

188188
it('redirects from a undefined/null host name with a null for the KQL', () => {
189189
loginAndWaitForPageWithoutDateRange(mlHostVariableHostNullKqlQuery);
190190
cy.url().should(
191191
'include',
192-
'/app/security#/hosts/anomalies?timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
192+
'/app/security/hosts/anomalies?timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
193193
);
194194
});
195195

196196
it('redirects from a undefined/null host name but with a value for query', () => {
197197
loginAndWaitForPageWithoutDateRange(mlHostVariableHostKqlQuery);
198198
cy.url().should(
199199
'include',
200-
"/app/security#/hosts/anomalies?query=(language:kuery,query:'(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)')&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))"
200+
'/app/security/hosts/anomalies?query=(language:kuery,query:%27(process.name:%20%22conhost.exe%22%20or%20process.name:%20%22sc.exe%22)%27)&timerange=(global:(linkTo:!(timeline),timerange:(from:1559800800000,kind:absolute,to:1559887199999)),timeline:(linkTo:!(global),timerange:(from:1559800800000,kind:absolute,to:1559887199999)))'
201201
);
202202
});
203203
});

‎x-pack/plugins/security_solution/cypress/integration/navigation.spec.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* or more contributor license agreements. Licensed under the Elastic License;
44
* you may not use this file except in compliance with the Elastic License.
55
*/
6-
import { DETECTIONS, HOSTS, NETWORK, OVERVIEW, TIMELINES } from '../screens/security_header';
6+
import { ALERTS, HOSTS, NETWORK, OVERVIEW, TIMELINES } from '../screens/security_header';
77

88
import { loginAndWaitForPage } from '../tasks/login';
99
import { navigateFromHeaderTo } from '../tasks/security_header';
@@ -16,26 +16,26 @@ describe('top-level navigation common to all pages in the Security app', () => {
1616
});
1717
it('navigates to the Overview page', () => {
1818
navigateFromHeaderTo(OVERVIEW);
19-
cy.url().should('include', '/security#/overview');
19+
cy.url().should('include', '/security/overview');
2020
});
2121

2222
it('navigates to the Hosts page', () => {
2323
navigateFromHeaderTo(HOSTS);
24-
cy.url().should('include', '/security#/hosts');
24+
cy.url().should('include', '/security/hosts');
2525
});
2626

2727
it('navigates to the Network page', () => {
2828
navigateFromHeaderTo(NETWORK);
29-
cy.url().should('include', '/security#/network');
29+
cy.url().should('include', '/security/network');
3030
});
3131

32-
it('navigates to the Detections page', () => {
33-
navigateFromHeaderTo(DETECTIONS);
34-
cy.url().should('include', '/security#/detections');
32+
it('navigates to the Alerts page', () => {
33+
navigateFromHeaderTo(ALERTS);
34+
cy.url().should('include', '/security/alerts');
3535
});
3636

3737
it('navigates to the Timelines page', () => {
3838
navigateFromHeaderTo(TIMELINES);
39-
cy.url().should('include', '/security#/timelines');
39+
cy.url().should('include', '/security/timelines');
4040
});
4141
});

‎x-pack/plugins/security_solution/cypress/integration/signal_detection_rules.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import {
2626
waitForRuleToBeActivated,
2727
} from '../tasks/alert_detection_rules';
2828

29-
import { DETECTIONS } from '../urls/navigation';
29+
import { ALERTS_URL } from '../urls/navigation';
3030

3131
describe('Detection rules', () => {
3232
before(() => {
@@ -38,7 +38,7 @@ describe('Detection rules', () => {
3838
});
3939

4040
it('Sorts by activated rules', () => {
41-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
41+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
4242
waitForAlertsPanelToBeLoaded();
4343
waitForAlertsIndexToBeCreated();
4444
goToManageAlertDetectionRules();

‎x-pack/plugins/security_solution/cypress/integration/signal_detection_rules_custom.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ import {
6262
import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
6363
import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
6464

65-
import { DETECTIONS } from '../urls/navigation';
65+
import { ALERTS_URL } from '../urls/navigation';
6666

6767
describe('Detection rules, custom', () => {
6868
before(() => {
@@ -74,7 +74,7 @@ describe('Detection rules, custom', () => {
7474
});
7575

7676
it('Creates and activates a new custom rule', () => {
77-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
77+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
7878
waitForAlertsPanelToBeLoaded();
7979
waitForAlertsIndexToBeCreated();
8080
goToManageAlertDetectionRules();
@@ -169,7 +169,7 @@ describe('Detection rules, custom', () => {
169169
describe('Deletes custom rules', () => {
170170
beforeEach(() => {
171171
esArchiverLoad('custom_rules');
172-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
172+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
173173
waitForAlertsPanelToBeLoaded();
174174
waitForAlertsIndexToBeCreated();
175175
goToManageAlertDetectionRules();

‎x-pack/plugins/security_solution/cypress/integration/signal_detection_rules_export.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
1313
import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
1414
import { exportFirstRule } from '../tasks/alert_detection_rules';
1515

16-
import { DETECTIONS } from '../urls/navigation';
16+
import { ALERTS_URL } from '../urls/navigation';
1717

1818
const EXPECTED_EXPORTED_RULE_FILE_PATH = 'cypress/test_files/expected_rules_export.ndjson';
1919

@@ -32,7 +32,7 @@ describe('Export rules', () => {
3232
});
3333

3434
it('Exports a custom rule', () => {
35-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
35+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
3636
waitForAlertsPanelToBeLoaded();
3737
waitForAlertsIndexToBeCreated();
3838
goToManageAlertDetectionRules();

‎x-pack/plugins/security_solution/cypress/integration/signal_detection_rules_ml.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ import {
5858
import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
5959
import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
6060

61-
import { DETECTIONS } from '../urls/navigation';
61+
import { ALERTS_URL } from '../urls/navigation';
6262

6363
describe('Detection rules, machine learning', () => {
6464
before(() => {
@@ -70,7 +70,7 @@ describe('Detection rules, machine learning', () => {
7070
});
7171

7272
it('Creates and activates a new ml rule', () => {
73-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
73+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
7474
waitForAlertsPanelToBeLoaded();
7575
waitForAlertsIndexToBeCreated();
7676
goToManageAlertDetectionRules();

‎x-pack/plugins/security_solution/cypress/integration/signal_detection_rules_prebuilt.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {
3131
import { esArchiverLoadEmptyKibana, esArchiverUnloadEmptyKibana } from '../tasks/es_archiver';
3232
import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
3333

34-
import { DETECTIONS } from '../urls/navigation';
34+
import { ALERTS_URL } from '../urls/navigation';
3535

3636
import { totalNumberOfPrebuiltRules } from '../objects/rule';
3737

@@ -48,7 +48,7 @@ describe('Detection rules, prebuilt rules', () => {
4848
const expectedNumberOfRules = totalNumberOfPrebuiltRules;
4949
const expectedElasticRulesBtnText = `Elastic rules (${expectedNumberOfRules})`;
5050

51-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
51+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
5252
waitForAlertsPanelToBeLoaded();
5353
waitForAlertsIndexToBeCreated();
5454
goToManageAlertDetectionRules();
@@ -73,7 +73,7 @@ describe('Deleting prebuilt rules', () => {
7373
const expectedElasticRulesBtnText = `Elastic rules (${expectedNumberOfRules})`;
7474

7575
esArchiverLoadEmptyKibana();
76-
loginAndWaitForPageWithoutDateRange(DETECTIONS);
76+
loginAndWaitForPageWithoutDateRange(ALERTS_URL);
7777
waitForAlertsPanelToBeLoaded();
7878
waitForAlertsIndexToBeCreated();
7979
goToManageAlertDetectionRules();

0 commit comments

Comments
 (0)