fix unknown types and remove lodash.get

Author: nickofthyme

src/plugins/vis_type_vislib/public/pie_fn.ts

@@ -33,7 +33,7 @@ interface Arguments {
 }
 
 interface RenderValue {
-  visData: any;
+  visData: unknown;
   visType: string;
   visConfig: PieVisParams;
 }

src/plugins/vis_type_vislib/public/to_ast.ts

@@ -18,7 +18,6 @@
  */
 
 import moment from 'moment';
-import { get } from 'lodash';
 
 import { VisToExpressionAst, getVisSchemas } from '../../visualizations/public';
 import { buildExpression, buildExpressionFunction } from '../../expressions/public';
@@ -78,11 +77,11 @@ export const toExpressionAst: VisToExpressionAst<BasicVislibParams> = async (vis
       const usedValueAxis = (visConfig.valueAxes || []).find(
         (valueAxis) => valueAxis.id === seriesParam.valueAxis
       );
-      if (get(usedValueAxis, 'scale.mode') === 'percentage') {
+      if (usedValueAxis?.scale.mode === 'percentage') {
         yDimension.format = { id: 'percent' };
       }
     }
-    if (get(visConfig, 'gauge.percentageMode') === true) {
+    if (visConfig?.gauge.percentageMode === true) {
       yDimension.format = { id: 'percent' };
     }
   });

src/plugins/vis_type_vislib/public/types.ts

@@ -90,6 +90,9 @@ export interface BasicVislibParams extends CommonVislibParams {
   labels: Labels;
   thresholdLine: ThresholdLine;
   valueAxes: ValueAxis[];
+  gauge: {
+    percentageMode: boolean;
+  };
   grid: {
     categoryLines: boolean;
     valueAxis?: string;

src/plugins/vis_type_vislib/public/vis_controller.tsx

@@ -134,7 +134,7 @@ export const createVislibVisController = (
     }
 
     mountLegend(
-      visData: any,
+      visData: unknown,
       { legendPosition, addLegend }: BasicVislibParams | PieVisParams,
       fireEvent: IInterpreterRenderHandlers['event'],
       uiState?: PersistedState

src/plugins/vis_type_vislib/public/vis_renderer.tsx

@@ -17,7 +17,6 @@
  * under the License.
  */
 
-import { get } from 'lodash';
 import React, { lazy } from 'react';
 import { render, unmountComponentAtNode } from 'react-dom';
 
@@ -33,8 +32,8 @@ function shouldShowNoResultsMessage(visData: any, visType: string): boolean {
     return false;
   }
 
-  const rows: object[] | undefined = get(visData, 'rows');
-  const isZeroHits = get(visData, 'hits') === 0 || (rows && !rows.length);
+  const rows: object[] = visData?.rows ?? [];
+  const isZeroHits = visData?.hits === 0 || (rows && !rows.length);
 
   return Boolean(isZeroHits);
 }

src/plugins/vis_type_vislib/public/vislib/components/legend/legend.tsx

@@ -34,7 +34,7 @@ import { BasicVislibParams } from '../../../types';
 
 export interface VisLegendProps {
   vislibVis: any;
-  visData: any;
+  visData: unknown;
   uiState?: PersistedState;
   fireEvent: IInterpreterRenderHandlers['event'];
   addLegend: BasicVislibParams['addLegend'];