Deprecate services.callCluster in alerts and actions executors (#86474) (#86997)

mikecote · kibanamachine · web-flow · commit 8a08bc2a1f76 · 2020-12-29T14:37:19.000-05:00
* Deprecate callCluster in alerts and actions services

* Update deprecation comment

Co-authored-by: Kibana Machine &lt;42973632+kibanamachine@users.noreply.github.com&gt;

Co-authored-by: Kibana Machine &lt;42973632+kibanamachine@users.noreply.github.com&gt;
diff --git a/x-pack/plugins/actions/server/types.ts b/x-pack/plugins/actions/server/types.ts
@@ -31,6 +31,9 @@ export type ActionTypeSecrets = Record<string, unknown>;
 export type ActionTypeParams = Record<string, unknown>;
 
 export interface Services {
+  /**
+   * @deprecated Use `scopedClusterClient` instead.
+   */
   callCluster: ILegacyScopedClusterClient['callAsCurrentUser'];
   savedObjectsClient: SavedObjectsClientContract;
   scopedClusterClient: ElasticsearchClient;
diff --git a/x-pack/plugins/alerts/server/types.ts b/x-pack/plugins/alerts/server/types.ts
@@ -47,6 +47,9 @@ declare module 'src/core/server' {
 }
 
 export interface Services {
+  /**
+   * @deprecated Use `scopedClusterClient` instead.
+   */
   callCluster: ILegacyScopedClusterClient['callAsCurrentUser'];
   savedObjectsClient: SavedObjectsClientContract;
   scopedClusterClient: ElasticsearchClient;

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,9 @@ declare module 'src/core/server' {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`export interface Services {`
	`50`	`+ /**`
	`51`	+ * @deprecated Use `scopedClusterClient` instead.
	`52`	`+ */`
`50`	`53`	`callCluster: ILegacyScopedClusterClient['callAsCurrentUser'];`
`51`	`54`	`savedObjectsClient: SavedObjectsClientContract;`
`52`	`55`	`scopedClusterClient: ElasticsearchClient;`