Fix bug on TopN weird behavior with zero values (#74942) (#75048)

stratoula · elasticmachine · web-flow · commit 883b70402a84 · 2020-08-17T11:16:35.000+03:00
Co-authored-by: Elastic Machine &lt;elasticmachine@users.noreply.github.com&gt;
diff --git a/src/plugins/vis_type_timeseries/public/application/visualizations/views/top_n.js b/src/plugins/vis_type_timeseries/public/application/visualizations/views/top_n.js
@@ -110,7 +110,9 @@ export class TopN extends Component {
       const isPositiveValue = lastValue >= 0;
 
       const intervalLength = TopN.calcDomain(renderMode, min, max);
-      const width = 100 * (Math.abs(lastValue) / intervalLength);
+      // if both are 0, the division returns NaN causing unexpected behavior.
+      // For this it defaults to 0
+      const width = 100 * (Math.abs(lastValue) / intervalLength) || 0;
 
       const styles = reactcss(
         {

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,9 @@ export class TopN extends Component {`
`110`	`110`	`const isPositiveValue = lastValue >= 0;`
`111`	`111`
`112`	`112`	`const intervalLength = TopN.calcDomain(renderMode, min, max);`
`113`		`- const width = 100 * (Math.abs(lastValue) / intervalLength);`
	`113`	`+ // if both are 0, the division returns NaN causing unexpected behavior.`
	`114`	`+ // For this it defaults to 0`
	`115`	`+ const width = 100 * (Math.abs(lastValue) / intervalLength) \|\| 0;`
`114`	`116`
`115`	`117`	`const styles = reactcss(`
`116`	`118`	`{`