Grouped features for space management

Author: legrego

examples/alerting_example/server/plugin.ts

@@ -19,6 +19,7 @@
 
 import { Plugin, CoreSetup } from 'kibana/server';
 import { i18n } from '@kbn/i18n';
+import { DEFAULT_APP_CATEGORIES } from '../../../src/core/server';
 import { PluginSetupContract as AlertingSetup } from '../../../x-pack/plugins/alerts/server';
 import { PluginSetupContract as FeaturesPluginSetup } from '../../../x-pack/plugins/features/server';
 
@@ -47,6 +48,7 @@ export class AlertingExamplePlugin implements Plugin<void, void, AlertingExample
       management: {
         insightsAndAlerting: ['triggersActions'],
       },
+      category: DEFAULT_APP_CATEGORIES.management,
       alerting: [alwaysFiringAlert.id, peopleInSpaceAlert.id, INDEX_THRESHOLD_ID],
       privileges: {
         all: {

src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap

@@ -477,6 +477,7 @@ export const DEFAULT_APP_CATEGORIES: Readonly<{
         id: string;
         label: string;
         order: number;
+        euiIconType: string;
     };
 }>;
 

src/core/public/public.api.md

@@ -537,6 +537,7 @@ export const DEFAULT_APP_CATEGORIES: Readonly<{
         id: string;
         label: string;
         order: number;
+        euiIconType: string;
     };
 }>;
 

src/core/server/server.api.md

@@ -59,5 +59,6 @@ export const DEFAULT_APP_CATEGORIES = Object.freeze({
       defaultMessage: 'Management',
     }),
     order: 5000,
+    euiIconType: 'managementApp',
   },
 });

src/core/utils/default_app_categories.ts

@@ -6,6 +6,7 @@
 
 import { i18n } from '@kbn/i18n';
 import { ACTION_SAVED_OBJECT_TYPE, ACTION_TASK_PARAMS_SAVED_OBJECT_TYPE } from './saved_objects';
+import { DEFAULT_APP_CATEGORIES } from '../../../../src/core/server';
 
 export const ACTIONS_FEATURE = {
   id: 'actions',
@@ -14,6 +15,7 @@ export const ACTIONS_FEATURE = {
   }),
   icon: 'bell',
   navLinkId: 'actions',
+  category: DEFAULT_APP_CATEGORIES.management,
   app: [],
   management: {
     insightsAndAlerting: ['triggersActions'],

x-pack/plugins/actions/server/feature.ts

@@ -7,6 +7,7 @@
 import { i18n } from '@kbn/i18n';
 import { ID as IndexThreshold } from './alert_types/index_threshold/alert_type';
 import { BUILT_IN_ALERTS_FEATURE_ID } from '../common';
+import { DEFAULT_APP_CATEGORIES } from '../../../../src/core/server';
 
 export const BUILT_IN_ALERTS_FEATURE = {
   id: BUILT_IN_ALERTS_FEATURE_ID,
@@ -15,6 +16,7 @@ export const BUILT_IN_ALERTS_FEATURE = {
   }),
   icon: 'bell',
   app: [],
+  category: DEFAULT_APP_CATEGORIES.management,
   management: {
     insightsAndAlerting: ['triggersActions'],
   },

x-pack/plugins/alerting_builtins/server/feature.ts

@@ -48,6 +48,7 @@ function mockFeature(appName: string, typeName?: string) {
     id: appName,
     name: appName,
     app: [],
+    category: { id: 'foo', label: 'foo' },
     ...(typeName
       ? {
           alerting: [typeName],
@@ -91,6 +92,7 @@ function mockFeatureWithSubFeature(appName: string, typeName: string) {
     id: appName,
     name: appName,
     app: [],
+    category: { id: 'foo', label: 'foo' },
     ...(typeName
       ? {
           alerting: [typeName],

x-pack/plugins/alerts/server/authorization/alerts_authorization.test.ts

@@ -164,6 +164,7 @@ function mockFeatures() {
       id: 'appName',
       name: 'appName',
       app: [],
+      category: { id: 'foo', label: 'foo' },
       privileges: {
         all: {
           savedObject: {

x-pack/plugins/alerts/server/plugin.test.ts

@@ -6,13 +6,15 @@
 
 import { i18n } from '@kbn/i18n';
 import { AlertType } from '../common/alert_types';
+import { DEFAULT_APP_CATEGORIES } from '../../../../src/core/server';
 
 export const APM_FEATURE = {
   id: 'apm',
   name: i18n.translate('xpack.apm.featureRegistry.apmFeatureName', {
     defaultMessage: 'APM',
   }),
   order: 900,
+  category: DEFAULT_APP_CATEGORIES.observability,
   icon: 'apmApp',
   navLinkId: 'apm',
   app: ['apm', 'csm', 'kibana'],