From 843f18de55f78370441ae78cbb3a8c7d62d9aa22 Mon Sep 17 00:00:00 2001 From: Joe Portner <5295965+jportner@users.noreply.github.com> Date: Sat, 15 Feb 2020 14:33:22 -0500 Subject: [PATCH] More PR review feedback --- .../security/public/session/session_expired.test.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/x-pack/plugins/security/public/session/session_expired.test.ts b/x-pack/plugins/security/public/session/session_expired.test.ts index 5d8b5189bef6d3..f5ad9cb464e3e7 100644 --- a/x-pack/plugins/security/public/session/session_expired.test.ts +++ b/x-pack/plugins/security/public/session/session_expired.test.ts @@ -45,14 +45,6 @@ describe('#logout', () => { await expect(newUrlPromise).resolves.toBe(`${LOGOUT_URL}?msg=SESSION_EXPIRED${next}`); }); - it(`checks sessionStorage for the provider name for this tenant`, async () => { - const sessionExpired = new SessionExpired(LOGOUT_URL, TENANT); - sessionExpired.logout(); - - expect(mockGetItem).toHaveBeenCalledTimes(1); - expect(mockGetItem).toHaveBeenCalledWith(`${TENANT}/session_provider`); - }); - it(`adds 'provider' parameter when sessionStorage contains the provider name for this tenant`, async () => { const providerName = 'basic'; mockGetItem.mockReturnValueOnce(providerName); @@ -60,6 +52,9 @@ describe('#logout', () => { const sessionExpired = new SessionExpired(LOGOUT_URL, TENANT); sessionExpired.logout(); + expect(mockGetItem).toHaveBeenCalledTimes(1); + expect(mockGetItem).toHaveBeenCalledWith(`${TENANT}/session_provider`); + const next = `&next=${encodeURIComponent(CURRENT_URL)}`; const provider = `&provider=${providerName}`; await expect(newUrlPromise).resolves.toBe(