Dashboard x pack (#59653)

* feat: 🎸 add dashboard_enhanced plugin to x-pack

* feat: 🎸 improve context menu separator

* feat: 🎸 move drilldown flyout actions to dashboard_enhanced

* fix: 🐛 fix exports from ui_actions plugin

Author: streamich

.github/CODEOWNERS

@@ -3,6 +3,7 @@
 # For more info, see https://help.github.com/articles/about-codeowners/
 
 # App
+/x-pack/legacy/plugins/dashboard_enhanced/ @elastic/kibana-app
 /x-pack/legacy/plugins/lens/ @elastic/kibana-app
 /x-pack/legacy/plugins/graph/ @elastic/kibana-app
 /src/legacy/server/url_shortening/ @elastic/kibana-app

src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.tsx

@@ -18,7 +18,11 @@
  */
 
 import * as React from 'react';
-import { EuiContextMenuPanelDescriptor, EuiContextMenuPanelItemDescriptor } from '@elastic/eui';
+import {
+  EuiContextMenuPanelDescriptor,
+  EuiContextMenuPanelItemDescriptor,
+  EuiHorizontalRule,
+} from '@elastic/eui';
 import _ from 'lodash';
 import { i18n } from '@kbn/i18n';
 import { uiToReactComponent, reactToUiComponent } from '../../../kibana_react/public';
@@ -27,15 +31,7 @@ import { Action, ActionInternal } from '../actions';
 export const contextMenuSeparatorAction = new ActionInternal({
   id: 'CONTEXT_MENU_SEPARATOR',
   getDisplayName: () => 'separator',
-  MenuItem: reactToUiComponent(() => (
-    <div
-      style={{
-        width: '100%',
-        height: '1px',
-        background: 'red',
-      }}
-    />
-  )),
+  MenuItem: reactToUiComponent(() => <EuiHorizontalRule margin={'none'} />),
   execute: () => Promise.resolve(),
 });
 
@@ -117,10 +113,12 @@ function convertPanelActionToContextMenuItem<Context extends object>({
     'data-test-subj': `embeddablePanelAction-${action.id}`,
   };
 
-  menuPanelItem.onClick = () => {
-    action.execute(actionContext);
-    closeMenu();
-  };
+  if (action.id !== 'CONTEXT_MENU_SEPARATOR') {
+    menuPanelItem.onClick = () => {
+      action.execute(actionContext);
+      closeMenu();
+    };
+  }
 
   if (action.getHref) {
     const href = action.getHref(actionContext);

src/plugins/ui_actions/public/index.ts

@@ -35,8 +35,7 @@ export {
   ActionContract as UiActionsActionContract,
 } from './actions';
 export { buildContextMenuForActions, contextMenuSeparatorAction } from './context_menu';
-export { CollectConfigProps, Presentable, Configurable, ConfigurableBaseConfig } from './util';
-export { buildContextMenuForActions } from './context_menu';
+export { CollectConfigProps, Presentable, Configurable } from './util';
 export { Trigger, TriggerContext } from './triggers';
 export { TriggerContextMapping, TriggerId, ActionContextMapping, ActionType } from './types';
 export { ActionByType } from './actions';

x-pack/plugins/dashboard_enhanced/README.md

@@ -0,0 +1 @@
+# X-Pack part of Dashboard app

x-pack/plugins/dashboard_enhanced/kibana.json

@@ -0,0 +1,7 @@
+{
+  "id": "dashboardEnhanced",
+  "version": "kibana",
+  "server": false,
+  "ui": true,
+  "requiredPlugins": ["uiActions", "embeddable", "advancedUiActions", "drilldowns"]
+}

x-pack/plugins/dashboard_enhanced/public/index.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { DashboardEnhancedPlugin } from './plugin';
+
+export {
+  SetupContract as DashboardEnhancedSetupContract,
+  SetupDependencies as DashboardEnhancedSetupDependencies,
+  StartContract as DashboardEnhancedStartContract,
+  StartDependencies as DashboardEnhancedStartDependencies,
+} from './plugin';
+
+export function plugin() {
+  return new DashboardEnhancedPlugin();
+}

x-pack/plugins/dashboard_enhanced/public/mocks.ts

@@ -0,0 +1,27 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { DashboardEnhancedSetupContract, DashboardEnhancedStartContract } from '.';
+
+export type Setup = jest.Mocked<DashboardEnhancedSetupContract>;
+export type Start = jest.Mocked<DashboardEnhancedStartContract>;
+
+const createSetupContract = (): Setup => {
+  const setupContract: Setup = {};
+
+  return setupContract;
+};
+
+const createStartContract = (): Start => {
+  const startContract: Start = {};
+
+  return startContract;
+};
+
+export const dashboardEnhancedPluginMock = {
+  createSetupContract,
+  createStartContract,
+};

x-pack/plugins/dashboard_enhanced/public/plugin.ts

@@ -0,0 +1,40 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { CoreStart, CoreSetup, Plugin } from 'src/core/public';
+import { UiActionsSetup, UiActionsStart } from '../../../../src/plugins/ui_actions/public';
+import { DashboardDrilldownsService } from './services';
+
+export interface SetupDependencies {
+  uiActions: UiActionsSetup;
+}
+
+export interface StartDependencies {
+  uiActions: UiActionsStart;
+}
+
+// eslint-disable-next-line
+export interface SetupContract {}
+
+// eslint-disable-next-line
+export interface StartContract {}
+
+export class DashboardEnhancedPlugin
+  implements Plugin<SetupContract, StartContract, SetupDependencies, StartDependencies> {
+  public readonly drilldowns = new DashboardDrilldownsService();
+
+  public setup(core: CoreSetup, plugins: SetupDependencies): SetupContract {
+    this.drilldowns.bootstrap(core, plugins);
+
+    return {};
+  }
+
+  public start(core: CoreStart, plugins: StartDependencies): StartContract {
+    return {};
+  }
+
+  public stop() {}
+}

x-pack/plugins/drilldowns/public/actions/flyout_create_drilldown/index.tsx renamed to x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/index.tsx

@@ -7,11 +7,11 @@
 import React from 'react';
 import { i18n } from '@kbn/i18n';
 import { CoreStart } from 'src/core/public';
-import { ActionByType } from '../../../../../../src/plugins/ui_actions/public';
-import { toMountPoint } from '../../../../../../src/plugins/kibana_react/public';
-import { IEmbeddable } from '../../../../../../src/plugins/embeddable/public';
-import { FlyoutDrilldownWizard } from '../../components/flyout_drilldown_wizard';
-import { ActionFactory } from '../../../../advanced_ui_actions/public';
+import { ActionByType } from '../../../../../../../../src/plugins/ui_actions/public';
+import { toMountPoint } from '../../../../../../../../src/plugins/kibana_react/public';
+import { IEmbeddable } from '../../../../../../../../src/plugins/embeddable/public';
+
+const FlyoutDrilldownWizard: React.FC<{ onClose: any }> = () => <div>FormDrilldownWizard</div>;
 
 export const OPEN_FLYOUT_ADD_DRILLDOWN = 'OPEN_FLYOUT_ADD_DRILLDOWN';
 
@@ -21,7 +21,6 @@ export interface FlyoutCreateDrilldownActionContext {
 
 export interface OpenFlyoutAddDrilldownParams {
   overlays: () => Promise<CoreStart['overlays']>;
-  getDrilldownActionFactories: () => Array<ActionFactory<any>>;
 }
 
 export class FlyoutCreateDrilldownAction implements ActionByType<typeof OPEN_FLYOUT_ADD_DRILLDOWN> {
@@ -48,18 +47,20 @@ export class FlyoutCreateDrilldownAction implements ActionByType<typeof OPEN_FLY
   public async execute(context: FlyoutCreateDrilldownActionContext) {
     const overlays = await this.params.overlays();
 
+    /*
     const drilldownActionFactories = this.params.getDrilldownActionFactories();
     const compatibleDrilldownActionFactories = await Promise.all(
       drilldownActionFactories.map(factory => factory.isCompatible(context))
     ).then(compatibilityList =>
       drilldownActionFactories.filter((factory, index) => compatibilityList[index])
     );
+    */
 
     const handle = overlays.openFlyout(
       toMountPoint(
         <FlyoutDrilldownWizard
           onClose={() => handle.close()}
-          drilldownActionFactories={compatibleDrilldownActionFactories}
+          // drilldownActionFactories={compatibleDrilldownActionFactories}
         />
       )
     );

x-pack/plugins/drilldowns/public/actions/flyout_edit_drilldown/index.tsx renamed to x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/index.tsx

@@ -8,16 +8,19 @@ import React from 'react';
 import { i18n } from '@kbn/i18n';
 import { CoreStart } from 'src/core/public';
 import { EuiNotificationBadge } from '@elastic/eui';
-import { ActionByType } from '../../../../../../src/plugins/ui_actions/public';
+import { ActionByType } from '../../../../../../../../src/plugins/ui_actions/public';
 import {
   reactToUiComponent,
   toMountPoint,
-} from '../../../../../../src/plugins/kibana_react/public';
-import { IEmbeddable } from '../../../../../../src/plugins/embeddable/public';
-import { FlyoutManageDrilldowns } from '../../components/flyout_manage_drilldowns';
-// TODO: MOCK DATA
-import { drilldowns } from '../../components/list_manage_drilldowns/test_data';
-import { ActionFactory } from '../../../../advanced_ui_actions/public';
+} from '../../../../../../../../src/plugins/kibana_react/public';
+import { IEmbeddable } from '../../../../../../../../src/plugins/embeddable/public';
+
+const FlyoutManageDrilldowns: React.FC<{ onClose: () => {} }> = () => (
+  <div>FormDrilldownWizard</div>
+);
+
+// Mock data
+const drilldowns: any = [];
 
 export const OPEN_FLYOUT_EDIT_DRILLDOWN = 'OPEN_FLYOUT_EDIT_DRILLDOWN';
 
@@ -27,7 +30,6 @@ export interface FlyoutEditDrilldownActionContext {
 
 export interface FlyoutEditDrilldownParams {
   overlays: () => Promise<CoreStart['overlays']>;
-  getDrilldownActionFactories: () => Array<ActionFactory<any>>;
 }
 
 const displayName = i18n.translate('xpack.drilldowns.panel.openFlyoutEditDrilldown.displayName', {
@@ -69,21 +71,8 @@ export class FlyoutEditDrilldownAction implements ActionByType<typeof OPEN_FLYOU
   public async execute(context: FlyoutEditDrilldownActionContext) {
     const overlays = await this.params.overlays();
 
-    const drilldownActionFactories = this.params.getDrilldownActionFactories();
-    const compatibleDrilldownActionFactories = await Promise.all(
-      drilldownActionFactories.map(factory => factory.isCompatible(context))
-    ).then(compatibilityList =>
-      drilldownActionFactories.filter((factory, index) => compatibilityList[index])
-    );
-
     const handle = overlays.openFlyout(
-      toMountPoint(
-        <FlyoutManageDrilldowns
-          onClose={() => handle.close()}
-          drilldowns={drilldowns}
-          drilldownActionFactories={compatibleDrilldownActionFactories}
-        />
-      )
+      toMountPoint(<FlyoutManageDrilldowns onClose={() => handle.close()} />)
     );
   }
 }