Skip to content

Commit 7d5cdf2

Browse files
committed
Add config to toggle new vislib replacement
1 parent 1729f31 commit 7d5cdf2

File tree

1 file changed

+22
-12
lines changed
  • src/legacy/core_plugins/vis_type_vislib/public

1 file changed

+22
-12
lines changed

src/legacy/core_plugins/vis_type_vislib/public/plugin.ts

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import {
3939
createGoalVisTypeDefinition,
4040
} from './vis_type_vislib_vis_types';
4141
import { ChartsPluginSetup } from '../../../../plugins/charts/public';
42+
import { ConfigShema as VisTypeXyConfigShema } from '../../vis_type_xy';
4243

4344
export interface VisTypeVislibDependencies {
4445
uiSettings: IUiSettingsClient;
@@ -73,19 +74,28 @@ export class VisTypeVislibPlugin implements Plugin<Promise<void>, void> {
7374
charts,
7475
};
7576

76-
expressions.registerFunction(createVisTypeVislibVisFn);
77-
expressions.registerFunction(createPieVisFn);
77+
const visTypeXy = core.injectedMetadata.getInjectedVar('visTypeXy') as
78+
| VisTypeXyConfigShema['visTypeXy']
79+
| undefined;
7880

79-
[
80-
createHistogramVisTypeDefinition,
81-
createLineVisTypeDefinition,
82-
createPieVisTypeDefinition,
83-
createAreaVisTypeDefinition,
84-
createHeatmapVisTypeDefinition,
85-
createHorizontalBarVisTypeDefinition,
86-
createGaugeVisTypeDefinition,
87-
createGoalVisTypeDefinition,
88-
].forEach(vis => visualizations.types.createBaseVisualization(vis(visualizationDependencies)));
81+
// if visTypeXy plugin is disabled it's config will be undefined
82+
if (!visTypeXy || !visTypeXy.enabled) {
83+
expressions.registerFunction(createVisTypeVislibVisFn);
84+
expressions.registerFunction(createPieVisFn);
85+
86+
[
87+
createHistogramVisTypeDefinition,
88+
createLineVisTypeDefinition,
89+
createPieVisTypeDefinition,
90+
createAreaVisTypeDefinition,
91+
createHeatmapVisTypeDefinition,
92+
createHorizontalBarVisTypeDefinition,
93+
createGaugeVisTypeDefinition,
94+
createGoalVisTypeDefinition,
95+
].forEach(vis =>
96+
visualizations.types.createBaseVisualization(vis(visualizationDependencies))
97+
);
98+
}
8999
}
90100

91101
public start(core: CoreStart, deps: VisTypeVislibPluginStartDependencies) {

0 commit comments

Comments
 (0)