Update (de)serializer to use global repo value

Author: sebelga

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx

@@ -164,7 +164,7 @@ export const SearchableSnapshotField: FunctionComponent<Props> = ({ phase }) =>
           <div className="ilmSearchableSnapshotField">
             <UseField
               path={searchableSnapshotRepoPath}
-              defaultValue={[searchableSnapshotGlobalRepo]}
+              defaultValue={!!searchableSnapshotGlobalRepo ? [searchableSnapshotGlobalRepo] : []}
               component={RepositoryComboBoxField}
               componentProps={{
                 globalRepository: searchableSnapshotGlobalRepo,

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx

@@ -30,7 +30,7 @@ import {
   EuiTitle,
 } from '@elastic/eui';
 
-import { TextField, useForm, useFormData } from '../../../shared_imports';
+import { TextField, useForm, useFormData, useKibana } from '../../../shared_imports';
 import { toasts } from '../../services/notification';
 import { createDocLink } from '../../services/documentation';
 import { UseField } from './form';
@@ -44,7 +44,13 @@ import {
   Timeline,
   FormErrorsCallout,
 } from './components';
-import { createPolicyNameValidations, createSerializer, deserializer, Form, schema } from './form';
+import {
+  createPolicyNameValidations,
+  createSerializer,
+  deserializer,
+  Form,
+  getSchema,
+} from './form';
 import { useEditPolicyContext } from './edit_policy_context';
 import { FormInternal } from './types';
 
@@ -67,6 +73,10 @@ export const EditPolicy: React.FunctionComponent<Props> = ({ history }) => {
     policyName,
   } = useEditPolicyContext();
 
+  const {
+    services: { cloud },
+  } = useKibana();
+
   const [saveAsNew, setSaveAsNew] = useState(false);
   const originalPolicyName: string = isNewPolicy ? '' : policyName!;
 
@@ -82,6 +92,10 @@ export const EditPolicy: React.FunctionComponent<Props> = ({ history }) => {
     [currentPolicy, originalPolicyName]
   );
 
+  const schema = useMemo(() => {
+    return getSchema(Boolean(cloud?.isCloudEnabled));
+  }, [cloud?.isCloudEnabled]);
+
   const { form } = useForm({
     schema,
     defaultValue,

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/deserializer.ts

@@ -8,18 +8,21 @@
 import { produce } from 'immer';
 
 import { SerializedPolicy } from '../../../../../common/types';
-
 import { splitSizeAndUnits } from '../../../lib/policies';
-
 import { determineDataTierAllocationType, isUsingDefaultRollover } from '../../../lib';
-
+import { getDefaultRepository } from '../lib';
 import { FormInternal } from '../types';
 
 export const deserializer = (policy: SerializedPolicy): FormInternal => {
   const {
     phases: { hot, warm, cold, delete: deletePhase },
   } = policy;
 
+  const defaultRepository = getDefaultRepository([
+    hot?.actions.searchable_snapshot,
+    cold?.actions.searchable_snapshot,
+  ]);
+
   const _meta: FormInternal['_meta'] = {
     hot: {
       isUsingDefaultRollover: isUsingDefaultRollover(policy),
@@ -44,6 +47,9 @@ export const deserializer = (policy: SerializedPolicy): FormInternal => {
     delete: {
       enabled: Boolean(deletePhase),
     },
+    searchableSnapshot: {
+      repository: defaultRepository,
+    },
   };
 
   return produce<FormInternal>(

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/index.ts

@@ -9,7 +9,7 @@ export { deserializer } from './deserializer';
 
 export { createSerializer } from './serializer';
 
-export { schema } from './schema';
+export { getSchema } from './schema';
 
 export * from './validations';
 

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts

@@ -10,17 +10,21 @@ import { i18n } from '@kbn/i18n';
 import { FormSchema, fieldValidators } from '../../../../shared_imports';
 import { defaultIndexPriority } from '../../../constants';
 import { ROLLOVER_FORM_PATHS } from '../constants';
-
-const rolloverFormPaths = Object.values(ROLLOVER_FORM_PATHS);
-
+import { i18nTexts } from '../i18n_texts';
 import {
   ifExistsNumberGreaterThanZero,
   ifExistsNumberNonNegative,
   rolloverThresholdsValidator,
   minAgeValidator,
 } from './validations';
 
-import { i18nTexts } from '../i18n_texts';
+const rolloverFormPaths = Object.values(ROLLOVER_FORM_PATHS);
+
+/**
+ * This repository is provisioned by Elastic Cloud and will always
+ * exist as a "managed" repository.
+ */
+const CLOUD_DEFAULT_REPO = 'found-snapshots';
 
 const { emptyField, numberGreaterThanField } = fieldValidators;
 
@@ -34,11 +38,10 @@ const searchableSnapshotFields = {
     validations: [
       { validator: emptyField(i18nTexts.editPolicy.errors.searchableSnapshotRepoRequired) },
     ],
-    defaultValue: [],
   },
 };
 
-export const schema: FormSchema = {
+export const getSchema = (isCloudEnabled: boolean): FormSchema => ({
   _meta: {
     hot: {
       isUsingDefaultRollover: {
@@ -130,6 +133,11 @@ export const schema: FormSchema = {
         defaultValue: 'd',
       },
     },
+    searchableSnapshot: {
+      repository: {
+        defaultValue: isCloudEnabled ? CLOUD_DEFAULT_REPO : '',
+      },
+    },
   },
   phases: {
     hot: {
@@ -377,4 +385,4 @@ export const schema: FormSchema = {
       },
     },
   },
-};
+});

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/serializer/serializer.ts

@@ -124,7 +124,12 @@ export const createSerializer = (originalPolicy?: SerializedPolicy) => (
       /**
        * HOT PHASE SEARCHABLE SNAPSHOT
        */
-      if (!updatedPolicy.phases.hot!.actions?.searchable_snapshot) {
+      if (updatedPolicy.phases.hot!.actions?.searchable_snapshot) {
+        hotPhaseActions.searchable_snapshot = {
+          ...hotPhaseActions.searchable_snapshot,
+          snapshot_repository: _meta.searchableSnapshot.repository,
+        };
+      } else {
         delete hotPhaseActions.searchable_snapshot;
       }
     }
@@ -234,7 +239,12 @@ export const createSerializer = (originalPolicy?: SerializedPolicy) => (
       /**
        * COLD PHASE SEARCHABLE SNAPSHOT
        */
-      if (!updatedPolicy.phases.cold?.actions?.searchable_snapshot) {
+      if (updatedPolicy.phases.cold?.actions?.searchable_snapshot) {
+        coldPhase.actions.searchable_snapshot = {
+          ...coldPhase.actions.searchable_snapshot,
+          snapshot_repository: _meta.searchableSnapshot.repository,
+        };
+      } else {
         delete coldPhase.actions.searchable_snapshot;
       }
     } else {
@@ -254,7 +264,7 @@ export const createSerializer = (originalPolicy?: SerializedPolicy) => (
       deletePhase.actions.delete = deletePhase.actions.delete ?? {};
 
       /**
-       * DELETE PHASE SEARCHABLE SNAPSHOT
+       * DELETE PHASE MIN AGE
        */
       if (updatedPolicy.phases.delete?.min_age) {
         deletePhase.min_age = `${updatedPolicy.phases.delete!.min_age}${_meta.delete.minAgeUnit}`;

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/get_default_repository.ts

@@ -0,0 +1,20 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { SearchableSnapshotAction } from '../../../../../common/types';
+
+export const getDefaultRepository = (
+  configs: Array<SearchableSnapshotAction | undefined>
+): string => {
+  if (configs.length === 0) {
+    return '';
+  }
+  if (Boolean(configs[0]?.snapshot_repository)) {
+    return configs[0]!.snapshot_repository;
+  }
+  return getDefaultRepository(configs.slice(1));
+};

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/index.ts

@@ -12,3 +12,5 @@ export {
   PhaseAgeInMilliseconds,
   RelativePhaseTimingInMs,
 } from './absolute_timing_to_relative_timing';
+
+export { getDefaultRepository } from './get_default_repository';