changed showCredentialsForm logic

It now properly resets activeApiTokenRawName, which was not being
reset to the default when the credentials form was opened.

Author: JasonStoltz

x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts

@@ -896,7 +896,9 @@ describe('CredentialsLogic', () => {
 
       describe('activeApiTokenRawName', () => {
         it('should set `activeApiTokenRawName` to the name of the provided token', () => {
-          mount();
+          mount({
+            activeApiTokenRawName: 'Some Name',
+          });
 
           CredentialsLogic.actions.showCredentialsForm(newToken);
           expect(CredentialsLogic.values).toEqual({
@@ -906,26 +908,16 @@ describe('CredentialsLogic', () => {
         });
 
         it('should set `activeApiTokenRawName` to the default value if no token is provided', () => {
-          mount();
+          mount({
+            activeApiTokenRawName: 'Some Name',
+          });
 
           CredentialsLogic.actions.showCredentialsForm();
           expect(CredentialsLogic.values).toEqual({
             ...values,
             activeApiTokenRawName: DEFAULT_VALUES.activeApiTokenRawName,
           });
         });
-
-        // TODO: This fails, is this an issue? Instead of reseting back to the default value, it sets it to the previously
-        // used value... to be honest, this should probably just be a selector
-        // it('should set `activeApiTokenRawName` back to the default value if no token is provided', () => {
-        //   mount();
-        //   CredentialsLogic.actions.showCredentialsForm(newToken);
-        //   CredentialsLogic.actions.showCredentialsForm();
-        //   expect(CredentialsLogic.values).toEqual({
-        //     ...values,
-        //     activeApiTokenRawName: DEFAULT_VALUES.activeApiTokenRawName,
-        // });
-        // });
       });
 
       describe('activeApiToken', () => {

x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_logic.ts

@@ -182,8 +182,7 @@ export const CredentialsLogic = kea<
       '',
       {
         setTokenName: (_, activeApiTokenRawName) => activeApiTokenRawName,
-        showCredentialsForm: (activeApiTokenRawName, activeApiToken) =>
-          activeApiToken.name || activeApiTokenRawName,
+        showCredentialsForm: (_, activeApiToken) => activeApiToken.name,
         hideCredentialsForm: () => '',
         onApiTokenCreateSuccess: () => '',
         onApiTokenUpdateSuccess: () => '',