Code cleanups

Author: kertal

src/legacy/ui/public/notify/fatal_error.ts

@@ -18,23 +18,8 @@
  */
 
 import { npSetup } from 'ui/new_platform';
-import {
-  AngularHttpError,
-  formatAngularHttpError,
-  isAngularHttpError,
-} from '../../../../plugins/kibana_legacy/public';
-
-export function addFatalErrorCallback(callback: () => void) {
-  npSetup.core.fatalErrors.get$().subscribe(() => {
-    callback();
-  });
-}
+import { AngularHttpError, addFatalError } from '../../../../plugins/kibana_legacy/public';
 
 export function fatalError(error: AngularHttpError | Error | string, location?: string) {
-  // add support for angular http errors to newPlatformFatalErrors
-  if (isAngularHttpError(error)) {
-    error = formatAngularHttpError(error);
-  }
-
-  npSetup.core.fatalErrors.add(error, location);
+  addFatalError(npSetup.core.fatalErrors, error, location);
 }

src/legacy/ui/public/notify/index.js

@@ -17,6 +17,6 @@
  * under the License.
  */
 
-export { fatalError, addFatalErrorCallback } from './fatal_error';
+export { fatalError } from './fatal_error';
 export { toastNotifications } from './toasts';
 export { banners } from './banners';

src/plugins/kibana_legacy/public/notify/lib/add_fatal_error.ts

@@ -23,12 +23,6 @@ import {
   isAngularHttpError,
 } from './format_angular_http_error';
 
-export function addFatalErrorCallback(fatalErrors: FatalErrorsSetup, callback: () => void) {
-  fatalErrors.get$().subscribe(() => {
-    callback();
-  });
-}
-
 export function addFatalError(
   fatalErrors: FatalErrorsSetup,
   error: AngularHttpError | Error | string,