From 6ba1b3d9460f4943d18e7dc2b9fe7abc61910bf7 Mon Sep 17 00:00:00 2001 From: monfera Date: Tue, 5 Mar 2019 17:04:48 +0100 Subject: [PATCH] Fix: remove selection in Redux too (PR feedback from Joe) --- .../plugins/canvas/public/state/middleware/aeroelastic.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/canvas/public/state/middleware/aeroelastic.js b/x-pack/plugins/canvas/public/state/middleware/aeroelastic.js index be2510681975bf..59ae1a9fe382b3 100644 --- a/x-pack/plugins/canvas/public/state/middleware/aeroelastic.js +++ b/x-pack/plugins/canvas/public/state/middleware/aeroelastic.js @@ -323,7 +323,11 @@ export const aeroelastic = ({ dispatch, getState }) => { } if (pageChangerActions.indexOf(action.type) >= 0) { - unselectShape(prevPage); + if (getSelectedElement(getState())) { + dispatch(selectElement(null)); // ensure sidebar etc. get updated; will update the layout engine too + } else { + unselectShape(prevPage); // deselect persistent groups as they're not currently selections in Redux + } } next(action);