[Watcher] Move out of legacy (#54752) (#55713)

* Moved out of legacy folder

* First iteration of watcher plugin that renders

* Move create Timebuckets to plugin root
Update route registration and fix license checking for NP

* Re-enable Component integration tests

* Minor fix for data deserializer in api.ts

* Slight logic refactor, more defensive plugin startup

* Re-add legacy folder for SCSS pipeline

* Remove duplicate style sheet

* Fix type issue with TimeBuckets export

* Update license management routing logic (issued warning for using basepath on navigating away from license management)
Remove commented out code in watcher

* More defensive plugin registration

* Fix i18n issues and restore registration of feature on home view

* Remove watcher license error check copy

* Restore license error message in watcher

* Fix mock context value

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/legacy/plugins/watcher/public/7_x_only.ts
#	x-pack/plugins/watcher/public/application/boot.tsx

Author: jloleysens

x-pack/.i18nrc.json

@@ -39,7 +39,7 @@
     "xpack.transform": "legacy/plugins/transform",
     "xpack.upgradeAssistant": "legacy/plugins/upgrade_assistant",
     "xpack.uptime": "legacy/plugins/uptime",
-    "xpack.watcher": "legacy/plugins/watcher"
+    "xpack.watcher": "plugins/watcher"
   },
   "translations": [
     "plugins/translations/translations/zh-CN.json",

x-pack/dev-tools/jest/create_jest_config.js

@@ -21,7 +21,6 @@ export function createJestConfig({ kibanaDirectory, xPackKibanaDirectory }) {
       'uiExports/(.*)': fileMockPath,
       '^src/core/(.*)': `${kibanaDirectory}/src/core/$1`,
       '^src/legacy/(.*)': `${kibanaDirectory}/src/legacy/$1`,
-      '^plugins/watcher/np_ready/application/models/(.*)': `${xPackKibanaDirectory}/legacy/plugins/watcher/public/np_ready/application/models/$1`,
       '^plugins/([^/.]*)(.*)': `${kibanaDirectory}/src/legacy/core_plugins/$1/public$2`,
       '^plugins/xpack_main/(.*);': `${xPackKibanaDirectory}/legacy/plugins/xpack_main/public/$1`,
       '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': fileMockPath,

x-pack/legacy/plugins/license_management/public/np_ready/application/app.js

@@ -8,7 +8,7 @@ import React, { Component } from 'react';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { LicenseDashboard, UploadLicense } from './sections';
 import { Switch, Route } from 'react-router-dom';
-import { APP_PERMISSION } from '../../../common/constants';
+import { APP_PERMISSION, BASE_PATH } from '../../../common/constants';
 import { EuiPageBody, EuiEmptyPrompt, EuiText, EuiLoadingSpinner, EuiCallOut } from '@elastic/eui';
 
 export class App extends Component {
@@ -88,10 +88,8 @@ export class App extends Component {
     return (
       <EuiPageBody>
         <Switch>
-          <Route path={`/upload_license`} component={UploadLicense} />
-
-          {/* Match all */}
-          <Route component={LicenseDashboard} />
+          <Route path={`${BASE_PATH}upload_license`} component={UploadLicense} />
+          <Route path={BASE_PATH} component={LicenseDashboard} />
         </Switch>
       </EuiPageBody>
     );

x-pack/legacy/plugins/license_management/public/np_ready/application/boot.tsx

@@ -63,7 +63,7 @@ export const boot = (deps: AppDependencies) => {
   render(
     <I18nContext>
       <Provider store={store}>
-        <HashRouter basename={BASE_PATH}>
+        <HashRouter>
           <App />
         </HashRouter>
       </Provider>

x-pack/legacy/plugins/license_management/public/np_ready/application/sections/license_dashboard/license_dashboard.js

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import React from 'react';
-
+import React, { useEffect } from 'react';
 import { LicenseStatus } from './license_status';
 import { RevertToBasic } from './revert_to_basic';
 import { StartTrial } from './start_trial';
@@ -14,7 +13,10 @@ import { RequestTrialExtension } from './request_trial_extension';
 import { EuiFlexGroup, EuiFlexItem, EuiSpacer } from '@elastic/eui';
 
 export const LicenseDashboard = ({ setBreadcrumb } = { setBreadcrumb: () => {} }) => {
-  setBreadcrumb('dashboard');
+  useEffect(() => {
+    setBreadcrumb('dashboard');
+  });
+
   return (
     <div>
       <LicenseStatus />

x-pack/legacy/plugins/watcher/index.ts

@@ -0,0 +1,19 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+import { resolve } from 'path';
+
+const pluginDefinition = {
+  id: 'watcher',
+  configPrefix: 'xpack.watcher',
+  publicDir: resolve(__dirname, 'public'),
+  require: ['kibana'],
+  uiExports: {
+    styleSheetPaths: resolve(__dirname, 'public/index.scss'),
+  },
+  init(server: any) {},
+};
+
+export const watcher = (kibana: any) => new kibana.Plugin(pluginDefinition);