Skip to content

Commit 6921451

Browse files
Merge branch 'master' into 73848-saved-object-mapping-clean
2 parents 9884147 + 5161049 commit 6921451

File tree

2,545 files changed

+77256
-72962
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,545 files changed

+77256
-72962
lines changed

.ci/end2end.groovy

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,22 +37,31 @@ pipeline {
3737
deleteDir()
3838
gitCheckout(basedir: "${BASE_DIR}", githubNotifyFirstTimeContributor: false,
3939
shallow: false, reference: "/var/lib/jenkins/.git-references/kibana.git")
40+
41+
// Filter when to run based on the below reasons:
42+
// - On a PRs when:
43+
// - There are changes related to the APM UI project
44+
// - only when the owners of those changes are members of the given GitHub teams
45+
// - On merges to branches when:
46+
// - There are changes related to the APM UI project
47+
// - FORCE parameter is set to true.
4048
script {
49+
def apm_updated = false
4150
dir("${BASE_DIR}"){
42-
def regexps =[ "^x-pack/plugins/apm/.*" ]
43-
env.APM_UPDATED = isGitRegionMatch(patterns: regexps)
51+
apm_updated = isGitRegionMatch(patterns: [ "^x-pack/plugins/apm/.*" ])
52+
}
53+
if (isPR()) {
54+
def isMember = isMemberOf(user: env.CHANGE_AUTHOR, team: ['apm-ui', 'uptime'])
55+
setEnvVar('RUN_APM_E2E', params.FORCE || (apm_updated && isMember))
56+
} else {
57+
setEnvVar('RUN_APM_E2E', params.FORCE || apm_updated)
4458
}
4559
}
4660
}
4761
}
4862
stage('Prepare Kibana') {
4963
options { skipDefaultCheckout() }
50-
when {
51-
anyOf {
52-
expression { return params.FORCE }
53-
expression { return env.APM_UPDATED != "false" }
54-
}
55-
}
64+
when { expression { return env.RUN_APM_E2E != "false" } }
5665
environment {
5766
JENKINS_NODE_COOKIE = 'dontKillMe'
5867
}
@@ -70,12 +79,7 @@ pipeline {
7079
}
7180
stage('Smoke Tests'){
7281
options { skipDefaultCheckout() }
73-
when {
74-
anyOf {
75-
expression { return params.FORCE }
76-
expression { return env.APM_UPDATED != "false" }
77-
}
78-
}
82+
when { expression { return env.RUN_APM_E2E != "false" } }
7983
steps{
8084
notifyTestStatus('Running smoke tests', 'PENDING')
8185
dir("${BASE_DIR}"){

.github/CODEOWNERS

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,12 @@
6464
/src/apm.js @watson @vigneshshanmugam
6565

6666
# Client Side Monitoring (lives in APM directories but owned by Uptime)
67-
/x-pack/plugins/apm/e2e/cypress/support/step_definitions/rum @elastic/uptime
67+
/x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm @elastic/uptime
6868
/x-pack/plugins/apm/public/application/csmApp.tsx @elastic/uptime
6969
/x-pack/plugins/apm/public/components/app/RumDashboard @elastic/uptime
7070
/x-pack/plugins/apm/server/lib/rum_client @elastic/uptime
7171
/x-pack/plugins/apm/server/routes/rum_client.ts @elastic/uptime
72+
/x-pack/plugins/apm/server/projections/rum_overview.ts @elastic/uptime
7273

7374
# Beats
7475
/x-pack/legacy/plugins/beats_management/ @elastic/beats
@@ -85,6 +86,7 @@
8586
# Exclude tutorial resources folder for now because they are not owned by Kibana app and most will move out soon
8687
/src/legacy/core_plugins/kibana/public/home/*.ts @elastic/kibana-core-ui
8788
/src/legacy/core_plugins/kibana/public/home/np_ready/ @elastic/kibana-core-ui
89+
/x-pack/plugins/global_search_bar/ @elastic/kibana-core-ui
8890

8991
# Observability UIs
9092
/x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui
@@ -152,6 +154,7 @@
152154
/x-pack/plugins/cloud/ @elastic/kibana-platform
153155
/x-pack/test/saved_objects_field_count/ @elastic/kibana-platform
154156
/packages/kbn-config-schema/ @elastic/kibana-platform
157+
/packages/kbn-std/ @elastic/kibana-platform
155158
/src/legacy/server/config/ @elastic/kibana-platform
156159
/src/legacy/server/http/ @elastic/kibana-platform
157160
/src/legacy/server/logging/ @elastic/kibana-platform
@@ -169,6 +172,7 @@
169172
/x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security
170173
/x-pack/plugins/security/ @elastic/kibana-security
171174
/x-pack/test/api_integration/apis/security/ @elastic/kibana-security
175+
/x-pack/test/ui_capabilities/ @elastic/kibana-security
172176
/x-pack/test/encrypted_saved_objects_api_integration/ @elastic/kibana-security
173177
/x-pack/test/functional/apps/security/ @elastic/kibana-security
174178
/x-pack/test/kerberos_api_integration/ @elastic/kibana-security
@@ -292,6 +296,7 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
292296
/x-pack/plugins/infra/**/*.scss @elastic/observability-design
293297
/x-pack/plugins/ingest_manager/**/*.scss @elastic/observability-design
294298
/x-pack/plugins/observability/**/*.scss @elastic/observability-design
299+
/x-pack/plugins/monitoring/**/*.scss @elastic/observability-design
295300

296301
# Ent. Search design
297302
/x-pack/plugins/enterprise_search/**/*.scss @elastic/ent-search-design

.github/ISSUE_TEMPLATE/APM.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name: APM Issue
33
about: Issues related to the APM solution in Kibana
44
labels: Team:apm
5-
title: [APM]
5+
title: "[APM]"
66
---
77

88
**Versions**

docs/apm/troubleshooting.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ GET /_template/apm-{version}
4949
*Using Logstash, Kafka, etc.*
5050
If you're not outputting data directly from APM Server to Elasticsearch (perhaps you're using Logstash or Kafka),
5151
then the index template will not be set up automatically. Instead, you'll need to
52-
{apm-server-ref}/_manually_loading_template_configuration.html[load the template manually].
52+
{apm-server-ref}/configuration-template.html[load the template manually].
5353

5454
*Using a custom index names*
5555
This problem can also occur if you've customized the index name that you write APM data to.

0 commit comments

Comments
 (0)