add tests for audit logging deprecations

Author: mshustov

x-pack/plugins/security/server/config_deprecations.test.ts

@@ -52,6 +52,117 @@ describe('Config Deprecations', () => {
     `);
   });
 
+  it('renames audit.appender.kind to audit.appender.type', () => {
+    const config = {
+      xpack: {
+        security: {
+          audit: {
+            appender: {
+              kind: 'console',
+            },
+          },
+        },
+      },
+    };
+    const { messages, migrated } = applyConfigDeprecations(cloneDeep(config));
+    expect(migrated.xpack.security.audit.appender.kind).not.toBeDefined();
+    expect(migrated.xpack.security.audit.appender.type).toEqual('console');
+    expect(messages).toMatchInlineSnapshot(`
+      Array [
+        "\\"xpack.security.audit.appender.kind\\" is deprecated and has been replaced by \\"xpack.security.audit.appender.type\\"",
+      ]
+    `);
+  });
+
+  it('renames audit.appender.layout.kind to audit.appender.layout.type', () => {
+    const config = {
+      xpack: {
+        security: {
+          audit: {
+            appender: {
+              layout: { kind: 'pattern' },
+            },
+          },
+        },
+      },
+    };
+    const { messages, migrated } = applyConfigDeprecations(cloneDeep(config));
+    expect(migrated.xpack.security.audit.appender.layout.kind).not.toBeDefined();
+    expect(migrated.xpack.security.audit.appender.layout.type).toEqual('pattern');
+    expect(messages).toMatchInlineSnapshot(`
+      Array [
+        "\\"xpack.security.audit.appender.layout.kind\\" is deprecated and has been replaced by \\"xpack.security.audit.appender.layout.type\\"",
+      ]
+    `);
+  });
+
+  it('renames audit.appender.policy.kind to audit.appender.policy.type', () => {
+    const config = {
+      xpack: {
+        security: {
+          audit: {
+            appender: {
+              policy: { kind: 'time-interval' },
+            },
+          },
+        },
+      },
+    };
+    const { messages, migrated } = applyConfigDeprecations(cloneDeep(config));
+    expect(migrated.xpack.security.audit.appender.policy.kind).not.toBeDefined();
+    expect(migrated.xpack.security.audit.appender.policy.type).toEqual('time-interval');
+    expect(messages).toMatchInlineSnapshot(`
+      Array [
+        "\\"xpack.security.audit.appender.policy.kind\\" is deprecated and has been replaced by \\"xpack.security.audit.appender.policy.type\\"",
+      ]
+    `);
+  });
+
+  it('renames audit.appender.policy.kind to audit.appender.policy.type', () => {
+    const config = {
+      xpack: {
+        security: {
+          audit: {
+            appender: {
+              strategy: { kind: 'numeric' },
+            },
+          },
+        },
+      },
+    };
+    const { messages, migrated } = applyConfigDeprecations(cloneDeep(config));
+    expect(migrated.xpack.security.audit.appender.strategy.kind).not.toBeDefined();
+    expect(migrated.xpack.security.audit.appender.strategy.type).toEqual('numeric');
+    expect(messages).toMatchInlineSnapshot(`
+      Array [
+        "\\"xpack.security.audit.appender.strategy.kind\\" is deprecated and has been replaced by \\"xpack.security.audit.appender.strategy.type\\"",
+      ]
+    `);
+  });
+
+  it('renames audit.appender.path to audit.appender.fileName', () => {
+    const config = {
+      xpack: {
+        security: {
+          audit: {
+            appender: {
+              type: 'file',
+              path: './audit.log',
+            },
+          },
+        },
+      },
+    };
+    const { messages, migrated } = applyConfigDeprecations(cloneDeep(config));
+    expect(migrated.xpack.security.audit.appender.path).not.toBeDefined();
+    expect(migrated.xpack.security.audit.appender.fileName).toEqual('./audit.log');
+    expect(messages).toMatchInlineSnapshot(`
+      Array [
+        "\\"xpack.security.audit.appender.path\\" is deprecated and has been replaced by \\"xpack.security.audit.appender.fileName\\"",
+      ]
+    `);
+  });
+
   it(`warns that 'authorization.legacyFallback.enabled' is unused`, () => {
     const config = {
       xpack: {

x-pack/plugins/security/server/config_deprecations.ts

@@ -14,10 +14,10 @@ export const securityConfigDeprecationProvider: ConfigDeprecationProvider = ({
   rename('sessionTimeout', 'session.idleTimeout'),
 
   rename('audit.appender.kind', 'audit.appender.type'),
-  rename('audit.appender.path', 'audit.appender.fileName'),
   rename('audit.appender.layout.kind', 'audit.appender.layout.type'),
   rename('audit.appender.policy.kind', 'audit.appender.policy.type'),
   rename('audit.appender.strategy.kind', 'audit.appender.strategy.type'),
+  rename('audit.appender.path', 'audit.appender.fileName'),
 
   unused('authorization.legacyFallback.enabled'),
   unused('authc.saml.maxRedirectURLSize'),