Fix eslint warnings

Author: sulemanof

src/plugins/visualize/public/application/types.ts

@@ -50,7 +50,7 @@ export type PureVisState = SavedVisState;
 
 export interface VisualizeAppState {
   filters: Filter[];
-  uiState: PersistedState;
+  uiState: Record<string, unknown>;
   vis: PureVisState;
   query: Query;
   savedQuery?: string;

src/plugins/visualize/public/application/utils/stubs.ts

@@ -38,7 +38,7 @@ export const visualizeAppStateStub: VisualizeAppState = {
       {
         id: '1',
         enabled: true,
-        // @ts-ignore
+        // @ts-expect-error
         type: 'avg',
         schema: 'metric',
         params: { field: 'total_quantity', customLabel: 'average items' },

src/plugins/visualize/public/application/utils/use/use_editor_updates.test.ts

@@ -37,7 +37,7 @@ describe('useEditorUpdates', () => {
 
   beforeEach(() => {
     mockServices = createVisualizeServicesMock();
-    // @ts-ignore
+    // @ts-expect-error
     mockServices.visualizations.convertFromSerializedVis.mockImplementation(() => ({
       visState: visualizeAppStateStub.vis,
     }));
@@ -105,9 +105,9 @@ describe('useEditorUpdates', () => {
       to: 'now',
     };
     mockFilters = ['mockFilters'];
-    // @ts-ignore
+    // @ts-expect-error
     mockServices.data.query.timefilter.timefilter.getTime.mockImplementation(() => timeRange);
-    // @ts-ignore
+    // @ts-expect-error
     mockServices.data.query.filterManager.getFilters.mockImplementation(() => mockFilters);
   });
 
@@ -210,7 +210,7 @@ describe('useEditorUpdates', () => {
           undefined
         )
       );
-      // @ts-ignore
+      // @ts-expect-error
       const listener = appState.subscribe.mock.calls[0][0];
 
       act(() => {
@@ -233,7 +233,7 @@ describe('useEditorUpdates', () => {
           undefined
         )
       );
-      // @ts-ignore
+      // @ts-expect-error
       const listener = appState.subscribe.mock.calls[0][0];
       const newAppState = {
         ...visualizeAppStateStub,
@@ -262,7 +262,7 @@ describe('useEditorUpdates', () => {
 
     describe('handle linked search changes', () => {
       test('should update saved search id in saved instance', () => {
-        // @ts-ignore
+        // @ts-expect-error
         savedVisInstance.savedSearch = {
           id: 'saved_search_id',
         };
@@ -277,7 +277,7 @@ describe('useEditorUpdates', () => {
             undefined
           )
         );
-        // @ts-ignore
+        // @ts-expect-error
         const listener = appState.subscribe.mock.calls[0][0];
 
         act(() => {
@@ -292,11 +292,11 @@ describe('useEditorUpdates', () => {
       });
 
       test('should remove saved search id from vis instance', () => {
-        // @ts-ignore
+        // @ts-expect-error
         savedVisInstance.savedVis = {
           savedSearchId: 'saved_search_id',
         };
-        // @ts-ignore
+        // @ts-expect-error
         savedVisInstance.savedSearch = {
           id: 'saved_search_id',
         };
@@ -312,7 +312,7 @@ describe('useEditorUpdates', () => {
             undefined
           )
         );
-        // @ts-ignore
+        // @ts-expect-error
         const listener = appState.subscribe.mock.calls[0][0];
 
         act(() => {

src/plugins/visualize/public/application/utils/use/use_saved_vis_instance.test.ts

@@ -204,7 +204,7 @@ describe('useSavedVisInstance', () => {
       );
 
       // mock editor ref
-      // @ts-ignore
+      // @ts-expect-error
       result.current.visEditorRef.current = 'div';
 
       expect(mockGetVisualizationInstance).toHaveBeenCalledWith(mockServices, savedVisId);

src/plugins/visualize/public/application/utils/use/use_visualize_app_state.test.ts

@@ -165,7 +165,7 @@ describe('useVisualizeAppState', () => {
     };
 
     it('should successfully update vis state and set up app state container', async () => {
-      // @ts-ignore
+      // @ts-expect-error
       stateContainerGetStateMock.mockImplementation(() => state);
       const { result, waitForNextUpdate } = renderHook(() =>
         useVisualizeAppState(mockServices, eventEmitter, savedVisInstance)
@@ -188,9 +188,9 @@ describe('useVisualizeAppState', () => {
 
     it(`should add warning toast and redirect to the landing page
         if setting new vis state was not successful, e.x. invalid query params`, async () => {
-      // @ts-ignore
+      // @ts-expect-error
       stateContainerGetStateMock.mockImplementation(() => state);
-      // @ts-ignore
+      // @ts-expect-error
       savedVisInstance.vis.setState.mockRejectedValue({
         message: 'error',
       });