Skip to content

Commit 4c6298a

Browse files
[Metrics UI] Fix No Data preview pluralization (#74399)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent 67275f2 commit 4c6298a

File tree

3 files changed

+19
-4
lines changed

3 files changed

+19
-4
lines changed

x-pack/plugins/infra/public/alerting/common/components/alert_preview.tsx

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,22 @@ export const AlertPreview: React.FC<Props> = (props) => {
186186
{showNoDataResults && previewResult.resultTotals.noData ? (
187187
<FormattedMessage
188188
id="xpack.infra.metrics.alertFlyout.alertPreviewNoDataResult"
189-
defaultMessage="There {noData, plural, one {was # result} other {were # results}} of no data."
189+
defaultMessage="There {boldedResultsNumber} of no data."
190190
values={{
191-
noData: <strong>{previewResult.resultTotals.noData}</strong>,
191+
boldedResultsNumber: (
192+
<strong>
193+
{i18n.translate(
194+
'xpack.infra.metrics.alertFlyout.alertPreviewNoDataResultNumber',
195+
{
196+
defaultMessage:
197+
'{noData, plural, one {was # result} other {were # results}}',
198+
values: {
199+
noData: previewResult.resultTotals.noData,
200+
},
201+
}
202+
)}
203+
</strong>
204+
),
192205
}}
193206
/>
194207
) : null}{' '}

x-pack/plugins/translations/translations/ja-JP.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8837,7 +8837,8 @@
88378837
"xpack.infra.metrics.alertFlyout.alertPreviewErrorResult": "一部のデータを評価するときにエラーが発生しました。",
88388838
"xpack.infra.metrics.alertFlyout.alertPreviewGroups": "{numberOfGroups} {groupName}",
88398839
"xpack.infra.metrics.alertFlyout.alertPreviewGroupsAcross": "すべてを対象にする",
8840-
"xpack.infra.metrics.alertFlyout.alertPreviewNoDataResult": "データがない {noData}結果がありました。",
8840+
"xpack.infra.metrics.alertFlyout.alertPreviewNoDataResult": "データがない {boldedResultsNumber}結果がありました。",
8841+
"xpack.infra.metrics.alertFlyout.alertPreviewNoDataResultNumber": "{noData}",
88418842
"xpack.infra.metrics.alertFlyout.alertPreviewResult": "このアラートは{firedTimes}回発生しました",
88428843
"xpack.infra.metrics.alertFlyout.alertPreviewResultLookback": "過去{lookback}",
88438844
"xpack.infra.metrics.alertFlyout.conditions": "条件",

x-pack/plugins/translations/translations/zh-CN.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8839,7 +8839,8 @@
88398839
"xpack.infra.metrics.alertFlyout.alertPreviewErrorResult": "尝试评估部分数据时发生错误。",
88408840
"xpack.infra.metrics.alertFlyout.alertPreviewGroups": "{numberOfGroups} 个{groupName}",
88418841
"xpack.infra.metrics.alertFlyout.alertPreviewGroupsAcross": "在",
8842-
"xpack.infra.metrics.alertFlyout.alertPreviewNoDataResult": "存在 {noData} 个无数据结果。",
8842+
"xpack.infra.metrics.alertFlyout.alertPreviewNoDataResult": "存在 {boldedResultsNumber} 个无数据结果。",
8843+
"xpack.infra.metrics.alertFlyout.alertPreviewNoDataResultNumber": "{noData}",
88438844
"xpack.infra.metrics.alertFlyout.alertPreviewResult": "此告警将发生 {firedTimes}",
88448845
"xpack.infra.metrics.alertFlyout.alertPreviewResultLookback": "在过去 {lookback}。",
88458846
"xpack.infra.metrics.alertFlyout.conditions": "条件",

0 commit comments

Comments
 (0)