From 4ae7fb41c5e00fda11a05e10af8d8269a958f5f9 Mon Sep 17 00:00:00 2001 From: dej611 Date: Tue, 26 Jan 2021 17:15:36 +0100 Subject: [PATCH] :bug: Referenced operation can be without validation --- x-pack/plugins/lens/public/indexpattern_datasource/utils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/utils.ts b/x-pack/plugins/lens/public/indexpattern_datasource/utils.ts index 253edc046b63de..b5a4905a297383 100644 --- a/x-pack/plugins/lens/public/indexpattern_datasource/utils.ts +++ b/x-pack/plugins/lens/public/indexpattern_datasource/utils.ts @@ -56,6 +56,7 @@ export function isColumnInvalid( const operationDefinition = column.operationType && operationDefinitionMap[column.operationType]; // check also references for errors const referencesHaveErrors = + true && 'references' in column && Boolean(getReferencesErrors(layer, column, indexPattern).filter(Boolean).length); @@ -72,7 +73,7 @@ function getReferencesErrors( return column.references?.map((referenceId: string) => { const referencedOperation = layer.columns[referenceId]?.operationType; const referencedDefinition = operationDefinitionMap[referencedOperation]; - return referencedDefinition.getErrorMessage?.(layer, referenceId, indexPattern); + return referencedDefinition?.getErrorMessage?.(layer, referenceId, indexPattern); }); }