Skip to content

Commit 49da11f

Browse files
[APM] Quote trace id to ensure a word is searched (#69500) (#69504)
* [APM] Quote trace id to ensure a word is searched (#69500) Signed-off-by: Mathis Raguin <mathis@cri.epita.fr> * [APM] Fix TransactionActionMenu tests (one test was not updated) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent 23abe9d commit 49da11f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

x-pack/plugins/apm/public/components/shared/TransactionActionMenu/__test__/TransactionActionMenu.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('TransactionActionMenu component', () => {
9494

9595
expect(mock.core.application.navigateToApp).toHaveBeenCalledWith('logs', {
9696
path:
97-
'link-to/logs?time=1545092070952&filter=trace.id:%228b60bd32ecc6e1506735a8b6cfcf175c%22%20OR%208b60bd32ecc6e1506735a8b6cfcf175c',
97+
'link-to/logs?time=1545092070952&filter=trace.id:%228b60bd32ecc6e1506735a8b6cfcf175c%22%20OR%20%228b60bd32ecc6e1506735a8b6cfcf175c%22',
9898
});
9999
});
100100

x-pack/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe('Transaction action menu', () => {
4242
key: 'traceLogs',
4343
label: 'Trace logs',
4444
href:
45-
'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20123',
45+
'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20%22123%22',
4646
condition: true,
4747
},
4848
],
@@ -113,7 +113,7 @@ describe('Transaction action menu', () => {
113113
key: 'traceLogs',
114114
label: 'Trace logs',
115115
href:
116-
'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20123',
116+
'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20%22123%22',
117117
condition: true,
118118
},
119119
],
@@ -183,7 +183,7 @@ describe('Transaction action menu', () => {
183183
key: 'traceLogs',
184184
label: 'Trace logs',
185185
href:
186-
'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20123',
186+
'some-basepath/app/logs/link-to/logs?time=1580986800&filter=trace.id:%22123%22%20OR%20%22123%22',
187187
condition: true,
188188
},
189189
],

x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ export const getSections = ({
180180
path: `/link-to/logs`,
181181
query: {
182182
time,
183-
filter: `trace.id:"${transaction.trace.id}" OR ${transaction.trace.id}`,
183+
filter: `trace.id:"${transaction.trace.id}" OR "${transaction.trace.id}"`,
184184
},
185185
}),
186186
condition: true,

0 commit comments

Comments
 (0)