[Lens] Only show copy on save for previously saved docs

Author: wylieconlon

x-pack/legacy/plugins/lens/public/app_plugin/app.test.tsx

@@ -12,6 +12,7 @@ import { EditorFrameInstance } from '../types';
 import { Storage } from '../../../../../../src/plugins/kibana_utils/public';
 import { Document, SavedObjectStore } from '../persistence';
 import { mount } from 'enzyme';
+import { SavedObjectSaveModal } from '../../../../../../src/plugins/saved_objects/public';
 import {
   esFilters,
   FilterManager,
@@ -647,6 +648,27 @@ describe('Lens App', () => {
           },
         });
       });
+
+      it('does not show the copy button on first save', async () => {
+        const args = defaultArgs;
+        args.editorFrame = frame;
+
+        instance = mount(<App {...args} />);
+
+        const onChange = frame.mount.mock.calls[0][1].onChange;
+        await act(async () =>
+          onChange({
+            filterableIndexPatterns: [],
+            doc: ({ expression: 'valid expression' } as unknown) as Document,
+          })
+        );
+        instance.update();
+
+        await act(async () => getButton(instance).run(instance.getDOMNode()));
+        instance.update();
+
+        expect(instance.find(SavedObjectSaveModal).prop('showCopyOnSave')).toEqual(false);
+      });
     });
   });
 

x-pack/legacy/plugins/lens/public/app_plugin/app.tsx

@@ -385,7 +385,7 @@ export function App({
             }}
             onClose={() => setState(s => ({ ...s, isSaveModalVisible: false }))}
             title={lastKnownDoc.title || ''}
-            showCopyOnSave={!addToDashboardMode}
+            showCopyOnSave={!!lastKnownDoc.id && !addToDashboardMode}
             objectType={i18n.translate('xpack.lens.app.saveModalType', {
               defaultMessage: 'Lens visualization',
             })}