Skip to content

Commit 4941143

Browse files
author
Aaron Caldwell
committed
Test fixes
1 parent a56435b commit 4941143

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

src/legacy/core_plugins/kibana/public/__tests__/vis_type_vega/vega_visualization.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,14 @@ import {
5959
setData,
6060
setSavedObjects,
6161
setNotifications,
62+
setKibanaMapFactory,
6263
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
6364
} from '../../../../../../plugins/vis_type_vega/public/services';
6465
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
6566
import { setInjectedVarFunc } from '../../../../../../plugins/maps_legacy/public/kibana_services';
6667
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
6768
import { ServiceSettings } from '../../../../../../plugins/maps_legacy/public/map/service_settings';
69+
import { getKibanaMapFactoryProvider } from '../../../../../../plugins/maps_legacy/public';
6870

6971
const THRESHOLD = 0.1;
7072
const PIXEL_DIFF = 30;
@@ -77,6 +79,18 @@ describe('VegaVisualizations', () => {
7779
let vegaVisualizationDependencies;
7880
let vegaVisType;
7981

82+
const coreSetupMock = {
83+
notifications: {
84+
toasts: {},
85+
},
86+
uiSettings: {
87+
get: () => {},
88+
},
89+
injectedMetadata: {
90+
getInjectedVar: () => {},
91+
},
92+
};
93+
setKibanaMapFactory(getKibanaMapFactoryProvider(coreSetupMock));
8094
setInjectedVars({
8195
emsTileLayerId: {},
8296
enableExternalUrls: true,

src/legacy/core_plugins/region_map/public/__tests__/region_map_visualization.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,9 @@ describe('RegionMapsVisualizationTests', function() {
136136
notifications: {
137137
toasts: {},
138138
},
139-
uiSettings: {},
139+
uiSettings: {
140+
get: () => {},
141+
},
140142
injectedMetadata: {
141143
getInjectedVar: () => {},
142144
},

src/plugins/maps_legacy/public/map/base_maps_visualization.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,14 @@ export function BaseMapsVisualizationProvider(getKibanaMap, mapServiceSettings)
116116

117117
_tmsConfigured() {
118118
const { wms } = this._getMapsParams();
119-
const hasTmsBaseLayer = !!wms.selectedTmsLayer;
119+
const hasTmsBaseLayer = wms && !!wms.selectedTmsLayer;
120120

121121
return hasTmsBaseLayer;
122122
}
123123

124124
_wmsConfigured() {
125125
const { wms } = this._getMapsParams();
126-
const hasWmsBaseLayer = !!wms.enabled;
126+
const hasWmsBaseLayer = wms && !!wms.enabled;
127127

128128
return hasWmsBaseLayer;
129129
}

0 commit comments

Comments
 (0)