Fixes feature controls and access control for SIEM and lists plugin

FrankHassanabad · FrankHassanabad · commit 46d60369ed85 · 2020-07-17T13:48:28.000-06:00
diff --git a/x-pack/plugins/lists/server/routes/create_endpoint_list_item_route.ts b/x-pack/plugins/lists/server/routes/create_endpoint_list_item_route.ts
@@ -21,7 +21,7 @@ export const createEndpointListItemRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: ENDPOINT_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/create_endpoint_list_route.ts b/x-pack/plugins/lists/server/routes/create_endpoint_list_route.ts
@@ -26,7 +26,7 @@ export const createEndpointListRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: ENDPOINT_LIST_URL,
       validate: false,
diff --git a/x-pack/plugins/lists/server/routes/create_exception_list_item_route.ts b/x-pack/plugins/lists/server/routes/create_exception_list_item_route.ts
@@ -22,7 +22,7 @@ export const createExceptionListItemRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: EXCEPTION_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/create_exception_list_route.ts b/x-pack/plugins/lists/server/routes/create_exception_list_route.ts
@@ -21,7 +21,7 @@ export const createExceptionListRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: EXCEPTION_LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/create_list_index_route.ts b/x-pack/plugins/lists/server/routes/create_list_index_route.ts
@@ -17,7 +17,7 @@ export const createListIndexRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_INDEX,
       validate: false,
diff --git a/x-pack/plugins/lists/server/routes/create_list_item_route.ts b/x-pack/plugins/lists/server/routes/create_list_item_route.ts
@@ -17,7 +17,7 @@ export const createListItemRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/create_list_route.ts b/x-pack/plugins/lists/server/routes/create_list_route.ts
@@ -17,7 +17,7 @@ export const createListRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/delete_endpoint_list_item_route.ts b/x-pack/plugins/lists/server/routes/delete_endpoint_list_item_route.ts
@@ -21,7 +21,7 @@ export const deleteEndpointListItemRoute = (router: IRouter): void => {
   router.delete(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: ENDPOINT_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/delete_exception_list_item_route.ts b/x-pack/plugins/lists/server/routes/delete_exception_list_item_route.ts
@@ -21,7 +21,7 @@ export const deleteExceptionListItemRoute = (router: IRouter): void => {
   router.delete(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: EXCEPTION_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/delete_exception_list_route.ts b/x-pack/plugins/lists/server/routes/delete_exception_list_route.ts
@@ -21,7 +21,7 @@ export const deleteExceptionListRoute = (router: IRouter): void => {
   router.delete(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: EXCEPTION_LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/delete_list_index_route.ts b/x-pack/plugins/lists/server/routes/delete_list_index_route.ts
@@ -33,7 +33,7 @@ export const deleteListIndexRoute = (router: IRouter): void => {
   router.delete(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_INDEX,
       validate: false,
diff --git a/x-pack/plugins/lists/server/routes/delete_list_item_route.ts b/x-pack/plugins/lists/server/routes/delete_list_item_route.ts
@@ -17,7 +17,7 @@ export const deleteListItemRoute = (router: IRouter): void => {
   router.delete(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/delete_list_route.ts b/x-pack/plugins/lists/server/routes/delete_list_route.ts
@@ -17,7 +17,7 @@ export const deleteListRoute = (router: IRouter): void => {
   router.delete(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/export_list_item_route.ts b/x-pack/plugins/lists/server/routes/export_list_item_route.ts
@@ -18,7 +18,7 @@ export const exportListItemRoute = (router: IRouter): void => {
   router.post(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: `${LIST_ITEM_URL}/_export`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/find_endpoint_list_item_route.ts b/x-pack/plugins/lists/server/routes/find_endpoint_list_item_route.ts
@@ -21,7 +21,7 @@ export const findEndpointListItemRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: `${ENDPOINT_LIST_ITEM_URL}/_find`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/find_exception_list_item_route.ts b/x-pack/plugins/lists/server/routes/find_exception_list_item_route.ts
@@ -21,7 +21,7 @@ export const findExceptionListItemRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: `${EXCEPTION_LIST_ITEM_URL}/_find`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/find_exception_list_route.ts b/x-pack/plugins/lists/server/routes/find_exception_list_route.ts
@@ -21,7 +21,7 @@ export const findExceptionListRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: `${EXCEPTION_LIST_URL}/_find`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/find_list_item_route.ts b/x-pack/plugins/lists/server/routes/find_list_item_route.ts
@@ -22,7 +22,7 @@ export const findListItemRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: `${LIST_ITEM_URL}/_find`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/find_list_route.ts b/x-pack/plugins/lists/server/routes/find_list_route.ts
@@ -18,7 +18,7 @@ export const findListRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: `${LIST_URL}/_find`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/import_list_item_route.ts b/x-pack/plugins/lists/server/routes/import_list_item_route.ts
@@ -26,7 +26,7 @@ export const importListItemRoute = (router: IRouter, config: ConfigType): void =
           maxBytes: config.maxImportPayloadBytes,
           parse: false,
         },
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: `${LIST_ITEM_URL}/_import`,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/patch_list_item_route.ts b/x-pack/plugins/lists/server/routes/patch_list_item_route.ts
@@ -17,7 +17,7 @@ export const patchListItemRoute = (router: IRouter): void => {
   router.patch(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/patch_list_route.ts b/x-pack/plugins/lists/server/routes/patch_list_route.ts
@@ -17,7 +17,7 @@ export const patchListRoute = (router: IRouter): void => {
   router.patch(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/read_endpoint_list_item_route.ts b/x-pack/plugins/lists/server/routes/read_endpoint_list_item_route.ts
@@ -21,7 +21,7 @@ export const readEndpointListItemRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: ENDPOINT_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/read_exception_list_item_route.ts b/x-pack/plugins/lists/server/routes/read_exception_list_item_route.ts
@@ -21,7 +21,7 @@ export const readExceptionListItemRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: EXCEPTION_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/read_exception_list_route.ts b/x-pack/plugins/lists/server/routes/read_exception_list_route.ts
@@ -21,7 +21,7 @@ export const readExceptionListRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: EXCEPTION_LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/read_list_index_route.ts b/x-pack/plugins/lists/server/routes/read_list_index_route.ts
@@ -17,7 +17,7 @@ export const readListIndexRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: LIST_INDEX,
       validate: false,
diff --git a/x-pack/plugins/lists/server/routes/read_list_item_route.ts b/x-pack/plugins/lists/server/routes/read_list_item_route.ts
@@ -17,7 +17,7 @@ export const readListItemRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/read_list_route.ts b/x-pack/plugins/lists/server/routes/read_list_route.ts
@@ -17,7 +17,7 @@ export const readListRoute = (router: IRouter): void => {
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/read_privileges_route.ts b/x-pack/plugins/lists/server/routes/read_privileges_route.ts
@@ -20,7 +20,7 @@ export const readPrivilegesRoute = (
   router.get(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-read'],
       },
       path: LIST_PRIVILEGES_URL,
       validate: false,
diff --git a/x-pack/plugins/lists/server/routes/update_endpoint_list_item_route.ts b/x-pack/plugins/lists/server/routes/update_endpoint_list_item_route.ts
@@ -21,7 +21,7 @@ export const updateEndpointListItemRoute = (router: IRouter): void => {
   router.put(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: ENDPOINT_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/update_exception_list_item_route.ts b/x-pack/plugins/lists/server/routes/update_exception_list_item_route.ts
@@ -21,7 +21,7 @@ export const updateExceptionListItemRoute = (router: IRouter): void => {
   router.put(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: EXCEPTION_LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/update_exception_list_route.ts b/x-pack/plugins/lists/server/routes/update_exception_list_route.ts
@@ -21,7 +21,7 @@ export const updateExceptionListRoute = (router: IRouter): void => {
   router.put(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: EXCEPTION_LIST_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/update_list_item_route.ts b/x-pack/plugins/lists/server/routes/update_list_item_route.ts
@@ -17,7 +17,7 @@ export const updateListItemRoute = (router: IRouter): void => {
   router.put(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_ITEM_URL,
       validate: {
diff --git a/x-pack/plugins/lists/server/routes/update_list_route.ts b/x-pack/plugins/lists/server/routes/update_list_route.ts
@@ -17,7 +17,7 @@ export const updateListRoute = (router: IRouter): void => {
   router.put(
     {
       options: {
-        tags: ['access:lists'],
+        tags: ['access:lists-all'],
       },
       path: LIST_URL,
       validate: {
diff --git a/x-pack/plugins/security_solution/server/plugin.ts b/x-pack/plugins/security_solution/server/plugin.ts
@@ -173,7 +173,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
             'actions-all',
             'alerting-read',
             'alerting-all',
-            'lists',
+            'lists-all',
           ],
           savedObject: {
             all: [
@@ -208,7 +208,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
             'actions-all',
             'alerting-read',
             'alerting-all',
-            'lists',
+            'lists-read',
           ],
           savedObject: {
             all: ['alert', 'action', 'action_task_params'],

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export const createEndpointListItemRoute = (router: IRouter): void => {`
`21`	`21`	`router.post(`
`22`	`22`	`{`
`23`	`23`	`options: {`
`24`		`- tags: ['access:lists'],`
	`24`	`+ tags: ['access:lists-all'],`
`25`	`25`	`},`
`26`	`26`	`path: ENDPOINT_LIST_ITEM_URL,`
`27`	`27`	`validate: {`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export const createEndpointListRoute = (router: IRouter): void => {`
`26`	`26`	`router.post(`
`27`	`27`	`{`
`28`	`28`	`options: {`
`29`		`- tags: ['access:lists'],`
	`29`	`+ tags: ['access:lists-all'],`
`30`	`30`	`},`
`31`	`31`	`path: ENDPOINT_LIST_URL,`
`32`	`32`	`validate: false,`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export const createExceptionListItemRoute = (router: IRouter): void => {`
`22`	`22`	`router.post(`
`23`	`23`	`{`
`24`	`24`	`options: {`
`25`		`- tags: ['access:lists'],`
	`25`	`+ tags: ['access:lists-all'],`
`26`	`26`	`},`
`27`	`27`	`path: EXCEPTION_LIST_ITEM_URL,`
`28`	`28`	`validate: {`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export const createExceptionListRoute = (router: IRouter): void => {`
`21`	`21`	`router.post(`
`22`	`22`	`{`
`23`	`23`	`options: {`
`24`		`- tags: ['access:lists'],`
	`24`	`+ tags: ['access:lists-all'],`
`25`	`25`	`},`
`26`	`26`	`path: EXCEPTION_LIST_URL,`
`27`	`27`	`validate: {`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export const createListIndexRoute = (router: IRouter): void => {`
`17`	`17`	`router.post(`
`18`	`18`	`{`
`19`	`19`	`options: {`
`20`		`- tags: ['access:lists'],`
	`20`	`+ tags: ['access:lists-all'],`
`21`	`21`	`},`
`22`	`22`	`path: LIST_INDEX,`
`23`	`23`	`validate: false,`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export const deleteEndpointListItemRoute = (router: IRouter): void => {`
`21`	`21`	`router.delete(`
`22`	`22`	`{`
`23`	`23`	`options: {`
`24`		`- tags: ['access:lists'],`
	`24`	`+ tags: ['access:lists-all'],`
`25`	`25`	`},`
`26`	`26`	`path: ENDPOINT_LIST_ITEM_URL,`
`27`	`27`	`validate: {`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export const deleteExceptionListItemRoute = (router: IRouter): void => {`
`21`	`21`	`router.delete(`
`22`	`22`	`{`
`23`	`23`	`options: {`
`24`		`- tags: ['access:lists'],`
	`24`	`+ tags: ['access:lists-all'],`
`25`	`25`	`},`
`26`	`26`	`path: EXCEPTION_LIST_ITEM_URL,`
`27`	`27`	`validate: {`