[APM] Lowercase agent names so icons work (#66824)

* [APM] Lowercase agent names so icons work

.NET agent name can be reported as "dotNet" instead of "dotnet". Lowercase the key so either one will work.

* Extract getNormalizedAgentName

Author: smith

x-pack/plugins/apm/common/agent_name.ts

@@ -41,3 +41,16 @@ export function isJavaAgentName(
 ): agentName is 'java' {
   return agentName === 'java';
 }
+
+/**
+ * "Normalizes" and agent name by:
+ *
+ * * Converting to lowercase
+ * * Converting "rum-js" to "js-base"
+ *
+ * This helps dealing with some older agent versions
+ */
+export function getNormalizedAgentName(agentName?: string) {
+  const lowercased = agentName && agentName.toLowerCase();
+  return isRumAgentName(lowercased) ? 'js-base' : lowercased;
+}

x-pack/plugins/apm/public/components/app/ServiceMap/Cytoscape.stories.tsx

@@ -186,6 +186,13 @@ storiesOf('app/ServiceMap/Cytoscape', module)
             'agent.name': 'dotnet'
           }
         },
+        {
+          data: {
+            id: 'dotNet',
+            'service.name': 'dotNet service',
+            'agent.name': 'dotNet'
+          }
+        },
         {
           data: {
             id: 'go',

x-pack/plugins/apm/public/components/app/ServiceMap/icons.ts

@@ -5,7 +5,7 @@
  */
 
 import cytoscape from 'cytoscape';
-import { isRumAgentName } from '../../../../common/agent_name';
+import { getNormalizedAgentName } from '../../../../common/agent_name';
 import {
   AGENT_NAME,
   SPAN_SUBTYPE,
@@ -87,8 +87,7 @@ const agentIcons: { [key: string]: string } = {
 };
 
 function getAgentIcon(agentName?: string) {
-  // RUM can have multiple names. Normalize it
-  const normalizedAgentName = isRumAgentName(agentName) ? 'js-base' : agentName;
+  const normalizedAgentName = getNormalizedAgentName(agentName);
   return normalizedAgentName && agentIcons[normalizedAgentName];
 }