Remove default rewrite-appender.

Author: lukeelmers

src/core/server/logging/logging_config.test.ts

@@ -48,35 +48,13 @@ test('`getLoggerContext()` returns correct joined context name.', () => {
 test('correctly fills in default config.', () => {
   const configValue = new LoggingConfig(config.schema.validate({}));
 
-  expect(configValue.appenders.size).toBe(3);
+  expect(configValue.appenders.size).toBe(2);
 
   expect(configValue.appenders.get('default')).toEqual({
     type: 'console',
     layout: { type: 'pattern', highlight: true },
   });
   expect(configValue.appenders.get('console')).toEqual({
-    type: 'rewrite',
-    appenders: ['rewrite-console'],
-    policy: {
-      type: 'meta',
-      mode: 'update',
-      properties: [
-        {
-          path: 'http.request.headers.authorization',
-          value: '[REDACTED]',
-        },
-        {
-          path: 'http.request.headers.cookie',
-          value: '[REDACTED]',
-        },
-        {
-          path: 'http.response.headers.set-cookie',
-          value: '[REDACTED]',
-        },
-      ],
-    },
-  });
-  expect(configValue.appenders.get('rewrite-console')).toEqual({
     type: 'console',
     layout: { type: 'pattern', highlight: true },
   });
@@ -94,7 +72,7 @@ test('correctly fills in custom `appenders` config.', () => {
     })
   );
 
-  expect(configValue.appenders.size).toBe(3);
+  expect(configValue.appenders.size).toBe(2);
 
   expect(configValue.appenders.get('default')).toEqual({
     type: 'console',
@@ -211,7 +189,6 @@ describe('extend', () => {
     expect([...mergedConfigValue.appenders.keys()]).toEqual([
       'default',
       'console',
-      'rewrite-console',
       'file1',
       'file2',
     ]);

src/core/server/logging/logging_config.ts

@@ -28,21 +28,6 @@ const ROOT_CONTEXT_NAME = 'root';
  */
 const DEFAULT_APPENDER_NAME = 'default';
 
-/**
- * Sensitive `LogMeta` paths that we want to censor by default.
- * These paths are only filtered in a default logging configuration.
- */
-const SENSITIVE_META_PATHS = [
-  'http.request.headers.authorization',
-  'http.request.headers.cookie',
-  'http.response.headers.set-cookie',
-] as const;
-
-/**
- * Replacement text to use when censoring SENSITIVE_META_PATHS.
- */
-const REDACTED_META_TEXT = '[REDACTED]';
-
 const levelSchema = schema.oneOf(
   [
     schema.literal('all'),
@@ -168,26 +153,7 @@ export class LoggingConfig {
       } as AppenderConfigType,
     ],
     [
-      // By default, we transparently rewrite `LogMeta` sent to the
-      // console appender to remove potentially sensitive keys.
-      // This logic is also hardcoded in the http response logger
-      // itself, but included here as an additional measure for
-      // other loggers which might be logging the same data.
       'console',
-      {
-        type: 'rewrite',
-        appenders: ['rewrite-console'],
-        policy: {
-          type: 'meta',
-          mode: 'update',
-          properties: SENSITIVE_META_PATHS.map((path) => ({ path, value: REDACTED_META_TEXT })),
-        },
-      } as AppenderConfigType,
-    ],
-    [
-      // This is our actual console appender which the rewrite appender
-      // sends its records to.
-      'rewrite-console',
       {
         type: 'console',
         layout: { type: 'pattern', highlight: true },